Hi Derek,
a couple of nits, if I may:
* Derek Price wrote on Thu, Sep 25, 2008 at 12:11:27AM CEST:
> --- gnulib-tool.orig 2008-09-24 17:48:53.0 -0400
> +++ gnulib-tool 2008-09-24 18:02:27.0 -0400
> +# Treat the shell variable with name $1 like a space delimited stack and
>
Hello Kamil,
Another set of comments:
> There are still opened some licensing issues as we are now waiting for reply
> from original author.
Yes, we need to wait for this to be clear first.
> Could somebody provide me with a complete set of gcc parameters to catch all
> unportable code in th
Hey all,
Anyone mind if I commit the attached patch? It makes `gnulib-tool
--update --lgpl' list all incompatible modules instead of breaking after
the first one, like so:
$ ../gnulib/gnulib-tool --update --lgpl
gnulib-tool: *** incompatible license on modules:
gnulib-tool: *** areadlink-with-si
Kamil Dudka <[EMAIL PROTECTED]> wrote:
> as it was mentioned in the thread at
> http://lists.gnu.org/archive/html/bug-gnulib/2008-09/msg00198.html I propose
> new gnulib module filevercmp - in the attachment.
...
Thanks for all that work!
A few comments in-line:
> From 842bccfc33b46570b73956e39be
Paolo Bonzini wrote:
> Here is the test I'm using to check the correctness of sys_select.
Committed together with the other select stuff after testing on a real
Windows machine.
Paolo
Paolo Bonzini gnu.org> writes:
>
>
> > ! fd = open (filename, O_RDONLY);
> > ! if (fd < 0)
> > return NULL;
> >
> > ! if (fstat (fd, &statbuf) >= 0 && !S_ISDIR (statbuf.st_mode))
> > ! {
> > ! errno = ENOTDIR;
> > ! return NULL;
> > ! }
>
> You're leaking fd
> ! fd = open (filename, O_RDONLY);
> ! if (fd < 0)
> return NULL;
>
> ! if (fstat (fd, &statbuf) >= 0 && !S_ISDIR (statbuf.st_mode))
> ! {
> ! errno = ENOTDIR;
> ! return NULL;
> ! }
You're leaking fd here. Same for open().
Paolo
Hello,
as it was mentioned in the thread at
http://lists.gnu.org/archive/html/bug-gnulib/2008-09/msg00198.html I propose
new gnulib module filevercmp - in the attachment.
There are still opened some licensing issues as we are now waiting for reply
from original author. I've fixed the ambiguity
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 9/24/2008 6:51 AM:
> Thanks. However, right now, if both fopen-safer and fopen are in use,
> then it looks like fopen_safer is used without also picking up rpl_fopen.
> I'm still looking into the best way to make these modu
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 9/24/2008 5:50 AM:
> The bug appears on the same platforms, namely HP-UX and Solaris 9. Therefore
> for the moment an extra autoconf check is not needed. But I agree that it
> should be worked around. I'm applying the patch
Eric Blake wrote:
> > * lib/fopen.c (rpl_fopen): Return NULL if the mode specifies write
> > access and the filename ends in a slash. Code copied from lib/open.c.
>
> Should we also check for the bug, present in at least Irix 5.3, where
> fopen("/dev/null/","r") succeeds instead of failing
11 matches
Mail list logo
