On Sun, Sep 07, 2008 at 08:29:44AM -0600, Eric Blake wrote:
> According to Tom G. Christensen on 9/7/2008 4:47 AM:
> > I've spent some time staring at m4s c-stack conftest program and a
> > similar one from libsigsegv and after some trial and error I've isolated
> > a change which will cause the m4
Bruno Haible <[EMAIL PROTECTED]> writes:
> Simon Josefsson wrote:
>> I'd like to see getndelim2 solve this problem:
>>
>> 1) LGPL license compatibility
>
> Done.
Thanks.
>> 2) Portability: getndelim2 uses freadptr and freedseek which appears
>>non-portable by design (or?) -- having a getlin
Paul Eggert <[EMAIL PROTECTED]> writes:
> That change looks good. Some minor points:
>
>> +/* Given an unsigned 16-bit argument X, return the value corresponding
>> + to rotating the bits N steps to the left. N must be between 1 to
>> + 15 inclusive. */
>> +static inline uint16_t
>> +rotl16
Bruno Haible <[EMAIL PROTECTED]> writes:
> Simon Josefsson wrote:
>> Any objections to this patch?
>
> Yes, I object.
>
> Some people/projects prefer implicit conversions over explicit casts (e.g.
> Paul, coreutils). Some people/projects prefer explicit casts over implicit
> conversions (e.g. me,
>> I disagree. The & => && change inserts a conditional branch into the control
>> flow, with the potential to save a single memory access. I count ca. 2 CPU
>> cycles for a memory access and ca. 8 CPU cycles for a conditional jump,
>> therefore I would say that the change slows down the program a
