Hi Simon,
While testing the coreutils-6.11.104-00a30 coreutils snapshot on
MacOS X 10.5, I got these warnings:
test-base64.c: In function 'main':
test-base64.c:121: warning: format '%d' expects type 'int', but argument 3 has
type 'size_t'
test-base64.c:131: warning: format '%d' expects type 'int
On Thu, 29 May 2008, Ralf Wildenhues wrote:
I'm leaning towards accepting this patch once the above issues and Jim's
comments are addressed. Still thinking about splitting argz.c into one
file per function, though; and I guess testsuite exposure would be a
Remember that from the libtool/libtoo
The current version of argz_stringify will underflow its size_t argument
if 0 is passed in and then go and change lots of '\0' bytes to something
else.
The patch below fixes that by replacing argz_stringify with the version
from glibc-2.7
David
>From 49d7160e112d6807f891043e51f84f7cce8e8470 Mon
>From 7bce6f3f1ac91a482f6c72aa4b84239e5cadfec4 Mon Sep 17 00:00:00 2001
From: David Lutterkort <[EMAIL PROTECTED]>
Date: Wed, 28 May 2008 15:28:57 -0700
Subject: [PATCH 2/3] Add missing argz_* functions from glibc
* argz.c (argz_add_sep, argz_create, argz_create_sep, argz_replace,
argz_delete):
On Thu, 2008-05-29 at 19:43 +0200, Ralf Wildenhues wrote:
> Hi David,
>
> * David Lutterkort wrote on Thu, May 29, 2008 at 01:06:50AM CEST:
> >
> > + for (p = *argz, ap = argv; *ap; ++ap, ++p)
> > + p = __stpcpy (p, *ap);
>
> Any reason this wasn't changed to stpcpy?
Sloppy editing comb
Ralf Wildenhues <[EMAIL PROTECTED]> wrote:
> Hi David,
...
>> +err = __argz_append (&dst, &dst_len, src, (arg - src));
>
> Shouldn't this be argz_append? How come you don't get a link error
> with this?
>
>> + delayed_copy = 0;
>> +}
>> +
Hi David,
* David Lutterkort wrote on Thu, May 29, 2008 at 01:06:50AM CEST:
> * argz.c (argz_add_sep, argz_create, argz_create_sep, argz_replace,
> argz_delete): import almost verbatim from glibc-2.7; only changes are
> additional asserts and renaming of __ functions to public interface
> * ar
David Lutterkort <[EMAIL PROTECTED]> wrote:
> On Thu, 2008-05-29 at 14:17 +0200, Jim Meyering wrote:
>> Only after writing the above did I go look at the unmodified
>> code in gnulib's argz.c, and there, I saw all of the similar,
>> existing uses of assert. Now I see why you've done this.
>
> Hi J
On Thu, 2008-05-29 at 14:17 +0200, Jim Meyering wrote:
> Only after writing the above did I go look at the unmodified
> code in gnulib's argz.c, and there, I saw all of the similar,
> existing uses of assert. Now I see why you've done this.
Hi Jim,
Yes, that's the only reason I added the assert
David Lutterkort <[EMAIL PROTECTED]> wrote:
> * argz.c (argz_add_sep, argz_create, argz_create_sep, argz_replace,
> argz_delete): import almost verbatim from glibc-2.7; only changes are
> additional asserts and renaming of __ functions to public interface
Hi David,
Adding assertions is nice i
Bruno Haible clisp.org> writes:
> Two nits (I'm really only nitpicking):
>
> - You introduce two #ifs that have to be the same condition:
> #if HAVE_FUTIMESAT || HAVE_WORKING_UTIMES
> ...
> #if HAVE_FUTIMESAT || HAVE_WORKING_UTIMES
And only so that C89 compilation will work when you
Eric Blake <[EMAIL PROTECTED]> wrote:
> According to Eric Blake on 5/22/2008 6:51 AM:
> | According to Jim Meyering on 5/22/2008 6:42 AM:
> | |> |> No need to refer the dir by name:
> | |> |>
> | |> |> futimens (dirfd. timespec);
> | |> |
> | |> | Btw., even if you don't consider the Posix 200x f
Eric Blake wrote:
> Tested on cygwin 1.7.0, where futimens and utimensat exist, and on cygwin
> 1.5.25, where those and futimesat are all missing. OK to apply? This
> means that coreutils can now support nanosecond resolution on new enough
> kernels for things like touch and cp -p.
Two nits (I'm
Paolo Bonzini wrote:
> Strange, the script never adds spaces, all it does on ChangeLog lines is
> "s/^ //p" and "s/^+//p".
... on the output of "git diff". But "git diff", for me, produces context-diffs,
not unified diffs, so the script would need to do "s/^ //p" and "s/^+ //p".
Bruno
It did fetch the newest ChangeLog correctly. But it adds a space before
each line of the ChangeLog entry. Tab after space - that does not smell good.
Strange, the script never adds spaces, all it does on ChangeLog lines is
"s/^ //p" and "s/^+//p".
Also, since the gitweb summary view shows
15 matches
Mail list logo
