Re: vasnprintf.c %n blocked under MSVS8

2008-02-07 Thread Bruno Haible
Hi Simon, > Hi! I received a patch for vasnprintf with rationale: From whom, please? I would like to acknowledge the original reporter. > > - fixes vasnprintf for MSVC8 or higher that has also %n blocked I understand that it depends on the MSVCRT.DLL, that is, it will also happen with mingw.

Re: [Bug-tar] Wildcards do not match invalid characters

2008-02-07 Thread Micah Cowan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Micah Cowan wrote: > This would > end up doing the right thing if the locale is UTF-8 but the input string > is in ISO-8859-1. Er, if the locale is UTF-8 or similar and wide characters are using native-order Unicode to represent their values in wchar_

Re: [Bug-tar] Wildcards do not match invalid characters

2008-02-07 Thread Micah Cowan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruno Haible wrote: > Any volunteer wants to write a 'mbsfnmatch' function that works like fnmatch > but supports invalid byte sequences? (I've removed bug-tar from the Cc list but left everyone else; I hope that's as it should be.) Wget is in need o

Re: filenames in error messages

2008-02-07 Thread Eric Blake
According to Jim Meyering on 2/7/2008 1:49 AM: I'm submitting this for review. Any comments before I apply? > >> Is there any reason that shortcuts like quotearg_style_mem are not >> defined, in contrast with quotearg_style(s,a) short for >> quotearg_n_style(0,s,a)? > > I suspect no one notice

Re: filenames in error messages

2008-02-07 Thread Karl Berry
If the file name comes from the portable set ([-_a-zA-Z0-9./], and probably a few others like + that are not required by POSIX), then ... Yes. This is what I plan to propose to rms. I asked the W3 person who originally wrote about this whole thing to get his feedback first. Shou

Re: [Bug-tar] Wildcards do not match invalid characters

2008-02-07 Thread Bruno Haible
Sergey Poznyakoff wrote: > > ... fnmatch() indeed returns -1, which means an > > error happened and perror() says "Invalid or incomplete multibyte > > or wide character". ... > > Thanks for reporting. I am not sure what exclude_fnmatch is supposed > to return on error, since it returns bool, so I'

Re: [Bug-tar] Wildcards do not match invalid characters

2008-02-07 Thread Sergey Poznyakoff
jlh <[EMAIL PROTECTED]> ha escrit: > Ok, here's an update. I could track down the cause of this > problem. In order to match file names to patterns, tar uses the > fnmatch(3), which is provided by glibc. This happens in > lib/exclude.c:149:exclude_fnmatch(). fnmatch() is documented to > return

Re: filenames in error messages

2008-02-07 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 2/7/2008 1:49 AM: | |> I also noticed that once you call quotearg_colon, all future calls to |> quotearg() will behave as though they were quotearg_colon unless you |> manually call set_char_quoting(NULL,':',0). In other

Re: filenames in error messages

2008-02-07 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: ... > resulting quoted buffer). Sure, you can use quotearg_buffer or > quotearg_alloc, but then you have to manage the string yourself, whereas > it would be kind of nice being able to do > ~ error (...,"%s", quotearg_n_style_mem (n, shell_quoting_style, str,

vasnprintf.c %n blocked under MSVS8

2008-02-07 Thread Simon Josefsson
Hi! I received a patch for vasnprintf with rationale: > - fixes vasnprintf for MSVC8 or higher that has also %n blocked The patch was: --- a/lib/gl/vasnprintf.c +++ b/lib/gl/vasnprintf.c @@ -4008,7 +4008,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp, #endif *fbp = dp