Re: strstr speedup

2008-01-12 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 1/12/2008 8:55 AM: |> so we can directly use tolower() here without expanding the |> argument multiple times? | | I would not put side effects into the argument of tolower(): Some platforms | may expand it into a macro whi

Re: strstr speedup

2008-01-12 Thread Bruno Haible
Eric Blake wrote: > Are there still broken platforms out there where tolower() disobeys > the POSIX requirement that it leave the argument unchanged if it was not > already an upper-case letter? This portability problem is very old. I don't think it's still relevant, but I don't know for sure. >

Re: documentation structure

2008-01-12 Thread Bruno Haible
I wrote and Eric Blake agreed: > | If gnulib implements a significant number of functions specified by glibc > | - strsignal was just mentioned - then I'm in favour two additional chapters > | * GNU libc Header File Substitutes > | * GNU libc Function Substitutes > | that makes it clear that th

Re: strstr speedup

2008-01-12 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 1/10/2008 10:25 PM: | How's this for strcasestr? | #define TOLOWER(Ch) (isupper (Ch) ? tolower (Ch) : (Ch)) | | -/* Knuth-Morris-Pratt algorithm. */ | +/* Two-Way algorithm. */ | +#define RETURN_TYPE char * | +#define AV

getdate.y fails to compile on QNX 6

2008-01-12 Thread Matt Kraai
Howdy, When I try to compile tar 1.19 on QNX 6, it fails with the following error message: source='getdate.c' object='getdate.o' libtool=no \ DEPDIR=.deps depmode=gcc /bin/sh ../build-aux/depcomp \ gcc -DHAVE_CONFIG_H -I. -I. -I.. -g -O2 -c -o getdate.o getdate.c getdate.y:118: negative w

announce-gen improvements

2008-01-12 Thread Jim Meyering
I've just pushed the following two changes: (copyright- and version-string changes omitted here) The first is a no-brainer: support lzma. The second may require some adaptation. If you use announce-gen's relatively new --bootstrap-tools=LIST option, you'll probably want to do something similar to