Re: Compiler warning in glob

2007-10-17 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > Hmm - do we need to make glob depend on the *at modules? Good suggestion; thanks. I installed this into gnulib: 2007-10-17 Paul Eggert <[EMAIL PROTECTED]> Modify glob.c to use fstatat and dirfd, to simplify it. Suggested by Eric Blake.

Re: don't dereference NULL

2007-10-17 Thread Bruno Haible
Hi Jim, > diff --git a/m4/locale-fr.m4 b/m4/locale-fr.m4 > ... > +#ifdef __CYGWIN__ > ... > + if (strchr (getenv ("LC_ALL"), '.') == NULL) return 1; > > That will segfault (dereference NULL) when getenv returns NULL. > Surely that was unintentional... It was intentional. getenv cannot

several trim bugs

2007-10-17 Thread Colin Watson
Firstly, the trim module fails to add its files to lib_SOURCES, so they don't get built. Secondly, after fixing that, it tries to include "mbuiter.h" without depending on that module. On inspection, I found that it claims to be including it for MB_CUR_MAX, but that's actually in (the only system

gnulib-tool

2007-10-17 Thread Ralf Wildenhues
While experimenting with a module named foo-testsuite, I noted this glitch in gnulib-tool, and applied the obvious fix. Cheers, Ralf 2007-10-17 Ralf Wildenhues <[EMAIL PROTECTED]> * gnulib-tool (func_get_dependencies): Fix sed script to match only tests. diff --git a/gnulib-to

Re: gplv3 files and updates

2007-10-17 Thread Brett Smith
On Tue, Oct 16, 2007 at 09:44:37AM -0700, Paul Eggert wrote: > > The confusion comes up because the headers in the individual files > > say something else: they say it's GPLed, period. Given this > > discrepancy, which source of information should users believe? > > They should believe the licens

Re: lib/string.in.h needs

2007-10-17 Thread Ralf Wildenhues
Hello Albert, * Albert Chin wrote on Wed, Oct 17, 2007 at 05:58:15PM CEST: > > * lib/string.in.h: Include before . > This fixes a compilation error on HP-UX, due to the system's > "restrict"-using strsep prototype. config.h should be included from each .c file as f

lib/string.in.h needs

2007-10-17 Thread Albert Chin
I received the following error after importing gnulib into scponly: cc -DHAVE_CONFIG_H -I. -DDEBUGFILE=\"/tmp/scponly46/etc/debuglevel\" -DPROG_CD=\"cd\" -Ilib -z +O2 +Ofltacc +Olit=all +Oentrysched +Odataprefetch +Onolimit -c scponly.c cc: "lib/string.h", line 298: error 1000: Unexpected

don't dereference NULL

2007-10-17 Thread Jim Meyering
In http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=92a8f360080d91e9e, there are three additions like this: diff --git a/m4/locale-fr.m4 b/m4/locale-fr.m4 ... +#ifdef __CYGWIN__ ... + if (strchr (getenv ("LC_ALL"), '.') == NULL) return 1; That will segfault (dereference NULL)

Re: More attributes on xmalloc and friends?

2007-10-17 Thread Jim Meyering
Colin Watson <[EMAIL PROTECTED]> wrote: > If I'm not mistaken, the xalloc family of functions should have the same > set of function attributes as the corresponding functions in glibc. > glibc gives malloc, calloc, and realloc the 'malloc' and > 'warn_unused_result' attributes; similarly, it gives

More attributes on xmalloc and friends?

2007-10-17 Thread Colin Watson
If I'm not mistaken, the xalloc family of functions should have the same set of function attributes as the corresponding functions in glibc. glibc gives malloc, calloc, and realloc the 'malloc' and 'warn_unused_result' attributes; similarly, it gives strdup and strndup the 'malloc' and 'nonnull (1)

Re: stat-time systemology update?

2007-10-17 Thread Bruno Haible
Stepan Kasal wrote: > the top of m4/stat-time.m4 says: > > # st_atim.tv_nsec - Linux, Solaris, Cygwin > # st_atimespec.tv_nsec - FreeBSD, NetBSD, if ! defined _POSIX_SOURCE > # st_atimensec - FreeBSD, NetBSD, if defined _POSIX_SOURCE > # st_atim.st__tim.tv_nsec - UnixWare (at least 2.1.2 through

Re: stat-time systemology update?

2007-10-17 Thread Stepan Kasal
Hello again, I'm sorry that I was too quick writing my previous mail. On Wed, Oct 17, 2007 at 11:34:54AM +0200, Stepan Kasal wrote: > But my GNU libc.info mentiones st_atimensec, but not st_atim. > > So it seems that platforms using GNU libc (GNU/Linux, Cygwin?) are > converging towards POSIX.

stat-time systemology update?

2007-10-17 Thread Stepan Kasal
Hello, the top of m4/stat-time.m4 says: # st_atim.tv_nsec - Linux, Solaris, Cygwin # st_atimespec.tv_nsec - FreeBSD, NetBSD, if ! defined _POSIX_SOURCE # st_atimensec - FreeBSD, NetBSD, if defined _POSIX_SOURCE # st_atim.st__tim.tv_nsec - UnixWare (at least 2.1.2 through 7.1) But my GNU libc.in