Re: strings.h in argz.c?

2007-01-21 Thread Simon Josefsson
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > We got a bug report about Libtool 1.5.22 and SunOS 4.1.x this year, so > I'm not doing any C89 cleanup on branch-1-5. That's not a problem, I only meant it to apply to future version. (I assume there will be future versions not based on branch-1-5 ;-

Re: Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".

2007-01-21 Thread Simon Josefsson
"James Youngman" <[EMAIL PROTECTED]> writes: > However, I think the problem is that on this system, the Makefile.in > file is not actually using @MKDIR_P@ :- Yes, I still get the same problem. I have tried Bruno's patch, but it makes no difference. The problem seems indeed to be that Makefile.i

Re: Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".

2007-01-21 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> wrote: >> This patch seem to cause plenty of build failures like this: > > Hi Simon, > > Thanks for the report. > What version of autoconf are you using on that system? dopio:/data/gnulib/build/gettime# autoconf --vers

Re: strings.h in argz.c?

2007-01-21 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > IIRC that was because I could not get into contact with the bug reporter. My experience is that everyone who's reported a bug against SunOS 4.1.x for several years, is either (1) doing it only because they're worried we might still want to be portable

Re: Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".

2007-01-21 Thread Bruno Haible
James Youngman wrote: > My generated aclocal.m4 file wants to substiture mkdir_p (courtesy of > AM_PROG_MKDIR_P) but doesn't define AC_PROG_MKDIR_P. Nevertheless my > gnulib-common.m4 file is indeed at serial 2 and the gl_INIT in > gnulib/m4/gnulib-comp.m4 does indeed invoke AC_PROG_MKDIR_P. Huh

Re: Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".

2007-01-21 Thread James Youngman
I've just synced my CVS version of gnulib and it includes that ChangeLog entry. I am using Autoconf version 2.61 and Automake version 1.9.6. My generated aclocal.m4 file wants to substiture mkdir_p (courtesy of AM_PROG_MKDIR_P) but doesn't define AC_PROG_MKDIR_P. Nevertheless my gnulib-common

Re: Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".

2007-01-21 Thread Bruno Haible
Jim Meyering asked: > That is, *if* gnulib needs to support autoconf older than 2.60. Yes, the current minimum requirement is autoconf 2.59. > Do any of you know of gnulib-using projects that require > autoconf 2.59 or older? Chasing the URLs in users.txt: Net::CDP, diffutils, gpg, gsasl, inetut

new module striconveha

2007-01-21 Thread Bruno Haible
The next iconv related module adds support for autodetection of the source encoding. 2007-01-21 Bruno Haible <[EMAIL PROTECTED]> * modules/striconveha: New file. * lib/striconveha.h: New file. * lib/striconveha.c: New file. * MODULES.html.sh (Internationalization

Re: Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".

2007-01-21 Thread Jim Meyering
Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > * Jim Meyering wrote on Sun, Jan 21, 2007 at 10:27:30PM CET: >> Simon Josefsson <[EMAIL PROTECTED]> wrote: >> > This patch seem to cause plenty of build failures like this: > >> What version of autoconf are you using on that system? > > AC_PROG_MKDIR_P i

another striconv fix

2007-01-21 Thread Bruno Haible
This fixes an errno value in case of an out-of-memory failure. 2007-01-21 Bruno Haible <[EMAIL PROTECTED]> * lib/striconv.c (str_iconv): Guarantee errno is set when strdup fails. * lib/striconveh.c (str_iconveh): Likewise. *** lib/striconv.c 16 Jan 2007 03:25:12 -

Re: strings.h in argz.c?

2007-01-21 Thread Ralf Wildenhues
[ let's drop bug-libtool ] * Paul Eggert wrote on Sun, Jan 21, 2007 at 11:02:22PM CET: > Ralf Wildenhues <[EMAIL PROTECTED]> writes: > > > We got a bug report about Libtool 1.5.22 and SunOS 4.1.x this year, so > > I'm not doing any C89 cleanup on branch-1-5. > > "this year" meaning 2007? Or in

striconveh: new function mem_iconveh

2007-01-21 Thread Bruno Haible
To the striconveh module (charset conversion with error handling) I'm adding a variant that operates on non-NUL-terminated strings and that takes the two encodings as arguments. 2007-01-21 Bruno Haible <[EMAIL PROTECTED]> * lib/striconveh.h (mem_iconveh): New declaration. * lib/

Re: strings.h in argz.c?

2007-01-21 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > We got a bug report about Libtool 1.5.22 and SunOS 4.1.x this year, so > I'm not doing any C89 cleanup on branch-1-5. "this year" meaning 2007? Or in the last 12 months? I searched for such a bug report and found only

Re: Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".

2007-01-21 Thread Ralf Wildenhues
* Jim Meyering wrote on Sun, Jan 21, 2007 at 10:27:30PM CET: > Simon Josefsson <[EMAIL PROTECTED]> wrote: > > This patch seem to cause plenty of build failures like this: > What version of autoconf are you using on that system? AC_PROG_MKDIR_P is new in Autoconf 2.60. Cheers, Ralf

Re: Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".

2007-01-21 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > This patch seem to cause plenty of build failures like this: Hi Simon, Thanks for the report. What version of autoconf are you using on that system? I tried to reproduce the failure like this: cd /tmp rm -rf x /gnulib/gnulib-tool --dir x

Re: Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".

2007-01-21 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: > When building coreutils from scratch using "make -j3" on a uniprocessor > system, I encountered this failure: > > ... > mv configmake.h-t configmake.h > mv stdint.h-t stdint.h > test -d sys || mkdir sys > test -d sys || mkdir sys > rm -f sys/s

mem_cd_iconv - a lesson in API design

2007-01-21 Thread Bruno Haible
Hi, This is a schoolbook case about API design. The function mem_cd_iconv returns a block of memory and its length. There are 3 conventions of doing so, known from glibc: int foo (..., &result, &result_length); a) (like vasprintf:) Allocate a fresh block of memory always. b) (like vasnprin

gnulib-tool: fix GNU sed recognition

2007-01-21 Thread Bruno Haible
Hi, The test whether 'sed' supports the --posix option was broken: On MacOS X, "/usr/bin/sed --posix d" succeeds. 2007-01-21 Bruno Haible <[EMAIL PROTECTED]> * gnulib-tool: Fix test whether sed is GNU sed supporting --posix. *** gnulib-tool 17 Jan 2007 23:46:34 - 1.216 --- g

Re: strings.h in argz.c?

2007-01-21 Thread Ralf Wildenhues
Hello Simon, Apologies for the long delay. * Simon Josefsson wrote on Mon, Oct 30, 2006 at 01:46:30PM CET: > Bruno Haible <[EMAIL PROTECTED]> writes: > >> Is strings.h needed on any modern platform? > > > > No. > I see that argz.c comes from libtool. Would this patch be acceptable? > I'm cc:in