Re: Non const global in mbchar.c

John Darrington <[EMAIL PROTECTED]> writes: > One that shows up from gnulib is is_basic_table from mbchar.c > This symbol should be const? Makes sense to me. Here's a proposed patch. 2006-10-25 Paul Eggert <[EMAIL PROTECTED]> * lib/mbchar.c (is_basic_table): Now const. Proble

Non const global in mbchar.c

I've been auditing our project for constness. One that shows up from gnulib is is_basic_table from mbchar.c This symbol should be const? J' -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://pgp.mit.edu or any PGP keyserver for publ

Re: gettext.h patch for portability to sunCC, pgCC, RHEL AS 4 g++

Paul Eggert wrote: > Like Ben Pfaff, I don't understand the assertion that ISO > C++ supports variable-length arrays. Indeed, ISO C++ does not support variable-length arrays. Sorry for the wrong statement. > I just now checked the 2005-10-19 working draft >

Re: gettext.h patch for portability to sunCC, pgCC, RHEL AS 4 g++

Bruno Haible <[EMAIL PROTECTED]> writes: + /* GCC supports variable-size arrays in C and C++ mode. +ISO C++ supports variable-size arrays, but some older PGI and Sun compilers +don't. */ #define _LIBGETTEXT_HAVE_VARIABLE_SIZE_ARRAYS \ ! (__GNUC__ >= 3 \ !|| (defined __cplusplus &&

Re: [bug-gnulib] gettext.h patch for portability to sunCC, pgCC, RHEL AS 4 g++

Ben Pfaff wrote: > I don't understand this assertion that ISO C++ supports > variable-size arrays. ISO C++98 shows the expression in an > array-declarator to be a constant-expression You're right. I was confused. It's only some specific C++ compilers (such as g++) which do support variable-size a

Re: [bug-gnulib] C++ support?

Bob Proulx wrote: > My opinion (which counts for very little here) is that while C++ is > designed to be as close to C as possible, but no closer, that it is > still not C. C++ is not a strict superset of C. It is close but not > perfect. True. Regarding struct and enum type definitions, you hav

Re: [bug-gnulib] C++ support?

Karl Berry asked: > Is supporting compilation with C++ of interest? (I'm not arguing for > it, just reporting it, since Nelson went to the trouble of trying it.) Yes, it is of interest in general. Some GNU projects use C++ in addition to C for purposes that a C compiler cannot fulfill (such as tr

Re: gettext.h patch for portability to sunCC, pgCC, RHEL AS 4 g++

Bruno Haible <[EMAIL PROTECTED]> writes: > + /* GCC supports variable-size arrays in C and C++ mode. > +ISO C++ supports variable-size arrays, but some older PGI and Sun > compilers > +don't. */ I don't understand this assertion that ISO C++ supports variable-size arrays. ISO C++98 sho

Re: cvs commit log messages

Bruno Haible <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> I have found that it is useful to keep the commit log message >> very similar to the ChangeLog entry. > > ... whereas I find it useful to put rationale information into the cvs > commit message. (Because the ChangeLog entry is only su

Re: [bug-gnulib] cvs commit log messages

Jim Meyering wrote: > I have found that it is useful to keep the commit log message > very similar to the ChangeLog entry. ... whereas I find it useful to put rationale information into the cvs commit message. (Because the ChangeLog entry is only supposed to mention _what_ has changed, not _why_.

Re: fts.c doesn't compile with C89 compiler

Jim Meyering <[EMAIL PROTECTED]> wrote: > Bruno Haible <[EMAIL PROTECTED]> wrote: ... >> fts.c:1076: warning: ISO C90 forbids mixed declarations and code >> >> gnulib still assumes C89 only. Here is a fix. >> >> Jim, OK to apply? > > That looks fine. > Yes, thanks. Thanks for checking it in. Howev

Re: gettext.h patch for portability to sunCC, pgCC, RHEL AS 4 g++

Paul Eggert wrote: > However, gettext.h does attempt to be portable to C++, so the problems > you found there suggest that a fix is needed. It currently does this: > > #define _LIBGETTEXT_HAVE_VARIABLE_SIZE_ARRAYS \ > (__GNUC__ >= 3 || defined __cplusplus) > > but (as you've found) older C

Re: texinfo, dashes

Karl Berry wrote: > Indeed, spaces around dashes is an American/European difference. > ... > However, nothing else in Texinfo documents in general, or the Gnulib > document in particular, is typeset in European style, as far as I can > see, so the spaces seem out of place to me. But when I sit dow

fix 'striconv' on NetBSD

Hi, NetBSD has an iconv() with a similar behaviour as Irix iconv(). I'm applying this patch. It has the effect that the 'striconv' functions will prefer returning a failure code rather than a string full of question marks. In other words, it will make 'striconv' behave the same way on NetBSD as o