Fwd: [Bug libc/3045] add verror

2006-08-21 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Oh well, it looks like verror will have to remain its own module, and inefficiently malloc its own string to pass on to error, as Ulrich didn't agree with my views that exposing a va_list version would allow for more efficient code. - Origina

Re: hello 2.1.91 pretest

2006-08-21 Thread Karl Berry
Hi Mark, Thanks for taking a look at this. Hmmm... It might be nice if there were some kind of a readme that talks about the non-default location of the m4 directory being in gnulib/m4 Ok, good, I will add something to README.dev about that. instead of m4 ... I changed from the de

Re: hello 2.1.91 pretest

2006-08-21 Thread Karl Berry
Please remove the file m4/strerror_r.m4 from hello; Puzzling. All I ever do is run gnulib-tool, and it's figured out that other files need to be removed. I wonder why that one wasn't. Anyway, thanks. Second, please apply the first patch below. Ack. Then, I'd apply the second pa

Re: coreutils-6.0 on BeOS (3)

2006-08-21 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > ! #if HAVE_FCHMOD > ! if (0 <= fd) > ! result = fchmod (fd, chmod_mode); > ! else > ! #endif Thanks for the report and fix. A couple of things: first, I prefer to avoid #if in C functions when it's easy. Also, we need to

Re: GNULIB stdint_.h vs windows VC6 compiler

2006-08-21 Thread Dennis Jones
I'll run the build manually right now -- should see results in a few minutes. - Dennis - Original Message - From: "Mark D. Baushke" <[EMAIL PROTECTED]> To: "Dennis Jones" <[EMAIL PROTECTED]> Cc: "Paul Eggert" <[EMAIL PROTECTED]>; ; Sent: Monday, August 21, 2006 12:29 PM Subject: Re

Re: GNULIB stdint_.h vs windows VC6 compiler

2006-08-21 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Dennis, You are correct that support for the windows-based client of CVS has been neglected. I personally do not have any way to compile it. I only see the compilation errors being sent to the cvs-test-results list. If I see something that I think

Re: [bug-gnulib] Compilation failure of xvasprintf.c on FreeBSD 4.x

2006-08-21 Thread Bruno Haible
Hi, Martin Lambers wrote: > Roman Bogorodskiy reported that xvasprintf.c fails to compile on FreeBSD > 4.x, and that the patch below fixes that. He can give more details if > necessary. Apparently, FreeBSD does not have va_copy(). This should be > catched by stdarg.m4, right? Right. The details t

Re: GNULIB stdint_.h vs windows VC6 compiler

2006-08-21 Thread Dennis Jones
- Original Message - From: "Paul Eggert" <[EMAIL PROTECTED]> To: "Dennis Jones" <[EMAIL PROTECTED]> Cc: ; "Mark D. Baushke" <[EMAIL PROTECTED]>; Sent: Monday, August 21, 2006 9:57 AM Subject: Re: GNULIB stdint_.h vs windows VC6 compiler "Dennis Jones" <[EMAIL PROTECTED]> writes:

gnulib-tool: make it possible to install the generated library

2006-08-21 Thread Bruno Haible
Hi, I added this change to gnulib-tool. It will allow for libgettextlib to be installed as a shared library, saving some disk space for a few installed programs. 2006-08-21 Bruno Haible <[EMAIL PROTECTED]> * gnulib-tool (func_emit_lib_Makefile_am): If the snippets already specif

Re: [bug-gnulib] Initialization of pkgdata_DATA

2006-08-21 Thread Martin Lambers
On Mon, 21. Aug 2006, 20:15:41 +0200, Bruno Haible wrote: > Martin Lambers wrote: > > Currently, 'make install' in the gnulib directory of my projects always > > creates the directory $(pkgdatadir) (/usr/local/share/ by > > default), even if it is empty. > > > > If I remove the initialization of p

coreutils-6.0 on BeOS (3)

2006-08-21 Thread Bruno Haible
Compiling coreutils-6.0 on BeOS, we have this warning: source='dirchownmod.c' object='dirchownmod.o' libtool=no \ DEPDIR=.deps depmode=gcc /bin/sh ../build-aux/depcomp \ gcc -DHAVE_CONFIG_H -DLIBDIR=\"/boot/home/config/lib\" -I. -I. -I.. -I.. -I. -Wall -I/boot/home/config/include -g -O2 -c dir

coreutils-6.0 on BeOS (2)

2006-08-21 Thread Bruno Haible
Compiling coreutils-6.0 on BeOS leads to a compilation error: source='strstr.c' object='strstr.o' libtool=no \ DEPDIR=.deps depmode=gcc /bin/sh ../build-aux/depcomp \ gcc -DHAVE_CONFIG_H -DLIBDIR=\"/boot/home/config/lib\" -I. -I. -I.. -I.. -I. -Wall -I/boot/home/config/include -g -O2 -c strstr

Re: [bug-gnulib] Initialization of pkgdata_DATA

2006-08-21 Thread Bruno Haible
Martin Lambers wrote: > Currently, 'make install' in the gnulib directory of my projects always > creates the directory $(pkgdatadir) (/usr/local/share/ by > default), even if it is empty. > > If I remove the initialization of pkgdata_DATA in Makefile.am, the > directory is not created. I'm commi

Re: [bug-gnulib] gnulib changes to make it easier for coreutils to use gnulib-tool

2006-08-21 Thread Bruno Haible
Paul Eggert wrote: > Is this as simple as removing the AC_SOURCES lines in the .m4 files, > and replacing them with Files: lines in the modules file It's as simple as removing the AC_SOURCES lines and adding the files to lib_SOURCES or noinst_HEADERS or EXTRA_DIST. For a .h file it doesn't matter

Compilation failure of xvasprintf.c on FreeBSD 4.x

2006-08-21 Thread Martin Lambers
Hi! Roman Bogorodskiy reported that xvasprintf.c fails to compile on FreeBSD 4.x, and that the patch below fixes that. He can give more details if necessary. Apparently, FreeBSD does not have va_copy(). This should be catched by stdarg.m4, right? Regards, Martin --- gnulib/xvasprintf.c.orig

Initialization of pkgdata_DATA

2006-08-21 Thread Martin Lambers
Hi! Currently, 'make install' in the gnulib directory of my projects always creates the directory $(pkgdatadir) (/usr/local/share/ by default), even if it is empty. If I remove the initialization of pkgdata_DATA in Makefile.am, the directory is not created. No module that I use modifies the pkgd

Re: GNULIB stdint_.h vs windows VC6 compiler

2006-08-21 Thread Paul Eggert
"Dennis Jones" <[EMAIL PROTECTED]> writes: > #if (LONG_MAX >> 31) >> 31 == 1 It's not a good sign if the compiler can't handle binary operator precedence; it suggests that other bugs are lurking in the neighborhood. I assume that this would need to be done in two places? There are two instances

Re: GNULIB stdint_.h vs windows VC6 compiler

2006-08-21 Thread Dennis Jones
Mark, Add parentheses: #if (LONG_MAX >> 31) >> 31 == 1 - Dennis - Original Message - From: "Mark D. Baushke" <[EMAIL PROTECTED]> To: Cc: ; "Dennis Jones" <[EMAIL PROTECTED]> Sent: Monday, August 21, 2006 3:08 AM Subject: GNULIB stdint_.h vs windows VC6 compiler -BEGIN PGP SIGN

Re: [bug-gnulib] hello 2.1.91 pretest

2006-08-21 Thread Bruno Haible
Paul Eggert wrote: > > ../gnulib/gnulib-tool: syntax error at line 634: `}' unexpected > > The Solaris /bin/sh doesn't conform to POSIX: > >$ /bin/sh -c 'if ! false; then echo good; else echo bad; fi' >/bin/sh: !: not found >bad Thanks for the quick diagnosis. Without it, I was tempt

GNULIB stdint_.h vs windows VC6 compiler

2006-08-21 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Folks, It seems that the latest stdint_.h file is using contructs that is confusing the windows VC6 compiler used to build the CVS sources. The two problems are .\windows-NT\stdint.h(133) : warning C4067: unexpected tokens following preprocesso

Re: hello 2.1.91 pretest

2006-08-21 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Hello Mark, > > * Mark D. Baushke wrote on Mon, Aug 21, 2006 at 10:37:06AM CEST: > > Ralf Wildenhues <[EMAIL PROTECTED]> writes: > > > > > > Suggested patch below. OK? > > > > I like your change as I t

Re: hello 2.1.91 pretest

2006-08-21 Thread Ralf Wildenhues
Hello Mark, * Mark D. Baushke wrote on Mon, Aug 21, 2006 at 10:37:06AM CEST: > Ralf Wildenhues <[EMAIL PROTECTED]> writes: > > > > Suggested patch below. OK? > > I like your change as I think it makes it easier to understand. Thanks. I'll apply in a day or two if noone objects. > I suggest y

Re: hello 2.1.91 pretest

2006-08-21 Thread Mark D. Baushke
Hi Ralf, Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Hello Mark, everyone, > > I'm all for making gnulib-tool portable in practice (and not only in > theory), if only to avoid further such bug reports; but this patch > definitely changes the semantics (the `!' "binds" higher than `||', > if on

FYI: acl module missing dependencies

2006-08-21 Thread Jim Meyering
Running check-module on the "acl" module reported this: lib/acl.c: error.h is `#include'd, but not listed in module's Files: section lib/acl.c: quote.h is `#include'd, but not listed in module's Files: section So I added the missing dependencies: * modules/acl (Depends-on): Add error

FYI: check-module: add at-func.c to white-list

2006-08-21 Thread Jim Meyering
Checking openat produced this: $ cd modules && ../check-module openat check-module: ../lib/openat.c: duplicate inclusion of at-func.c check-module: ../lib/openat.c: duplicate inclusion of at-func.c So I fixed it: * check-module (find_included_lib_files): Add at-func.c to the

Re: hello 2.1.91 pretest

2006-08-21 Thread Ralf Wildenhues
Hello Mark, everyone, I'm all for making gnulib-tool portable in practice (and not only in theory), if only to avoid further such bug reports; but this patch definitely changes the semantics (the `!' "binds" higher than `||', if one can reasonably speak about "binding" in shell grammar). Suggeste

Re: hello 2.1.91 pretest

2006-08-21 Thread Ralf Wildenhues
Hello Karl, * Karl Berry wrote on Mon, Aug 21, 2006 at 02:21:26AM CEST: > > I have not followed recent Automake/Autoconf developments in detail, > so the configure.ac and Makefile.am's would be especially good for > others to take a look at. Please remove the file m4/strerror_r.m4 from hello; it

Re: hello 2.1.91 pretest

2006-08-21 Thread Mark D. Baushke
Paul Eggert <[EMAIL PROTECTED]> writes: > "Mark D. Baushke" <[EMAIL PROTECTED]> writes: > > >../gnulib/gnulib-tool --update > > > > command from the hello-2.1.91 directory on a Solaris 9 box yeilds a > > syntax error: > > > > ../gnulib/gnulib-tool: syntax error at line 634: `}' unexpected >

Re: gnulib changes to make it easier for coreutils to use gnulib-tool

2006-08-21 Thread Jim Meyering
Paul Eggert <[EMAIL PROTECTED]> wrote: > I am changing coreutils so that it will use gnulib-tool. As the first > part of this project I'm installing the following changes into gnulib. > I've tried to keep the changes "minimal", but that's a relative term > when talking about a change of this magni