Re: new module proposal: verror

2006-08-04 Thread Ben Pfaff
Eric Blake <[EMAIL PROTECTED]> writes: > +void > +verror (int status, int errnum, const char *format, va_list args) > +{ > + char *message = xvasprintf (format, args); > + error (status, errnum, message); Surely that should be error (status, errnum, "%s", message); and similarly for ver

new module proposal: verror

2006-08-04 Thread Eric Blake
Based on Bruno's objection to alter the API of error.h, and my desire to still have a useful va_list error variant for use in m4, I propose this new module. Any objections to installing this? If my bug reports to glibc result in glibc adding something similar, I can revisit this module to merg

Re: [bug-gnulib] race condition gnulib-tool's mostlyclean-local rule

2006-08-04 Thread Bruno Haible
Ralf Wildenhues wrote: > the right fix would be to add dependency information > mostlyclean-local: mostlyclean-compile mostlyclean-generic Depending on mostlyclean-compile is not needed, and this rule removes only files in the current directory. I added this fix to gnulib-tool: 2006-08-04 Bru

Re: race condition gnulib-tool's mostlyclean-local rule

2006-08-04 Thread Jim Meyering
Ralf Wildenhues <[EMAIL PROTECTED]> wrote: ... > IMVHO it's ugly (and resource-wasting) to have a $(MAKE) reinvocation > to paper over limitations in the extensibility of Automake-generated > Makefiles; the right fix would be to add dependency information > mostlyclean-local: mostlyclean-compile

Re: race condition gnulib-tool's mostlyclean-local rule

2006-08-04 Thread Ralf Wildenhues
Hello Jim, * Jim Meyering wrote on Fri, Aug 04, 2006 at 04:35:30PM CEST: > > mostlyclean-local: > @test -z "$(MOSTLYCLEANDIRS)" ||\ > for dir in $(MOSTLYCLEANDIRS); do \ > if test -d $$dir; then \ > echo "rmdir $$dir"; rmdir $$dir; \ >

race condition gnulib-tool's mostlyclean-local rule

2006-08-04 Thread Jim Meyering
For some modules (e.g., sys_stat), gnulib-tool generates a mostlyclean-local rule like this: mostlyclean-local: @test -z "$(MOSTLYCLEANDIRS)" ||\ for dir in $(MOSTLYCLEANDIRS); do \ if test -d $$dir; then \ echo "rmdir $$dir"; rm