Re: sys_socket fix to remove WINVER

Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Hi Simon, > > A couple of nits: > > * Simon Josefsson wrote on Wed, Jun 21, 2006 at 07:39:42PM CEST: >> + Currently only MinGW is supported. See the gnulib manual regarding >> + Windows sockets. MinGW have the header files winsock2.h and > > s/

Misleading cast in glob.c

There are casts in glob.c that contain ineffective const's that some compilers warn about: Index: glob.c === RCS file: /cvsroot/cvs/ccvs/lib/glob.c,v retrieving revision 1.18 diff -u -r1.18 glob.c --- glob.c 20 Mar 2006 02:21:56

Re: stdint vs cycle-check.h

Paul Eggert writes: > > [EMAIL PROTECTED] (Larry Jones) writes: > > > > I don't understand that recommendation. Since is supposed > > to #include , why isn't the recommendation: > > As I recall, it's for some older hosts where does not > include . Sorry, I don't recall the details. That's in

stdint module on SGI

Hi Bruno, The following two patches take a closer step toward making things work under the default c89 compiler on SGI boxes. All files that #include still get warnings like this one: cc-1035 cc: WARNING File = /usr/include/stdint.h, Line = 5 #error directive: This header file is to be used

Re: sys_socket fix to remove WINVER

Hi Simon, A couple of nits: * Simon Josefsson wrote on Wed, Jun 21, 2006 at 07:39:42PM CEST: > + Currently only MinGW is supported. See the gnulib manual regarding > + Windows sockets. MinGW have the header files winsock2.h and s/have/has/ > + ws2tcpip.h that declare the sys/socket.h

sys_socket fix to remove WINVER

Given the insight discussed in my getaddrinfo e-mail, I've installed this. --- socket_.h 16 Jun 2006 17:35:42 +0200 1.5 +++ socket_.h 21 Jun 2006 19:35:45 +0200 @@ -1,4 +1,4 @@ -/* Provide a sys/socket header file for systems lacking it (read: mingw32). +/* Provide a sys/socket head

Windows fixes for sockpfaf

This patch makes sockpfaf define HAVE_IPV? properly when cross-compiling to mingw32. (For reference, IPv4 is detected, but not IPv6.) I'd admit that these winsock2.h tests are a bit ugly, but I don't see a good alternative. Ideas? --- sockpfaf.m4 16 Jun 2006 17:36:05 +0200 1.2 +++ sockpfaf

getaddrinfo windows fixes

I've noticed that getaddrinfo didn't exist in ws2_32.dll on Windows 2000. The hack in the getaddrinfo module to define WINVER to 0x0501 seems like an incorrect approach. Ideally, the replacement code should, during runtime, open ws2_32.dll and check for the getaddrinfo symbol and use it if presen

Re: small inet_ntop.m4 fix

Simon Josefsson <[EMAIL PROTECTED]> writes: > Yoann Vandoorselaere <[EMAIL PROTECTED]> writes: > >> On Sat, 2006-06-17 at 21:02 +0200, Simon Josefsson wrote: >>> Hi Yoann! Ok to install this? Gnulib assumes that sys/types.h >>> exists, and inet_ntop never tested HAVE_SYS_TYPES_H anyway. >> >> Hi

Re: new module: inet_pton

Simon Josefsson <[EMAIL PROTECTED]> writes: > Instead of a "inet" module with both inet_ntop and inet_pton, here is > one new module for inet_pton only, to smooth backwards compatibility > with people using the current "inet_ntop" module. > > The code is from glibc, with fixes similar to those in

Re: read-file

Paul Eggert <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> writes: > >> --- read-file.c 16 Jun 2006 21:26:36 +0200 1.1 >> +++ read-file.c 17 Jun 2006 18:22:29 +0200 >> @@ -43,6 +43,9 @@ >>if (!buf) >> return NULL; >> >> + if (ferror (stream)) >>

Re: stdint vs cycle-check.h

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Larry Jones <[EMAIL PROTECTED]> writes: > Paul Eggert writes: > > > > For cycle-check.h I'd think this wouldn't be a problem, since > > cycle-check.h uses this Autoconf-recommended sequence: > > > > # if HAVE_INTTYPES_H > > # include > > # endif >