Re: test failures: crc, md4, gc-md4

2006-05-11 Thread Simon Josefsson
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Hi Simon, > > * Simon Josefsson wrote on Thu, May 11, 2006 at 06:14:19PM CEST: >> Ralf Wildenhues <[EMAIL PROTECTED]> writes: >> > >> > There's still the test-crc failure remaining. > >> > | cu got b9a9a617 >> > | FAIL: test-crc > >> Hi Ralf! Paul's f

Re: test failures: crc, md4, gc-md4

2006-05-11 Thread Ralf Wildenhues
Hi Simon, * Simon Josefsson wrote on Thu, May 11, 2006 at 06:14:19PM CEST: > Ralf Wildenhues <[EMAIL PROTECTED]> writes: > > > > There's still the test-crc failure remaining. > > | cu got b9a9a617 > > | FAIL: test-crc > Hi Ralf! Paul's fixes to the crc module are installed now, did they > solve

Re: test failures: crc, md4, gc-md4

2006-05-11 Thread Simon Josefsson
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Hi Simon, > > * Simon Josefsson wrote on Wed, May 10, 2006 at 03:39:50PM CEST: >> Ralf Wildenhues <[EMAIL PROTECTED]> writes: >> >> > FYI, a few of the gnulib tests currently fail: >> > On x86_64-unknown-linux-gnu (omitting passed tests): > >> > FAIL:

Re: test failures: crc, md4, gc-md4

2006-05-11 Thread Ralf Wildenhues
Hi Simon, * Simon Josefsson wrote on Wed, May 10, 2006 at 03:39:50PM CEST: > Ralf Wildenhues <[EMAIL PROTECTED]> writes: > > > FYI, a few of the gnulib tests currently fail: > > On x86_64-unknown-linux-gnu (omitting passed tests): > > FAIL: test-gc-md4 > > FAIL: test-md4 > > Someone reported t

Re: [bug-gnulib] xvasprintf

2006-05-11 Thread Bruno Haible
Simon Josefsson wrote: > m4/xvasprintf.m4 contains: > > AC_DEFUN([gl_XASPRINTF], > ^ > > Shouldn't a V be inserted there? Sure, yes. I committed your fix now. Bruno

Re: [bug-gnulib] Re: extend the scope of xasprintf

2006-05-11 Thread Bruno Haible
Paul Eggert wrote: > I guess it partly depends on whether one prefers code to be easy to > read, or easy to write. I usually prefer the former. I also prefer code to be easy to read. But while reading code, casts don't attract my attention particularly... Bruno

xvasprintf

2006-05-11 Thread Simon Josefsson
modules/xvasprintf contains: gl_XVASPRINTF m4/xvasprintf.m4 contains: AC_DEFUN([gl_XASPRINTF], ^ Shouldn't a V be inserted there? /Simon

Re: test failures: crc, md4, gc-md4

2006-05-11 Thread Simon Josefsson
Simon Josefsson <[EMAIL PROTECTED]> writes: >> -#define rol(x,n) ( ((x) << (n)) | ((x) >> (32-(n))) ) >> +#define rol(x, n) (((x) << (n)) | ((uint32_t) (x) >> (32 - (n > ... >> -#define rol(x, n) (((x) << (n)) | ((x) >> (32 - (n >> +#define rol(x, n) (((x) << (n)) | ((uint32_t) (x) >> (32