Re: `illegal' vs `invalid'

2006-03-10 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 2/25/2006 12:58 AM: >> In the files `getopt.c', `glob.c', and `regexprops-generic.texi' I >> suggest to replace the word `illegal' with `invalid'. > > Not for getopt.c, since POSIX requires the word "illegal" there; > if yo

Re: proposed gnulib-related additions to Autoconf

2006-03-10 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 3/1/2006 11:28 AM: > "Gary V. Vaughan" <[EMAIL PROTECTED]> writes: > >> i) Let's just improve AC_CHECK_HEADERS (et al) to always make configure >> smaller and faster by despatching to (undocumented internal) >>

module for PRI*MAX macros?

2006-03-10 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I recently reported a findutils bug (https://savannah.gnu.org/bugs/?func=detailitem&item_id=15472) where an error message on cygwin was truncating ino_t (64 bits) because it was using %ld (32 bits). But James correctly reminded me that C89 does not gu

Re: NetBSD 2.0+, statfs.h and mountlist.c

2006-03-10 Thread Paul Eggert
"Benigno B. Junior" <[EMAIL PROTECTED]> writes: > Is there a way to solve this problem with minimal changes, or any > planning in solving this? findutils and coreutils seems to suffer > this problem actually (in fact, all of those which use mountlist.c). I suspect that mountlist and fsusage shoul

make getopt.c build in visual studio

2006-03-10 Thread Simon Josefsson
With this, getopt actually do seem to compile and work in Visual Studio. Tested with the CLI in libtasn1, part of GnuTLS, with long options. I'll install this shortly unless someone protests. 2006-02-28 Simon Josefsson <[EMAIL PROTECTED]> * getopt.c: Protect #include of unistd.h, for

Re: gc.m4 and hard failure

2006-03-10 Thread Simon Josefsson
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > It would be great if the gc.m4 module could be taught not to fail when > no random devices exist (as seen on hppa2.0-hp-hpux10.20). Passing > > --disable-random-device --disable-pseudo-random-device \ > --disable-nonce-device > > did not help. li

support for AM_CPPFLAGS

2006-03-10 Thread Claudio Fontana
Hello, while trying to improve current support in gnulib for internal gettext, I produced this patch, which I use successfully in the packages I maintain to support per-package additions to AM_CPPFLAGS. The patch is a unified p1 diff. I suggest this for inclusion in the gnulib CVS. CLaudio dif

Re: make getopt.c build in visual studio

2006-03-10 Thread Simon Josefsson
Paul Eggert <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> writes: > >> +#ifdef HAVE_UNISTD_H >> #include >> +#endif > > Thanks and please install, except please use '# include' instead of > '#include', for consistent indentation. Yes, diff was using -w so it wasn't visible i

Re: play nice with AC_CACHE_CHECK

2006-03-10 Thread Simon Josefsson
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Hi Simon, > > * Simon Josefsson wrote on Tue, Feb 28, 2006 at 03:52:55PM CET: >> Ralf Wildenhues <[EMAIL PROTECTED]> writes: >> > * Eric Blake wrote on Thu, Feb 23, 2006 at 08:42:18PM CET: >> >> > >> >> > 2) Similar with getaddrinfo.m4, except there i

Re: indent target for maint.mk

2006-03-10 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > Installed. > > 2006-03-03 Simon Josefsson <[EMAIL PROTECTED]> > > * build-aux/maint.mk: Add indent target. > > --- maint.mk 15 Feb 2006 11:40:27 +0100 1.2 > +++ maint.mk 03 Mar 2006 14:29:53 +0100 > @@ -50,3 +50,8 @@ > .PHONY: $(syntax-c

Re: more syntax checks

2006-03-10 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: ... Hi Simon, These are all already done in Makefile.maint :-) > There should be some mechanism to exclude certain files on a per-rule > basis. I'm not yet sure how to do this. Ideas appreciated. That's why coreutils' Makefile.maint uses .x-sc* files

more syntax checks

2006-03-10 Thread Simon Josefsson
Installed. There should be some mechanism to exclude certain files on a per-rule basis. I'm not yet sure how to do this. Ideas appreciated. It should also be possible to add local syntax checks rules in maint-cfg.mk, and have them used automatically. It should also be possible to disable certa

Re: poll.h replacement

2006-03-10 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > * poll.m4 (gl_FUNC_POLL): If we deem poll(2) unacceptable, use > our replacement poll.h in any case, to avoid a differing > declaration from a system header. Seen on AIX. Thanks, I installed that. _

refresh-po rule

2006-03-10 Thread Simon Josefsson
Installed. This may be contentious, but keep in mind that it is not invoked automatically. Improvements most welcome. It Works For Me. 2006-03-03 Simon Josefsson <[EMAIL PROTECTED]> * build-aux/maint.mk: Add refresh-po rule, based on ideas from libidn and bison. --- maint.mk

Re: proposed gnulib-related additions to Autoconf

2006-03-10 Thread Gary V. Vaughan
Hi Paul, Nice work! Yes, I agree that reparenting these macros into Autoconf is an excellent idea. As you are soliciting feedback... Paul Eggert wrote: > +** AC_CHECK_DECLS_ONCE, AC_CHECK_FUNCS_ONCE, AC_CHECK_HEADERS_ONCE > + New "once-only" variants of commonly-used macros, to make 'configure

Re: play nice with AC_CACHE_CHECK

2006-03-10 Thread Ralf Wildenhues
Hi Simon, * Simon Josefsson wrote on Tue, Feb 28, 2006 at 03:52:55PM CET: > Ralf Wildenhues <[EMAIL PROTECTED]> writes: > > * Eric Blake wrote on Thu, Feb 23, 2006 at 08:42:18PM CET: > >> > > >> > 2) Similar with getaddrinfo.m4, except there is no need to store > >> > additional information here.

rm -r can be tricked into reporting non-existent cycle

2006-03-10 Thread Jim Meyering
I wrote: > 2006-03-10 Jim Meyering <[EMAIL PROTECTED]> > > * src/remove.c (AD_pop_and_chdir): Fix a bug whereby a user with > write access to a directory being removed could cause the removal > of that directory to fail with an erroneous diagnostic about a > directory cycl

poll.h replacement

2006-03-10 Thread Ralf Wildenhues
On powerpc-ibm-aix5.3.0.0, poll is not deemed acceptable: the test in m4/poll.m4 fails because polling on /dev/null does not work. It does work to poll on regular files, though. Polling on /dev/tty does not work either. This documentation may be helpful: http://www16.boulder.ibm.com/doc_link/en_

Re: `illegal' vs `invalid'

2006-03-10 Thread Paul Eggert
[EMAIL PROTECTED] (Karl Berry) writes: > Not for getopt.c, since POSIX requires the word "illegal" there; > > Well, it could be made POSIXLY_CORRECT, That's already the case. "illegal" is used only if POSIXLY_CORRECT. ___ bug-gnulib mailing list

Re: proposed gnulib-related additions to Autoconf

2006-03-10 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > I wonder if adding 'at configure time' at the end of that sentence would help. Will do. > Should we also provide a collector macro that ensures that all C99 types > and bounds are available, rather than having the user list so many macros > in their confi

Re: removing asctime_r, ctime_r from the time_r module

2006-03-10 Thread Ben Pfaff
Paul Eggert <[EMAIL PROTECTED]> writes: > I recently redisovered the fact that actime_r and ctime_r, like > asctime and ctime, are unsafe functions in the same sense that gets is > unsafe: they can overrun their output buffers and there's no simple > way for the user to detect in advance whether t

removing asctime_r, ctime_r from the time_r module

2006-03-10 Thread Paul Eggert
I recently redisovered the fact that actime_r and ctime_r, like asctime and ctime, are unsafe functions in the same sense that gets is unsafe: they can overrun their output buffers and there's no simple way for the user to detect in advance whether this will happen. So GNU apps shouldn't use these

Re: module for PRI*MAX macros?

2006-03-10 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > Is it time to make a gnulib module that exposes what is currently > done in coreutils' src/system.h to provide PRIuMAX and friends on > systems that lack them, so that it becomes possible to portably > print an ino_t value Ideally there'd be an inttypes mo

Re: gc.m4 and hard failure

2006-03-10 Thread Paul Eggert
Simon Josefsson <[EMAIL PROTECTED]> writes: > Now that this is settled, I'm beginning to think that the random > functions should be decoupled from GC fully. I.e., there should be a > standalone module 'random', and then gc-random could use it. This is > more similar to other gc modules. IIRC,

Re: make getopt.c build in visual studio

2006-03-10 Thread Eric Blake
> With this, getopt actually do seem to compile and work in Visual > Studio. Tested with the CLI in libtasn1, part of GnuTLS, with long > options. > > I'll install this shortly unless someone protests. I'm not sure about this. Lately, the move has been to assume that exists, and this is a step

Re: gc.m4 and hard failure

2006-03-10 Thread Simon Josefsson
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > * Simon Josefsson wrote on Wed, Mar 08, 2006 at 02:41:29PM CET: >> >> Seems good. I installed this. Review appreciated (untested). > > All good except for: > >> +if test "$NAME_OF_NONCE_RANDOM_DEVICE" != "no"; then >> + AC_CHECK_FILE($NAME_O

Re: more unistd improvements

2006-03-10 Thread Simon Josefsson
Paul Eggert <[EMAIL PROTECTED]> writes: > I installed these I-hope-obvious improvements to the unistd module. Thanks! > (unistd.h): Create using 'echo' rather than 'cp', so that we don't > need unistd_.h. That seem fine for now, although having an empty unistd.h may be useful for pl