Re: [Bug-tar] Error "Cannot allocate memory" incorrectly reported in some cases.

2005-10-28 Thread Dmitry V. Levin
On Fri, Oct 28, 2005 at 04:07:53PM -0700, Paul Eggert wrote: > I installed this patch instead, both in gnulib and coreutils. [...] > @@ -70,7 +70,6 @@ char * > savedir (const char *dir) > { >DIR *dirp; > - struct dirent *dp; >char *name_space; >size_t allocated = NAME_SIZE_DEFAULT; >

Re: [Bug-tar] Error "Cannot allocate memory" incorrectly reported in some cases.

2005-10-28 Thread Paul Eggert
"Sergey Poznyakoff" <[EMAIL PROTECTED]> writes: > --- lib/savedir.c 19 Sep 2005 17:28:15 - 1.26 > +++ lib/savedir.c 28 Oct 2005 12:39:06 - > @@ -104,6 +104,7 @@ savedir (const char *dir) > while (allocated <= used + entry_size); > > name_space = xreal

Re: gc self test fixes

2005-10-28 Thread Simon Josefsson
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > You might want to > cd gnulib/tests > for f in *.c; do > sed 's/missmatch/mismatch/g' <$f >$f.new && mv -f $f.new $f > done Done, thanks! ___ bug-gnulib mailing list bug-gnulib@gnu.org http://lis

Re: gc self test fixes

2005-10-28 Thread Ralf Wildenhues
Hi Simon, * Simon Josefsson wrote on Fri, Oct 28, 2005 at 02:17:29PM CEST: > *snip* > Index: tests/test-gc-md5.c > === > RCS file: /cvsroot/gnulib/gnulib/tests/test-gc-md5.c,v > retrieving revision 1.2 > diff -u -p -r1.2 test-gc-md5.

Re: md2, md2-tests, gc-md2, gc-md2 and some gc fixes

2005-10-28 Thread Simon Josefsson
Simon Josefsson <[EMAIL PROTECTED]> writes: > I have installed the patch below, we needed MD2 in GnuTLS. I forgot: * The MD2 crypto code is based on the public domain implementation available through LibTomCrypt. There is a comment about this in the code. This assume public domain licenses

Re: [Bug-tar] Error "Cannot allocate memory" incorrectly reported in some cases.

2005-10-28 Thread Sergey Poznyakoff
Frédéric Jolliton <[EMAIL PROTECTED]> wrote: > This is inside realloc(). When mremap fail, it set errno to ENOMEM, > but then mmap2 is performed instead and previous memory is unmap-ed. > > While realloc succeed in this case, errno is set to ENOMEM ! > > This happen in savedir, when it call xrea

gc self test fixes

2005-10-28 Thread Simon Josefsson
Installed. 2005-10-28 Simon Josefsson <[EMAIL PROTECTED]> * tests/test-gc-md4.c, tests/test-gc-md5.c, tests/test-gc-sha1.c: Test more. Index: tests/test-gc-md4.c === RCS file: /cvsroot/gnulib/gnulib/tests/test-gc-m

Re: md5 cleanup

2005-10-28 Thread Simon Josefsson
Simon Josefsson <[EMAIL PROTECTED]> writes: > Ok to install patch below? There weren't any objections, so I take that as a "yes". Installed: > 2005-10-23 Simon Josefsson <[EMAIL PROTECTED]> > > * md5.h, md5.c: Simplify buffer handling visavi alignment, same as > recent md4 change.

Re: md2, md2-tests, gc-md2, gc-md2 and some gc fixes

2005-10-28 Thread Simon Josefsson
Hi Ralf! Thanks for comments... answers inline. Ralf Wildenhues <[EMAIL PROTECTED]> writes: >> +# include >> +# include > > AFAICS you only need stddef.h and stdio.h here. Yup. I also removed the stdint module dependency. >> +Gc_rc >> +gc_hash_open (Gc_hash hash, Gc_hash_mode mode, gc_hash

Re: md2, md2-tests, gc-md2, gc-md2 and some gc fixes

2005-10-28 Thread Ralf Wildenhues
Hi Simon, * Simon Josefsson wrote on Fri, Oct 28, 2005 at 11:35:05AM CEST: > I have installed the patch below, we needed MD2 in GnuTLS. Code comments, from a glance: > Index: lib/md2.h > === > RCS file: lib/md2.h > diff -N lib/md2.h

md2, md2-tests, gc-md2, gc-md2 and some gc fixes

2005-10-28 Thread Simon Josefsson
I have installed the patch below, we needed MD2 in GnuTLS. * Libgcrypt doesn't have MD2, so the gc-md2 module unconditionally depends on the md2 module. * I made the md2.? API similar to md5.? etc, but the distinction between md2_process_bytes and md2_process_blocks is blurred. We should r