gettime's gettimeofday call may fail

2005-10-22 Thread Jim Meyering
FYI, I've just realized that gnulib's gettime function (currently returning void) can fail, albeit under unusual circumstances. On at least Solaris 9, gettimeofday is documented to fail like this: Additionally, the gettimeofday() function will fail for 32-bit interfaces if: EOVER

arcfour fix

2005-10-22 Thread Simon Josefsson
I have installed this. GNU Shishi in CVS has now started to use GC too, and the self tests suggested this... Index: ChangeLog === RCS file: /cvsroot/gnulib/gnulib/ChangeLog,v retrieving revision 1.436 diff -u -p -r1.436 ChangeLog ---

Re: generic crypto - remarks

2005-10-22 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> - md4_process_block (memcpy (ctx->buffer, buffer, 64), 64, ctx); >> + md4_process_block (memcpy (ctx->buffer, buffer, 16), 64, ctx); > > The patch in md4.c:243 doesn't look right. But otherwise it looks more >

Re: [bug-gnulib] Re: generic crypto - remarks

2005-10-22 Thread Bruno Haible
Simon Josefsson wrote: > - md4_process_block (memcpy (ctx->buffer, buffer, 64), 64, ctx); > + md4_process_block (memcpy (ctx->buffer, buffer, 16), 64, ctx); The patch in md4.c:243 doesn't look right. But otherwise it looks more robust than previously. Bruno

crc fix

2005-10-22 Thread Simon Josefsson
I have installed this. 2005-10-22 Simon Josefsson <[EMAIL PROTECTED]> * crc.h: Include stddef.h, for size_t. --- crc.h 21 Oct 2005 14:31:48 +0200 1.2 +++ crc.h 22 Oct 2005 18:14:49 +0200 @@ -20,6 +20,7 @@ #ifndef CRC_H # define CRC_H 1 +#include #include

Re: generic crypto - remarks

2005-10-22 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: >> > 17) gc.m4 >> > >> > I don't understand what happens when someone specifies >> > --disable-random-device. Then NAME_OF_RANDOM_DEVICE will be set to "no", >> > the AC_CHECK_FILE will check for a file named "no" and bail out. >> >> Hm. How can this be so

Re: generic crypto - remarks

2005-10-22 Thread Simon Josefsson
Paul Eggert <[EMAIL PROTECTED]> writes: > Jim Meyering <[EMAIL PROTECTED]> writes: > >> verify (offsetof (struct S, member_m) % 4 == 0); >> >> Hmm... that assumes 8-bit bytes. > > And it also assumes no holes in integer representations. > This is more portable: > > verify (offsetof (struct S,