Re: [bug-gnulib] problems in stdbool.m4

2005-10-12 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > To provide for a smooth transition from AM_STDBOOL_H to gl_STDBOOL_H, > I propose a three-step procedure: > 1) now, the appended patch, > 2) in a year, change modules/stdbool to require gl_STDBOOL_H, > 3) in two years, drop AM_STDBOOL_H. Sounds goo

Re: gc-pbkdf2-sha1

2005-10-12 Thread Paul Eggert
Simon Josefsson <[EMAIL PROTECTED]> writes: > Bruno Haible <[EMAIL PROTECTED]> writes: > >> Simon Josefsson wrote: >> >>> + l = dkLen / hLen; >>> + if (dkLen % hLen) >>> +l++; >> >> An equivalent but faster code is: >> >> l = ((dkLen - 1) / hLen) + 1; > > Perhaps for clarity we could ch

human dependency

2005-10-12 Thread Oskar Liljeblad
I think the human module depends on xstrtoumax, not xstrtol. Regards, Oskar 2005-10-12 Oskar Liljeblad <[EMAIL PROTECTED]> * modules/human: Depend on xstrtoumax, not xstrtol. diff -u modules/human.v0 modules/human --- modules/human.v02005-10-12 21:02:11.0 +0200 +++ module

Re: restrict.m4: do not punish autoconf 2.59 users

2005-10-12 Thread Bruno Haible
Stepan Kasal wrote: > perhaps > > m4_ifndef([AC_C_RESTRICT], > AC_DEFUN([gl_C_RESTRICT], > [...] > ]) > ]) > > could be better. And what would we put into modules/restrict then? We are trying to keep the names of gnulib's autoconf macros stable, even though the contents constantly changes. The re

Re: [bug-gnulib] problems in stdbool.m4

2005-10-12 Thread Bruno Haible
Stepan Kasal wrote: > I noticed two problems with stdbool.m4: > > Even with Autoconf-2.59, this file is included in aclocal.m4, > and thus the gnulib definition overrides the Autoconf one. This is what we want. Look at the comment: -

Re: restrict.m4: do not punish autoconf 2.59 users

2005-10-12 Thread Stepan Kasal
Hello, > AC_DEFUN([gl_C_RESTRICT], > -[AC_CACHE_CHECK([for C/C++ restrict keyword], gl_cv_c_restrict, > +[m4_ifdef([AC_C_RESTRICT], [AC_C_RESTRICT], > + [AC_CACHE_CHECK([for C/C++ restrict keyword], gl_cv_c_restrict, perhaps m4_ifndef([AC_C_RESTRICT], AC_DEFUN([gl_C_RESTRICT], [...] ]) ])

problems in stdbool.m4

2005-10-12 Thread Stepan Kasal
Hello, I noticed two problems with stdbool.m4: Even with Autoconf-2.59, this file is included in aclocal.m4, and thus the gnulib definition overrides the Autoconf one. Perhaps the following would fix it: m4_ifndef([AC_HEADER_STDBOOL], AC_DEFUN([AC_HEADER_STDBOOL], [... ]) ]) Second, AM_STDBOOL

Re: gc-pbkdf2-sha1

2005-10-12 Thread Bruno Haible
Simon Josefsson wrote: > Perhaps for clarity we could change it into: > > #define CEIL_DIV(a,b) (((a) - 1) / (b)) + 1 > l = CEIL_DIV (dkLen, hLen); > > What do you think? People could be tempted to borrow this formula and apply to situations where it doesn't fit. Normally one uses #define CE

Re: gc-pbkdf2-sha1

2005-10-12 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: > >> + l = dkLen / hLen; >> + if (dkLen % hLen) >> +l++; > > An equivalent but faster code is: > > l = ((dkLen - 1) / hLen) + 1; Perhaps for clarity we could change it into: #define CEIL_DIV(a,b) (((a) - 1) / (b)) + 1

Re: [bug-gnulib] gc-pbkdf2-sha1

2005-10-12 Thread Bruno Haible
Simon Josefsson wrote: > + l = dkLen / hLen; > + if (dkLen % hLen) > +l++; An equivalent but faster code is: l = ((dkLen - 1) / hLen) + 1; Bruno ___ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnu

Re: gc-pbkdf2-sha1

2005-10-12 Thread Simon Josefsson
Hi Ralf! Thanks for your comments.. Ralf Wildenhues <[EMAIL PROTECTED]> writes: > By the way, has anyone suggested to use one of these documentation- > from-source-comments generators for gnulib yet? Has it been rejected? I don't think anyone has proposed it. I'm somewhat biased towards GTK-D

Re: gc-pbkdf2-sha1

2005-10-12 Thread Ralf Wildenhues
Hi Simon, * Simon Josefsson wrote on Wed, Oct 12, 2005 at 03:13:28PM CEST: > I have installed this. Comments most welcome, as always! Here you go. > *snip header with nice documentation* By the way, has anyone suggested to use one of these documentation- from-source-comments generators for gnu

gc-pbkdf2-sha1

2005-10-12 Thread Simon Josefsson
I have installed this. Comments most welcome, as always! Index: ChangeLog === RCS file: /cvsroot/gnulib/gnulib/ChangeLog,v retrieving revision 1.415 diff -u -p -r1.415 ChangeLog --- ChangeLog 12 Oct 2005 01:42:55 - 1.415 +

Re: gc_hash_buffer

2005-10-12 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> > If all valid values for HASH are >> > part of this enum type, you could write the argument as 'Gc_hash hash' >> > instead of 'int hash'. This would be clearer. >> >> Yup, I have made this change. Thanks! > > And what about the

Re: gc_hash_buffer

2005-10-12 Thread Bruno Haible
Simon Josefsson wrote: > > If all valid values for HASH are > > part of this enum type, you could write the argument as 'Gc_hash hash' > > instead of 'int hash'. This would be clearer. > > Yup, I have made this change. Thanks! And what about the return type? Are all possible return values listed

gc-hmac-sha1

2005-10-12 Thread Simon Josefsson
I have installed this. Index: m4/ChangeLog === RCS file: /cvsroot/gnulib/gnulib/m4/ChangeLog,v retrieving revision 1.738 diff -u -p -r1.738 ChangeLog --- m4/ChangeLog12 Oct 2005 01:42:54 - 1.738 +++ m4/ChangeLog