Derek Price <[EMAIL PROTECTED]> writes:
> I think the size_max module is only important if you want to use
> SIZE_MAX as part of a preprocessor conditional
Yes, that's my recollection as well.
___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://list
Simon Josefsson <[EMAIL PROTECTED]> writes:
> Has anyone used md5_buffer from the md5 module on a platform with char
> that is larger than 1 byte?
Do you mean a host where UCHAR_MAX > 255? I doubt whether anyone has
done that. POSIX requires that UCHAR_MAX == 255. A small fraction of
GNU code
Simon Josefsson <[EMAIL PROTECTED]> writes:
> I am not sure about the prototype. Should it use 'char*'? 'int*'?
If its name is mem* then it should use void *, for consistency.
The current implementation uses 'restrict', so memxor.m4 should
AC_REQUIRE([gl_C_RESTRICT]) and the memxor module shou
Simon Josefsson <[EMAIL PROTECTED]> writes:
> The tests for these headers in getaddrinfo.m4 should probably be
> removed eventually.
No time like the present, right? I installed this:
2005-10-05 Paul Eggert <[EMAIL PROTECTED]>
* getaddrinfo.m4 (gl_PREREQ_GETADDRINFO): Don't check for
Simon Josefsson wrote:
>Derek Price <[EMAIL PROTECTED]> writes:
>
>
>>may not be defined. I've installed the attached patch, ripped verbatim
>>from serveral other modules.
>>
>>
>
>Shouldn't we use the size_max module instead?
>
>
I'm not sure. Some 18 modules currently don't, defining
Bruno Haible <[EMAIL PROTECTED]> writes:
> Simon Josefsson wrote:
>> I just noticed that the 'stdint' module was GPL. Would it be possible
>> to re-license it?
>
> Yes, done (assuming Oskar's agreement).
Thanks!
___
bug-gnulib mailing list
bug-gnulib
Derek Price <[EMAIL PROTECTED]> writes:
> Paul's recent change to getdelim.c breaks the build on at least NetBSD
> 1.6.1:
>
> 2005-10-03 Paul Eggert <[EMAIL PROTECTED]>
>
> * getdelim.c: Include getdelim.h first. Include .
> (SSIZE_MAX): New macro, if not already defined.
>
Paul's recent change to getdelim.c breaks the build on at least NetBSD
1.6.1:
2005-10-03 Paul Eggert <[EMAIL PROTECTED]>
* getdelim.c: Include getdelim.h first. Include .
(SSIZE_MAX): New macro, if not already defined.
(getdelim): Fix buffer overrun on 64-bit hosts with
Simon Josefsson wrote:
> I just noticed that the 'stdint' module was GPL. Would it be possible
> to re-license it?
Yes, done (assuming Oskar's agreement).
Bruno
___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug
Bruno Haible <[EMAIL PROTECTED]> writes:
> For 'uint8_t', you can use the gnulib module 'stdint'. Or use 'unsigned char'
> if you don't want to.
I just noticed that the 'stdint' module was GPL. Would it be possible
to re-license it? Otherwise I'll just 'unsigned char*' or 'void*' for
hmac-md5.
Bruno Haible <[EMAIL PROTECTED]> writes:
> Simon Josefsson wrote:
>> This is the HMAC-MD5 module, that depends on the MD5 module.
>> What do you think? Ok to install?
>>
>> The reason I'm using hmac.h instead of hmac-md5.h is that I think
>> hmac.h should contain the prototype for hmac_sha1 too,
Bruno Haible <[EMAIL PROTECTED]> writes:
> Simon Josefsson wrote:
>> Ok to install?
>
> Yes. I'd try to help the compilers with not-so-good loop optimizers by
> changing
>
> for (i = 0; i < n; i++)
>d[i] ^= s[i];
>
> into
>
> for (; n > 0; n--)
>*d++ ^= *s++;
>
> but that
Ralf Wildenhues <[EMAIL PROTECTED]> writes:
> * Simon Josefsson wrote on Wed, Oct 05, 2005 at 02:10:14PM CEST:
>>
>> +/* Written by Simon Josefsson. The interface was inspired by memxor
>> + in Niels Möller's Nettle. */
> *snip*
>
>> +void *memxor (void *dest, const void *src, size_t n);
> *sn
I have installed the patch below. config.rpath is only called from
the havelib macros, not from iconv.m4, and iconv depend on havelib, so
this shouldn't be a problem.
2005-10-05 Simon Josefsson <[EMAIL PROTECTED]>
* modules/iconv (Files): Move config.rpath to havelib, it is used
Simon Josefsson wrote:
> Ok to install?
Yes. I'd try to help the compilers with not-so-good loop optimizers by
changing
for (i = 0; i < n; i++)
d[i] ^= s[i];
into
for (; n > 0; n--)
*d++ ^= *s++;
but that's a detail. Also the comment in memxor.h should say what
memxor d
Simon Josefsson wrote:
> This is the HMAC-MD5 module, that depends on the MD5 module.
> What do you think? Ok to install?
>
> The reason I'm using hmac.h instead of hmac-md5.h is that I think
> hmac.h should contain the prototype for hmac_sha1 too, eventually.
> That would be a separate module wit
* Simon Josefsson wrote on Wed, Oct 05, 2005 at 02:10:14PM CEST:
>
> +/* Written by Simon Josefsson. The interface was inspired by memxor
> + in Niels Möller's Nettle. */
*snip*
> +void *memxor (void *dest, const void *src, size_t n);
*snip*
Random comment the casual reader: Do you need to al
Hi. This is the HMAC-MD5 module, that depends on the MD5 module.
What do you think? Ok to install?
The reason I'm using hmac.h instead of hmac-md5.h is that I think
hmac.h should contain the prototype for hmac_sha1 too, eventually.
That would be a separate module with a hmac-sha1.c implementatio
Hi. This is a helper module needed by the hmac-md5 crypto module that
I'll post after this. What do you think? Ok to install?
I am not sure about the prototype. Should it use 'char*'? 'int*'?
The implementation XOR the data buffers char by char, but there is no
inherent requirement that it is
Jim Meyering <[EMAIL PROTECTED]> writes:
>>> How about HAVE_SYS_SOCKET_H?
>>> At least poll.c uses without the conditional.
>>>
>>> It's best to avoid the conditionals, when possible.
>>
>> Mingw32 doesn't have sys/socket.h, but gnulib doesn't support it
>> anyway, so I removed the check. The pr
>> I don't see any other uses of HAVE_SYS_TYPES_H in gnulib.
>
> I removed the check.
Thanks!
>> How about HAVE_SYS_SOCKET_H?
>> At least poll.c uses without the conditional.
>>
>> It's best to avoid the conditionals, when possible.
>
> Mingw32 doesn't have sys/socket.h, but gnulib doesn't suppo
Jim Meyering <[EMAIL PROTECTED]> writes:
> Hi Simon,
>
> I noticed that getaddrinfo.h guards the inclusion of
> with an #ifdef HAVE_SYS_TYPES_H.
> Do you know of a system that lacks ?
Hi Jim! No, I don't.
> I don't see any other uses of HAVE_SYS_TYPES_H in gnulib.
I removed the check.
> How
22 matches
Mail list logo
