[bug-gnulib] new fts and fts-lgpl modules

2005-05-20 Thread Paul Eggert
I installed this. The cute thing here is that there are two variants of the module. fts is GPL'ed, and fts-lgpl is LGPL'ed. I haven't tested the latter, though. 2005-05-20 Paul Eggert <[EMAIL PROTECTED]> * MODULES.html.sh (File system functions): Add fts, fts-lgpl. * lib/fts.

Re: [bug-gnulib] New GNULIB glob module?

2005-05-20 Thread Derek Price
Paul Eggert wrote: >>There is one change I know I made that might have an effect. I added >>the "!defined _LIBC" to the following block because I was unsure what >>__REDIRECT_NTH was supposed to be doing >> >> > >I think that one's OK. > > Larry Jones on the CVS team just made a comment th

Re: [bug-gnulib] same, utimecmp should depend on minmax

2005-05-20 Thread Paul Eggert
Derek Price <[EMAIL PROTECTED]> writes: > Isn't there some sense to assuming that if or > define MIN & MAX on a system, then including said header is the > "correct" way of getting the definition on one of these systems? Perhaps, if the macros there are correct. Sometimes a header will define

Re: [bug-gnulib] Bugs in chown module

2005-05-20 Thread Paul Eggert
[EMAIL PROTECTED] (Eric Blake) writes: > * lib/chown.c (rpl_chown): Return -1 on failure. > * m4/chown.m4 (gl_FUNC_CHOWN): Correct sense of test for honoring IDs of -1. Thanks; installed. ___ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu

[bug-gnulib] Re: [PING] Bugs in chown module

2005-05-20 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Any review on this patch? I don't have commit privileges, so someone else needs to commit it. According to Eric Blake on 5/17/2005 2:36 PM: > lib/ChangeLog: > 2005-05-17 Eric Blake <[EMAIL PROTECTED]> (tiny change) > > * chown.c (rpl_chown)

[bug-gnulib] Re: new unlinkdir module for gnulib

2005-05-20 Thread Bruno Haible
Paul Eggert wrote: > It has other uses, too. For example, tar uses it to efficiently > remove non-directories while leaving directories alone. OK, I withdraw the criticism. Nice code-sharing. Bruno ___ bug-gnulib mailing list bug-gnulib@gnu.org http

[bug-gnulib] Re: new unlinkdir module for gnulib

2005-05-20 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > Reading the comments in > http://savannah.gnu.org/cgi-bin/viewcvs/coreutils/coreutils/src/remove.c?rev=1.126&content-type=text/vnd.viewcvs-markup > it seems that the only use of this function is to speed up the removal of > a non-empty directory. It has

[bug-gnulib] Re: new unlinkdir module for gnulib

2005-05-20 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: ... > Why not add to gnulib a module with a function rmdir_recursive() instead? > This function would remove a directory, including its contents. coreutils' remove.c might fit the bill, in that it's robust. But currently it's not strictly library-clean in th

[bug-gnulib] Re: new unlinkdir module for gnulib

2005-05-20 Thread Bruno Haible
Paul Eggert wrote: > I installed this, imported from coreutils. It addresses the issue > that `unlink ("directory")' works on some hosts (e.g., Solaris, > OpenBSD) but not others (e.g., GNU/Linux, FreeBSD). Solaris 10 has a > new wrinkle: you can add/remove the privilege of unlinking a > director

[bug-gnulib] Re: [PATCH]: fix warning in the hash module

2005-05-20 Thread Bruno Haible
Jim Meyering wrote: > What if we were to convert to the const-less signatures you prefer, > and then an application wants to call hash_insert with a variable of > type `char const *'? -- of course, the key-freer function is NULL > in that case. Then, it's not just the relatively obscure -Wcast-qua