bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text

2024-09-01 Thread João Távora
Dmitry Gutov writes: > On 31/08/2024 15:03, João Távora wrote: > >> Eglot aims primarily at that, since it's what's in Emacs proper. But >> Eglot also aims at supporting Company in particular as fully >> as possible. >> >> Anyway, I don't have time to investigate this. The :exit-function in >> e

bug#72453: 29.4; "use-package" macro does not load all expected related files

2024-09-01 Thread Stefan Kangas
Mattias Engdegård writes: > It seems that 644d2a83 and 8f4ad4d7 cause failures in use-package-tests on > master (log attached); the tests pass after reverting those commits. Thanks, this should now be fixed.

bug#72949: [PATCH] Wrong unread count in the Group buffer in nnimap

2024-09-01 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
I haven't tested this patch (don't really know how to), but this could very well be the cause of this long-standing bug: From 6676798c2a60094ddb8a7476bbbf611d9e7d644c Mon Sep 17 00:00:00 2001 From: James Thomas Date: Mon, 2 Sep 2024 11:23:11 +0530 Subject: [PATCH] Correct empty mailbox active cou

bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call

2024-09-01 Thread Aaron Jensen
Hi Dmitry, Here's a corrected patch for that particular example. Thank you for finding that. I think I missed it because as long as you type the code in, it indents fine. I still have a lot to understand about SMIE, so if anything looks off in my patch, please let me know. I didn't change the def

bug#72929: [Norbert Koch] Error building emacs after 73277a4097b

2024-09-01 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
"Stefan Kangas" writes: > Forwarding the below to the bug tracker in case anyone sees a quick fix. > I'll be AFK in the next couple of hours or so. I can reproduce this with --with-x-toolkit=no. An explicit #include seems to be all that's required, so I've boldly pushed it. Pip

bug#72915: Docstrings of add-hook and remove-hook improvement?

2024-09-01 Thread Stefan Kangas
Eli Zaretskii writes: >> From: Tomas Nordin >> Date: Sat, 31 Aug 2024 12:36:22 + >> >> The following on top of emacs-30. >> >> diff --git a/lisp/subr.el b/lisp/subr.el >> index 28ba30f584e..e60c4119c60 100644 >> --- a/lisp/subr.el >> +++ b/lisp/subr.el >> @@ -2090,6 +2090,10 @@ add-hook >>

bug#72919: Fwd: bug#72919: 29.1; chart-space-usage in chart.el does not work correctly on windows

2024-09-01 Thread Harm Van der Vegt
-- Forwarded message - Van: Harm Van der Vegt Date: zo 1 sep 2024 om 20:11 Subject: Re: bug#72919: 29.1; chart-space-usage in chart.el does not work correctly on windows To: Eli Zaretskii >Thanks. However, I think your changes are not entirely correct: they >fail to account for

bug#72787: 31.0.50; Invalid describe-function completion candidates

2024-09-01 Thread Eli Zaretskii
reopen 72787 thanks > From: Eshel Yaron > Cc: Stefan Monnier , michael_heerde...@web.de, > 72787-d...@debbugs.gnu.org, pip...@protonmail.com > Date: Sun, 01 Sep 2024 19:41:47 +0200 > > Thanks, but the issue remains, so shouldn't the bug remain open as well? I reopened it.

bug#72945: 29.4; Org: ox-html: attr_html not supported in source code and fixed-width blocks during HTML export

2024-09-01 Thread Suhail Singh
Since more than a month has gone by, I am creating this issue to ease tracking. This issue was first mentioned in this post: . Details cross-posted below. Unlike example blocks, source code and fixed-width blocks don't support the att

bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text

2024-09-01 Thread Dmitry Gutov
On 01/09/2024 12:43, João Távora wrote: It seems the difference comes from bug#70968 as well (which came up recently). Okay, but that presumed bug has nothing to do with Eglot, AFAICT. One could argue that the current definition of the style (in Eglot) relies on buggy (or suboptimal) behavi

bug#72919: 29.1; chart-space-usage in chart.el does not work correctly on windows

2024-09-01 Thread Harm Van der Vegt
Clear, thanks for the response! Op zo 1 sep 2024 om 20:35 schreef Eli Zaretskii : > [Please use Reply All to reply, so that the bug tracker is CC'ed.] > > > From: Harm Van der Vegt > > Date: Sun, 1 Sep 2024 20:11:39 +0200 > > > > >Thanks. However, I think your changes are not entirely correct:

bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call

2024-09-01 Thread Dmitry Gutov
On 01/09/2024 22:28, Aaron Jensen wrote: Here's a corrected patch for that particular example. Thank you for finding that. I think I missed it because as long as you type the code in, it indents fine. I still have a lot to understand about SMIE, so if anything looks off in my patch, please let

bug#72787: 31.0.50; Invalid describe-function completion candidates

2024-09-01 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
Eli Zaretskii writes: >> Cc: 72...@debbugs.gnu.org, m...@eshelyaron.com, Pip Cet >> >> Date: Sun, 25 Aug 2024 22:37:01 -0400 >> From: Stefan Monnier via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> >> This appears to be caused by commit >> >> 45ae4de0e7ce99c88c

bug#72949: [PATCH] Wrong unread count in the Group buffer in nnimap

2024-09-01 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
James Thomas wrote: > I haven't tested this patch (don't really know how to), but this could > very well be the cause of this long-standing bug: Sorry, that was an earlier attempt. This is the one I'm using now: From a2c19066746d49f5ed1f61d6da670ab0b72c7341 Mon Sep 17 00:00:00 2001 From: James T

bug#71646: 29.3; pixel-scroll-precision-mode overrides paging behaviour even when pixel-scroll-precision-interpolate-page is off

2024-09-01 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
Stefan Kangas writes: > Eli Zaretskii writes: > >> Ping! Should I close this? > > Shouldn't we rather fix the bug described by Mike? I.e. this: > >> Setting `pixel-scroll-precision-interpolate-page’ is supposed to >> turn off the paging animation (which it does) however even when it’s >> off,

bug#72929: [Norbert Koch] Error building emacs after 73277a4097b

2024-09-01 Thread Stefan Kangas
Hi Norbert, Thanks for reporting this. Forwarding the below to the bug tracker in case anyone sees a quick fix. I'll be AFK in the next couple of hours or so. FWIW, I can't reproduce the below on macOS 15 or Ubuntu 22.04 LTS. Did you try `make bootstrap`? Could you include your build details a

bug#72573: 29.4; js-mode/JSX: forward-sexp behavior at end of string in JSX fragments

2024-09-01 Thread Juri Linkov
>> @@ -3929,7 +3929,8 @@ js-ts-mode >> (sexp ,(js--regexp-opt-symbol js--treesit-sexp-nodes)) >> (sentence ,(js--regexp-opt-symbol >> js--treesit-sentence-nodes)) >> (text ,(js--regexp-opt-symbol '("comment" >> -

bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return

2024-09-01 Thread Troy Brown
On Sat, Aug 31, 2024 at 3:55 AM Eli Zaretskii wrote: > > Ping! How can we make progress with this issue? > Just FYI, for the time being I've been using this "return filter" advice on eglot--format-markup which splits all lines irregardless of the EOL marker and rejoins them with a newline. It's

bug#72945: [PATCH 2/2] ox-html: Add support for attr_html in fixed-width blocks

2024-09-01 Thread Suhail Singh
* lisp/ox-html.el (org-html-fixed-width): Handle attr_html in a manner similar to example blocks. TINYCHANGE --- lisp/ox-html.el | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/lisp/ox-html.el b/lisp/ox-html.el index 3e83f02e2..a85b1e6ac 100644 --- a/li

bug#72915: Docstrings of add-hook and remove-hook improvement?

2024-09-01 Thread Stefan Kangas
Stefan Kangas writes: > The wording in the manual is probably all that is needed here: > > This function removes FUNCTION from the hook variable HOOK. BTW. Here's another idea: If HOOK is a list of functions, remove FUNCTION from that list. If HOOK is equal to FUNCTION, set HOOK t

bug#71646: 29.3; pixel-scroll-precision-mode overrides paging behaviour even when pixel-scroll-precision-interpolate-page is off

2024-09-01 Thread Eli Zaretskii
> From: Stefan Kangas > Date: Sun, 1 Sep 2024 02:48:57 -0700 > Cc: m...@bulsara.com, 71...@debbugs.gnu.org > > Eli Zaretskii writes: > > > Ping! Should I close this? > > Shouldn't we rather fix the bug described by Mike? I.e. this: > > > Setting `pixel-scroll-precision-interpolate-page’ is s

bug#69097: [PATCH] Add 'kill-region-or-word' command

2024-09-01 Thread Philip Kaludercic
Eli Zaretskii writes: >> From: Sean Whitton >> Date: Mon, 06 May 2024 17:51:48 +0100 >> >> On Mon 06 May 2024 at 05:46pm +01, Sean Whitton wrote: >> > >> > In bash on Linux [...] >> >> I specifically called out Linux because while GNU readline has a >> unix-word-rubout command, C-w in the Linu

bug#69097: [PATCH] Add 'kill-region-or-word' command

2024-09-01 Thread Sean Whitton
Hello, On Sun 01 Sep 2024 at 08:06pm GMT, Philip Kaludercic wrote: > Ping. I am not sure how to proceed on this patch. IIRC the issue was > that the notion of a word differs in Emacs and in Bash. I am still in > favour of utilising Emacs's definition, as it remains more useful > for some given

bug#72757: No symbols in etc/NEWS

2024-09-01 Thread Juri Linkov
close 72757 30.0.60 thanks >> > M-: (modify-syntax-entry ?' "\"") RET >> > >> > in the NEWS buffer and C-h o seems to work everywhere. I am not sure if >> > we want ' to be "string quote" or punctuation like " already is, or >> > something else. >> >> Thanks, this looks like the right thing

bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call

2024-09-01 Thread Aaron Jensen
On Sun, Sep 1, 2024 at 8:19 PM Dmitry Gutov wrote: > > On 01/09/2024 22:28, Aaron Jensen wrote: > > > Here's a corrected patch for that particular example. Thank you for > > finding that. I think I missed it because as long as you type the code > > in, it indents fine. I still have a lot to unders

bug#72866: [PATCH] Add ediff-copy-all-X-to-Y functions

2024-09-01 Thread Paul Nelson
> > This patch binds functions in Ediff that copy all changes from one > > buffer to another, without having to manually go through each > > difference. Any feedback welcome. > > Can you describe situation(s) where these commands will be useful? I use Ediff to merge documents outside of git, like

bug#72945: [PATCH 1/2] ox-html: Add support for attr_html for source code blocks

2024-09-01 Thread Suhail Singh
* lisp/ox-html.el (org-html-src-block): Add org-src-container class to any class attributes specified via the attr_html keyword. TINYCHANGE --- lisp/ox-html.el | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/lisp/ox-html.el b/lisp/ox-html.el index 446698758..

bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call

2024-09-01 Thread Aaron Jensen
> It seems to me that anything other than 0 spaces would look inconsistent > with the first element (the hash), and its closing brace in particular. Yeah, that's my sense as well, even if it looks awful, but you get what you get. > >> * Support for the new option in ruby-ts-mode (it's good to hav

bug#72210: 31.0.50; Feature request: multi-category support in `icomplete-fido-kill'.

2024-09-01 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
> `icomplete-fido-kill' works very well, but cannot handle the deletion of > files or killing buffers when they are behind a multi-category > ``situation''. Add this would be useful for those of us that combine > `icomplete' with, e.g., `consult-buffer'. Can you provide a recipe? I'm not suffici

bug#72929: [Norbert Koch] Error building emacs after 73277a4097b

2024-09-01 Thread Stefan Kangas
Norbert Koch writes: > Thanks, this does the trick for me as well. Thanks, closing.

bug#71646: 29.3; pixel-scroll-precision-mode overrides paging behaviour even when pixel-scroll-precision-interpolate-page is off

2024-09-01 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Sun, 1 Sep 2024 02:48:57 -0700 >> Cc: m...@bulsara.com, 71...@debbugs.gnu.org >> >> Eli Zaretskii writes: >> >> > Ping! Should I close this? >> >> Shouldn't we rather fix the bug described by Mike? I.e. this: >> >> > Setting `pixel-scro

bug#72919: 29.1; chart-space-usage in chart.el does not work correctly on windows

2024-09-01 Thread Eli Zaretskii
> From: Harm Van der Vegt > Date: Sat, 31 Aug 2024 20:52:41 +0200 > > Load the builtin chart package. When chart-space-usage is run, targeting > any directory, chart fails to find any files and therefore can't create > the chart. The expected behavior is that a bar chart is shown, ranking > the f

bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call

2024-09-01 Thread Dmitry Gutov
On 02/09/2024 03:49, Aaron Jensen wrote: Here's a bonus example which looks off but would be more difficult to fix (and it's not urgent, given the expression is in mixed styles): foo([{ a: 2 }, { b: 3 }, 4 ]) Yes, that's connected to the case I mentione

bug#72915: Docstrings of add-hook and remove-hook improvement?

2024-09-01 Thread Tomas Nordin
Stefan Kangas writes: > Stefan Kangas writes: > >> The wording in the manual is probably all that is needed here: >> >> This function removes FUNCTION from the hook variable HOOK. > > BTW. Here's another idea: > > If HOOK is a list of functions, remove FUNCTION from that list. > > I

bug#72951: Hideshow support for treesitter

2024-09-01 Thread Pranshu Sharma
Hello all Are there any plans to add treesitter support for hideshow, it seems easy enough to do and also very helpful, especially for langs that don't excessively use parens, such as python

bug#72245: [PATCH] Fix integer overflow when reading XPM

2024-09-01 Thread Stefan Kangas
Version: 31.1 Stefan Kangas writes: > Since we don't have an alternative patch, I will install the one I > proposed in the next couple of days. Thanks. Pushed to master as commit 73277a4097b. Closing.

bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call

2024-09-01 Thread Dmitry Gutov
Hi Aaron! On 01/09/2024 03:54, Aaron Jensen wrote: Updated patch with more precise variables in the new test. Thanks for taking the initiative. Here's an example which seems to get worse with the new variable set to nil: def foo foo.update( { key => value, other_key: foo } ) end I'd

bug#72929: [Norbert Koch] Error building emacs after 73277a4097b

2024-09-01 Thread Norbert Koch
Stefan Kangas writes: Hello Stefan, > Thanks for reporting this. > > Forwarding the below to the bug tracker in case anyone sees a quick fix. > I'll be AFK in the next couple of hours or so. > > FWIW, I can't reproduce the below on macOS 15 or Ubuntu 22.04 LTS. > Did you try `make bootstrap`?

bug#72929: [Norbert Koch] Error building emacs after 73277a4097b

2024-09-01 Thread Eli Zaretskii
> Cc: Norbert Koch > From: Stefan Kangas > Date: Sun, 1 Sep 2024 07:45:35 -0700 > > Thanks for reporting this. > > Forwarding the below to the bug tracker in case anyone sees a quick fix. I think image.c needs to include to avoid this.

bug#71646: 29.3; pixel-scroll-precision-mode overrides paging behaviour even when pixel-scroll-precision-interpolate-page is off

2024-09-01 Thread Stefan Kangas
Eli Zaretskii writes: > Ping! Should I close this? Shouldn't we rather fix the bug described by Mike? I.e. this: > Setting `pixel-scroll-precision-interpolate-page’ is supposed to > turn off the paging animation (which it does) however even when it’s > off, and invoke `cua-scroll-up’ & `cua-

bug#72929: [Norbert Koch] Error building emacs after 73277a4097b

2024-09-01 Thread Norbert Koch
Pip Cet writes: > "Stefan Kangas" writes: > >> Forwarding the below to the bug tracker in case anyone sees a quick fix. >> I'll be AFK in the next couple of hours or so. > > I can reproduce this with --with-x-toolkit=no. An explicit > > #include > > seems to be all that's required, so I've bol

bug#72915: Docstrings of add-hook and remove-hook improvement?

2024-09-01 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
>> The wording in the manual is probably all that is needed here: >> >> This function removes FUNCTION from the hook variable HOOK. > > BTW. Here's another idea: > > If HOOK is a list of functions, remove FUNCTION from that list. > > If HOOK is equal to FUNCTION, set HOOK to nil. > >

bug#72915: Docstrings of add-hook and remove-hook improvement?

2024-09-01 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
>> -HOOK should be a symbol. If HOOK is void, it is first set to >> -nil. If HOOK's value is a single function, it is changed to a >> -list of functions. > Is the bit about setting HOOK to nil incorrect? Because the new text > drops that part. That's an internal detail that's not observable to

bug#72919: 29.1; chart-space-usage in chart.el does not work correctly on windows

2024-09-01 Thread Eli Zaretskii
[Please use Reply All to reply, so that the bug tracker is CC'ed.] > From: Harm Van der Vegt > Date: Sun, 1 Sep 2024 20:11:39 +0200 > > >Thanks. However, I think your changes are not entirely correct: they > >fail to account for space usage of files inside subdirectories of the > >directory whi

bug#72829: describe-function NEWS* scraper override

2024-09-01 Thread Mattias Engdegård
1 sep. 2024 kl. 00.26 skrev Stefan Kangas : > For symbols that are in symbol-releases.eld, which means we are actually > sure about the addition, shouldn't the help text be changed from > >Probably introduced at or before Emacs version XX.Y. > > to something more like > >Added in Emacs