Re: [bug-gettext] gettext-lua

2013-04-11 Thread Ľubomír Remák
Hello, > I've squashed those commits into one, and pushed to maint branch (which > will be merged to master soon). Awesome! Thank you. > Since I modified the code a bit, it would be great if you could check > the changes. I did: > > * reformat comments according to GNU Coding Standards[1] > *

Re: [bug-gettext] gettext-lua

2013-04-11 Thread Daiki Ueno
Hi $(D*K(Bubom$(D+?(Br, $(D*K(Bubom$(D+?(Br Rem$(D+!(Bk writes: > Yes, those 7 and two more: > > 3589fe613e920c3f1455cce8739b09be6ac7822f (Wed Apr 11 02:02:25 2012 > +0200) > d617e9240cf76c9b4c629ebde0dfab96d7b9eee9 (Tue May 29 19:52:18 2012 > +0200) I've squashed those commits into o

Re: [bug-gettext] gettext-lua

2013-04-10 Thread Ľubomír Remák
V Streda, 10. dubeň 2013 o 11:59 +0900, Daiki Ueno napísal(a): > Ľubomír Remák writes: > > > I've pushed the merge on my github (it merged without any conflicts and > > the test cases ran without any problems). Sorry it took me so long to > > get back to this. > > Well, after the merge, the lua

Re: [bug-gettext] gettext-lua

2013-04-10 Thread Daiki Ueno
Daiki Ueno writes: >> Daiki, can you please review it and tell me if there's anything else >> that needs to be done to get this merged upstream? > > Sure. Anyway, I've checked x-lua.c and it looks mostly good to me, except coding styles and a minor issue in phase2_get, where lineno should be ini

Re: [bug-gettext] gettext-lua

2013-04-09 Thread Daiki Ueno
$(D*K(Bubom$(D+?(Br Rem$(D+!(Bk writes: > I've pushed the merge on my github (it merged without any conflicts and > the test cases ran without any problems). Sorry it took me so long to > get back to this. Well, after the merge, the lua changes can be no longer easily identified. I guess

Re: [bug-gettext] gettext-lua

2013-04-09 Thread Ľubomír Remák
Hello, Bas, thanks, I don't mind it at all. I've pushed the merge on my github (it merged without any conflicts and the test cases ran without any problems). Sorry it took me so long to get back to this. Daiki, can you please review it and tell me if there's anything else that needs to be done t

Re: [bug-gettext] gettext-lua

2013-04-09 Thread Bas Wijnen
Hello, (Ľubomír, I've taken the liberty to ask on the gettext mailinglist about including your code; I hope you don't mind.) Daiki, thank you for your reply. On Tue, Apr 09, 2013 at 12:16:16PM +0900, Daiki Ueno wrote: > Have you already asked the author if he is willing to upstream this? Yes, a