Re: [bug-gettext] [PATCH] OS/2 patches

2015-12-22 Thread KO Myung-Hun
Hi/2. Daiki Ueno wrote: > Sorry for late response. > > KO Myung-Hun writes: > [PATCH 1/8] moop: Replace CR as well as NL with a space >>> >>> I'm not sure who adds CR here. Can't we assume that all source files >>> use NL line termination? Or some other tools add CR on OS/2? Also, I >>>

Re: [bug-gettext] [PATCH] OS/2 patches

2015-12-21 Thread Daiki Ueno
Sorry for late response. KO Myung-Hun writes: >>> [PATCH 1/8] moop: Replace CR as well as NL with a space >> >> I'm not sure who adds CR here. Can't we assume that all source files >> use NL line termination? Or some other tools add CR on OS/2? Also, I >> worry about the portability of '\r'

Re: [bug-gettext] [PATCH] OS/2 patches

2015-11-18 Thread KO Myung-Hun
Hi/2. Daiki Ueno wrote: > KO Myung-Hun writes: > > Thanks for the patches. Some comments below. > >> [PATCH 1/8] moop: Replace CR as well as NL with a space > > I'm not sure who adds CR here. Can't we assume that all source files > use NL line termination? Or some other tools add CR on OS

Re: [bug-gettext] [PATCH] OS/2 patches

2015-11-17 Thread John Cowan
Daiki Ueno scripsit: > I'm not sure who adds CR here. Can't we assume that all source files > use NL line termination? Or some other tools add CR on OS/2? Also, I > worry about the portability of '\r' as an argument of tr. Yes, it's definitely better to use '\015' for portability. -- John Co

Re: [bug-gettext] [PATCH] OS/2 patches

2015-11-17 Thread Daiki Ueno
KO Myung-Hun writes: Thanks for the patches. Some comments below. > [PATCH 1/8] moop: Replace CR as well as NL with a space I'm not sure who adds CR here. Can't we assume that all source files use NL line termination? Or some other tools add CR on OS/2? Also, I worry about the portability o

[bug-gettext] [PATCH] OS/2 patches

2015-11-08 Thread KO Myung-Hun
Hi/2. These are OS/2 patches. Review, please... [PATCH 1/8] moop: Replace CR as well as NL with a space [PATCH 2/8] test-lock: Do not include sched.h on kLIBC [PATCH 3/8] build: Do not include os2compat.[ch] [PATCH 4/8] gettext-runtime: Fix name resolution failures on kLIBC [PATCH 5/8] intl: Sup