Re: [PATCH] ls: make possible to disable hard links highlighting

2009-03-24 Thread Kamil Dudka
Hi Pádraig, thank you for review! On Tuesday 24 March 2009 02:05:33 Pádraig Brady wrote: > Kamil Dudka wrote: > > Hello, > > > > promissed patch for ls to disable hard links highlighting is attached. > > A simple test case is included. > > This is better, but dircolors still outputs the hl=44;37

Re: [PATCH] ls: make possible to disable hard links highlighting

2009-03-24 Thread Pádraig Brady
Kamil Dudka wrote: > dirvish users can simply disable it if they really want to. If somebody is > not > interested in hard links highlighting it is not enough reason to disable it > by default. Yes, it is strong reason to make it optionally. That's my > opinion. I'm still not convinced, but le

Re: [PATCH] ls: make possible to disable hard links highlighting

2009-03-24 Thread Kamil Dudka
On Tuesday 24 March 2009 12:05:21 Pádraig Brady wrote: > Kamil Dudka wrote: > >> p.s. you forgot the '* ' on front of the filenames in the changelog > > > > Good catch. Thanks! > > Could you resubmit a patch with an addition to "NEWS \** Changes in > behavior" that mentions one can disable coloring

Re: DD problem

2009-03-24 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Douglas Ritter on 3/23/2009 6:32 PM: > ___ > Bug-coreutils mailing list > Bug-coreutils@gnu.org > http://lists.gnu.org/mailman/listinfo/bug-coreutils Your mail came through without contents. I

Re: [bug #24949] coreutils pwd not implementing latest POSIX features

2009-03-24 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 3/23/2009 2:53 PM: > Follow-up Comment #3, bug #24949 (project coreutils): > > How about the attached patch? To make it easier to review, this is my proposed patch to make pwd understand -L and -P, per POSIX. I made the ch

Re: misalignment in ls -l in fr_FR locale

2009-03-24 Thread Pádraig Brady
Updated patch attached. Note caching the abbreviated months like this speeds `ls -l` up by around 10% which is nice, though not that important as ls output is mainly for processing by humans. cheers, Pádraig. >From dec4db2e8e07f90845f66858de21b0446c591746 Mon Sep 17 00:00:00 2001 From: =?utf-8?q

Re: misalignment in ls -l in fr_FR locale

2009-03-24 Thread Pádraig Brady
Pádraig Brady wrote: > Updated patch attached. > > Note caching the abbreviated months like this speeds `ls -l` > up by around 10% which is nice, though not that important > as ls output is mainly for processing by humans. eep, previous patch had a few buglets... diff --git a/src/ls.c b/src/ls.c

Re: [PATCH] ls: make possible to disable hard links highlighting

2009-03-24 Thread Pádraig Brady
Kamil Dudka wrote: > On Tuesday 24 March 2009 12:05:21 Pádraig Brady wrote: >> Kamil Dudka wrote: p.s. you forgot the '* ' on front of the filenames in the changelog >>> Good catch. Thanks! >> Could you resubmit a patch with an addition to "NEWS \** Changes in >> behavior" that mentions one ca

Re: [bug #24949] coreutils pwd not implementing latest POSIX features

2009-03-24 Thread Jim Meyering
Eric Blake wrote: > According to Eric Blake on 3/23/2009 2:53 PM: >> Follow-up Comment #3, bug #24949 (project coreutils): >> >> How about the attached patch? > > To make it easier to review, this is my proposed patch to make pwd > understand -L and -P, per POSIX. I made the choice of having the b

Re: ls -v is still inconsistent

2009-03-24 Thread Jim Meyering
Kamil Dudka wrote: > From d889021cebb7bf798d1b7bf24149c354627e9553 Mon Sep 17 00:00:00 2001 > From: Kamil Dudka > Date: Fri, 20 Mar 2009 11:20:12 +0100 > Subject: [PATCH] filevercmp: extension for simple and numbered backups Hi Kamil, Thanks again. Complete patch below. I'm merging this incremen

Re: ls -v is still inconsistent

2009-03-24 Thread Jim Meyering
Jim Meyering wrote: > Kamil Dudka wrote: >> From d889021cebb7bf798d1b7bf24149c354627e9553 Mon Sep 17 00:00:00 2001 >> From: Kamil Dudka >> Date: Fri, 20 Mar 2009 11:20:12 +0100 >> Subject: [PATCH] filevercmp: extension for simple and numbered backups > > Hi Kamil, > > Thanks again. > Complete patc

Re: root check failed for install-C-root

2009-03-24 Thread hggdh
On Fri, 20 Mar 2009 11:08:55 +0100 Kamil Dudka wrote: > On Wednesday 18 March 2009 18:31:29 Kamil Dudka wrote: > > Any idea how to reproduce the test failure? > > Note I've tested it with the fresh Ubuntu installation and the > updated one. No, I still have no idea. It fails when running check-

[PATCH] tests: ls -v: exercise yet another change in gnulib's new filevercmp

2009-03-24 Thread Jim Meyering
FYI, I've added this test to go along with the preceding update-submodule-to-latest-gnulib change: >From b498eb071de71a8b77fdaec3e4b8ea3e4c2074ea Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 24 Mar 2009 22:33:47 +0100 Subject: [PATCH] tests: ls -v: exercise yet another change in gnulib'

Re: ls -v is still inconsistent

2009-03-24 Thread Kamil Dudka
On Tuesday 24 of March 2009 22:15:59 Jim Meyering wrote: > Jim Meyering wrote: > > Kamil Dudka wrote: > >> From d889021cebb7bf798d1b7bf24149c354627e9553 Mon Sep 17 00:00:00 2001 > >> From: Kamil Dudka > >> Date: Fri, 20 Mar 2009 11:20:12 +0100 > >> Subject: [PATCH] filevercmp: extension for simple