Re: stty & stty-row-col test failures

2009-12-08 Thread Jim Meyering
Pádraig Brady wrote: > Jim Meyering wrote: >> Thanks for tracking that down! >> Would you please use "!=" in that test >> and $(...) rather than `...` ? > > Sure, I was wary because of the mention of sunos in the test. The configure-time test for a posix shell should cover us in the tests, since e

Re: stty & stty-row-col test failures

2009-12-08 Thread Pádraig Brady
Jim Meyering wrote: > Thanks for tracking that down! > Would you please use "!=" in that test > and $(...) rather than `...` ? Sure, I was wary because of the mention of sunos in the test.

Re: stty & stty-row-col test failures

2009-12-08 Thread Jim Meyering
Pádraig Brady wrote: > Matthew Burgess wrote: >> Hi, >> >> The stty & stty-row-col tests fail for me, but I can't figure out why. I >> wonder whether it's because I'm in a VirtualBox host and it's somehow >> interfering with the tests? Anyway, I've attached the logs from a >> verbose run of both

Re: stty & stty-row-col test failures

2009-12-08 Thread Jim Meyering
Pádraig Brady wrote: > I'm going with this unless there are objections > >>From bb0ae98acca9fe2b27eb5ccadf57d4842cab5d8f Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?P=C3=A1draig=20Brady?= > Date: Tue, 8 Dec 2009 08:00:37 + > Subject: [PATCH] tests: fix stty-row-col failure on small fixed termi

Re: stty & stty-row-col test failures

2009-12-08 Thread Pádraig Brady
I'm going with this unless there are objections >From bb0ae98acca9fe2b27eb5ccadf57d4842cab5d8f Mon Sep 17 00:00:00 2001 From: =?utf-8?q?P=C3=A1draig=20Brady?= Date: Tue, 8 Dec 2009 08:00:37 + Subject: [PATCH] tests: fix stty-row-col failure on small fixed terminals * tests/misc/stty-row-col:

Re: stty & stty-row-col test failures

2009-12-07 Thread Pádraig Brady
Matthew Burgess wrote: > On Mon, 07 Dec 2009 00:30:05 +, Pádraig Brady wrote: > >> The stty-row-col test is getting EINVAL from the system. >> Can you try running this is a terminal to see if it does the same? >> >> stty rows 40 columns 80 > > OK, I think I understand now. > > $ stty size

Re: stty & stty-row-col test failures

2009-12-07 Thread Matthew Burgess
> diff --git a/tests/misc/stty b/tests/misc/stty > index cb3fee5..e8b2a9a 100755 > --- a/tests/misc/stty > +++ b/tests/misc/stty > @@ -63,8 +63,10 @@ options=`stty -a | tr -s ';' '\n' | sed "s/^ > //;$sed_del;s/-//g"` > for opt in $options; do ># `stty parenb' and `stty -parenb' fail with this

Re: stty & stty-row-col test failures

2009-12-07 Thread Matthew Burgess
On Mon, 07 Dec 2009 00:30:05 +, Pádraig Brady wrote: > The stty-row-col test is getting EINVAL from the system. > Can you try running this is a terminal to see if it does the same? > > stty rows 40 columns 80 OK, I think I understand now. $ stty size 25 80 $ stty rows 25 columns 80 $ $ s

Re: stty & stty-row-col test failures

2009-12-07 Thread Matthew Burgess
On Mon, 07 Dec 2009 00:30:05 +, Pádraig Brady wrote: > The stty-row-col test is getting EINVAL from the system. > Can you try running this is a terminal to see if it does the same? > > stty rows 40 columns 80 Hi Padraig, Yes, that gives the same output: $ stty rows 40 columns 80 stty: s

Re: stty & stty-row-col test failures

2009-12-06 Thread Gilles Espinasse
- Original Message - From: "Pádraig Brady" To: "Matthew Burgess" Cc: Sent: Monday, December 07, 2009 12:21 AM Subject: Re: stty & stty-row-col test failures > Matthew Burgess wrote: > > Hi, > > > > The stty & stty-row-col tests fail

Re: stty & stty-row-col test failures

2009-12-06 Thread Pádraig Brady
Matthew Burgess wrote: > Hi, > > The stty & stty-row-col tests fail for me, but I can't figure out why. I > wonder whether it's because I'm in a VirtualBox host and it's somehow > interfering with the tests? Anyway, I've attached the logs from a > verbose run of both tests. If someone wouldn't m

Re: stty & stty-row-col test failures

2009-12-06 Thread Pádraig Brady
Matthew Burgess wrote: > Hi, > > The stty & stty-row-col tests fail for me, but I can't figure out why. I > wonder whether it's because I'm in a VirtualBox host and it's somehow > interfering with the tests? Anyway, I've attached the logs from a > verbose run of both tests. If someone wouldn't m

Re: stty & stty-row-col test failures

2009-12-06 Thread Gilles Espinasse
- Original Message - From: "Matthew Burgess" To: Cc: Sent: Sunday, December 06, 2009 8:45 PM Subject: stty & stty-row-col test failures > Hi, > > The stty & stty-row-col tests fail for me, but I can't figure out why. I > wonder whether it

stty & stty-row-col test failures

2009-12-06 Thread Matthew Burgess
Hi, The stty & stty-row-col tests fail for me, but I can't figure out why. I wonder whether it's because I'm in a VirtualBox host and it's somehow interfering with the tests? Anyway, I've attached the logs from a verbose run of both tests. If someone wouldn't mind taking a look for me pleas