bug#62404: --reflink=auto not falling back appropriately on older kernels

2023-03-25 Thread Paul Eggert
Thanks for installing that. I found the comments still a bit confusing so I pushed the attached; hope it's OK. It is annoying that in the common case where A is a regular file and B does not exist but will be created on the same file system, the syscalls start out: openat(AT_FDCWD, "B", O_

bug#62404: --reflink=auto not falling back appropriately on older kernels

2023-03-24 Thread Pádraig Brady
The fix for this is now pushed at: https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=093a8b4bf marking this as done. thanks, Pádraig

bug#62404: --reflink=auto not falling back appropriately on older kernels

2023-03-23 Thread Pádraig Brady
On 23/03/2023 22:57, Paul Eggert wrote: Thanks for looking into this. On 3/23/23 07:55, Pádraig Brady wrote: Perhaps we should use the above __ANDROID__ logic in all cases, so that we fallback unless there is a specific reason not to. Yes, that sounds better. +/* Whether the errno indicate

bug#62404: --reflink=auto not falling back appropriately on older kernels

2023-03-23 Thread Paul Eggert
Thanks for looking into this. On 3/23/23 07:55, Pádraig Brady wrote: Perhaps we should use the above __ANDROID__ logic in all cases, so that we fallback unless there is a specific reason not to. Yes, that sounds better. +/* Whether the errno indicates operation is a transient failure. + I

bug#62404: --reflink=auto not falling back appropriately on older kernels

2023-03-23 Thread Pádraig Brady
On 23/03/2023 13:39, Pádraig Brady wrote: On 23/03/2023 13:03, Pádraig Brady wrote: Details at https://github.com/termux/termux-packages/issues/15706#issuecomment-1481144831 But in summary, the new --reflink errno checking in coreutils 9.2 is not working appropriately on android 4.9 kernels at

bug#62404: --reflink=auto not falling back appropriately on older kernels

2023-03-23 Thread Pádraig Brady
On 23/03/2023 13:03, Pádraig Brady wrote: Details at https://github.com/termux/termux-packages/issues/15706#issuecomment-1481144831 But in summary, the new --reflink errno checking in coreutils 9.2 is not working appropriately on android 4.9 kernels at least. Proposed patch attached. It may be

bug#62404: --reflink=auto not falling back appropriately on older kernels

2023-03-23 Thread Pádraig Brady
Details at https://github.com/termux/termux-packages/issues/15706#issuecomment-1481144831 But in summary, the new --reflink errno checking in coreutils 9.2 is not working appropriately on android 4.9 kernels at least. cheers, Pádraig