bug#60416: [PATCH] copy: attempt copy offload with sparse files

2022-12-31 Thread Pádraig Brady
On 31/12/2022 01:36, Paul Eggert wrote: On 2022-12-30 16:23, Pádraig Brady wrote: I may follow up with a related patch to ensure we _don't_ use copy_file_range with --sparse=never. Not sure it's worth the bother. A file system that would create holes with copy_file_range could also do so with

bug#60416: [PATCH] copy: attempt copy offload with sparse files

2022-12-30 Thread Paul Eggert
On 2022-12-30 16:23, Pádraig Brady wrote: I may follow up with a related patch to ensure we _don't_ use copy_file_range with --sparse=never. Not sure it's worth the bother. A file system that would create holes with copy_file_range could also do so with plain 'write', no?

bug#60416: [PATCH] copy: attempt copy offload with sparse files

2022-12-30 Thread Pádraig Brady
On 30/12/2022 22:32, Paul Eggert wrote: Thanks, looks good, please install. Thanks for the review. OP also posted good results. Pushed with NEWS entry. Marking this as done. I may follow up with a related patch to ensure we _don't_ use copy_file_range with --sparse=never. cheers, Pádraig

bug#60416: [PATCH] copy: attempt copy offload with sparse files

2022-12-30 Thread Paul Eggert
Thanks, looks good, please install.

bug#60416: [PATCH] copy: attempt copy offload with sparse files

2022-12-30 Thread Pádraig Brady
On 30/12/2022 15:33, Pádraig Brady wrote: On 29/12/2022 16:04, Braiam wrote: When using a nfs export, cp seems to not try hard enough using copy_file_range(). This was the conclusion we arrived in this forum thread[1] at Truenas forums. It was found a way to force cp to use it, but it should not