bug#12656: WG: Re[4]: bug#12656: cp since 8.11 corrupts files

2012-10-21 Thread Jim Meyering
Bernhard Voelker wrote: > On 10/17/2012 10:44 AM, Jim Meyering wrote: ... >> ** Bug fixes >> >> + cp could read from freed memory and could even make corrupt copies. >> + This could happen only with a very fragmented input file and when using >> + its FIEMAP/extent-based copying code. [bug int

bug#12656: WG: Re[4]: bug#12656: cp since 8.11 corrupts files

2012-10-21 Thread Bernhard Voelker
On 10/17/2012 10:44 AM, Jim Meyering wrote: > From a5365003c88f4fce6293827c13f90acd0b5bd0cc Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Tue, 16 Oct 2012 17:43:49 +0200 > Subject: [PATCH] cp: avoid data-corrupting free-memory-read > > * src/extent-scan.c (extent_scan_read): Reset our las

bug#12656: WG: Re[4]: bug#12656: cp since 8.11 corrupts files

2012-10-17 Thread Jim Meyering
m.ge...@avm.de wrote: > different cp version produce different corruptions: > > 8.11: unpatched: 14 corrupted files; patched == OK > 8.19: unpatched: 3 corrupted files; patched == OK Thanks for the thorough testing. Here's a complete patch: Changes: - added a comment to the c

bug#12656: WG: Re[4]: bug#12656: cp since 8.11 corrupts files

2012-10-16 Thread m . gerth
Hi Jim, different cp version produce different corruptions: 8.11: unpatched: 14 corrupted files; patched == OK 8.19: unpatched: 3 corrupted files; patched == OK Regards, Mike

bug#12656: cp since 8.11 corrupts files

2012-10-16 Thread Jim Meyering
m.ge...@avm.de wrote: > Hi Jim, > > Congratulation - the patch works for me. Result looks good - no errors. > Tomorror I will test more extensive (copy all files and compare all files). > The debug output from the first patch is now identical when using the bulk > copy > and the single copy. Grea

bug#12656: Re[4]: bug#12656: cp since 8.11 corrupts files

2012-10-16 Thread m . gerth
Meyering An: "Mike Gerth" Kopie: "Alan Curry" , 12...@debbugs.gnu.org Datum: 16.10.2012 17:46 Betreff:Re: bug#12656: Re[3]: bug#12656: cp since 8.11 corrupts files Mike Gerth wrote: > Hi Alan, > the difference between bulk copy (then the corruption com

bug#12656: Re[3]: bug#12656: cp since 8.11 corrupts files

2012-10-16 Thread Jim Meyering
t;> Julius.nsf merged extent#3 off=18239488 len=159744 flags=0x1000 ... > Von:"Alan Curry" > An: m.ge...@avm.de > Kopie: j...@meyering.net (Jim Meyering), 12...@debbugs.gnu.org > Datum: 16.10.2012 03:14 > Betreff: Re: bug#12656: Re[2]: bug#12656: cp since

bug#12656: Re[3]: bug#12656: cp since 8.11 corrupts files

2012-10-16 Thread Mike Gerth
flags=0x1000 Thanks, Mike Von:"Alan Curry" An: m.ge...@avm.de Kopie: j...@meyering.net (Jim Meyering), 12...@debbugs.gnu.org Datum: 16.10.2012 03:14 Betreff:Re: bug#12656: Re[2]: bug#12656: cp since 8.11 corrupts files The critical piece of the trace is here: l

bug#12656: Re[2]: bug#12656: cp since 8.11 corrupts files

2012-10-15 Thread m . gerth
Alt-Moabit 95, 10559 Berlin HRB 23075 AG Charlottenburg Geschäftsführer: Johannes Nill Von:Jim Meyering An: "Mike Gerth" Kopie: 12...@debbugs.gnu.org Datum: 15.10.2012 19:51 Betreff: Re: bug#12656: cp since 8.11 corrupts files Mike Gerth wrote: > I notice

bug#12656: cp since 8.11 corrupts files

2012-10-15 Thread Jim Meyering
Mike Gerth wrote: > I noticed an error in cp (8.11 upwards till 8.19) when copying many files > from an fragmented ext3fs (to an empty partition). > > ERROR: > The copied file has exact length. > The SourceFile has in the middle a 4K-block filled with ZERO, the > DestFile this 4k-bl

bug#12656: cp since 8.11 corrupts files

2012-10-15 Thread Mike Gerth
Hello, I noticed an error in cp (8.11 upwards till 8.19) when copying many files from an fragmented ext3fs (to an empty partition). ERROR: The copied file has exact length. The SourceFile has in the middle a 4K-block filled with ZERO, the DestFile this 4k-block and the previous