Re: [PATCH] avoid -Wsign-compare warnings

2008-07-12 Thread Jim Meyering
Pádraig Brady <[EMAIL PROTECTED]> wrote: > I noticed Jim fixed a couple obvious > issues highlighted by the -Wsigned-compare gcc option > we were talking about a few days ago. > > The attached patch silences all other instances, > so that this option may be used to help find these > hard to spot er

Re: [PATCH] avoid -Wsign-compare warnings

2008-07-11 Thread Andreas Schwab
Pádraig Brady <[EMAIL PROTECTED]> writes: > I don't see why gcc is giving this warning, as > there is no comparison between signed and unsigned here. > For example in the following program compiled > with -Wsign-compare why does the second assignment > give a warning, while the first doesn't? > >

Re: [PATCH] avoid -Wsign-compare warnings

2008-07-11 Thread Pádraig Brady
Pádraig Brady wrote: > I noticed Jim fixed a couple obvious > issues highlighted by the -Wsigned-compare gcc option > we were talking about a few days ago. > > The attached patch silences all other instances, > so that this option may be used to help find these > hard to spot errors, when they're