Re: [PATCH] Use a hash rather than a linked-list for cycle check in cp

2008-04-29 Thread Cai Xianchao
> Hi Bo, > > Thanks for that patch. > > However, let's see if Cai Xianchao and Li Zefan > are still working on rewriting cp to use openat-style functions. > I am sorry for replying so late. :-[ I am busy recently, so the development speed is very slow. I have finished the work as follows:

Re: [PATCH] Use a hash rather than a linked-list for cycle check in cp

2008-04-22 Thread Jim Meyering
"Bo Borgerson" <[EMAIL PROTECTED]> wrote: > On Tue, Apr 22, 2008 at 3:03 PM, Jim Meyering <[EMAIL PROTECTED]> wrote: >> >> Hi Bo, >> >> Thanks for that patch. >> >> However, let's see if Cai Xianchao and Li Zefan >> are still working on rewriting cp to use openat-style functions. >> >> http:

Re: [PATCH] Use a hash rather than a linked-list for cycle check in cp

2008-04-22 Thread Bo Borgerson
On Tue, Apr 22, 2008 at 3:03 PM, Jim Meyering <[EMAIL PROTECTED]> wrote: > > Hi Bo, > > Thanks for that patch. > > However, let's see if Cai Xianchao and Li Zefan > are still working on rewriting cp to use openat-style functions. > > http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/12041

Re: [PATCH] Use a hash rather than a linked-list for cycle check in cp

2008-04-22 Thread Jim Meyering
"Bo Borgerson" <[EMAIL PROTECTED]> wrote: > This addresses a FIXME in src/copy.c: > > > -/* FIXME: rewrite this to use a hash table so we avoid the quadratic > - performance hit that's probably noticeable only on trees deeper > - than a few hundred levels. See use of active_dir_map in rem

Re: [PATCH] Use a hash rather than a linked-list for cycle check in cp

2008-04-22 Thread James Youngman
On Wed, Apr 16, 2008 at 10:34 PM, Bo Borgerson <[EMAIL PROTECTED]> wrote: > The performance benefit is there, but on my machine with a PATH_MAX of > 4096 it's hard to see, because the userland work `cp' does is dwarfed > by the work the kernel does on its behalf: Many platforms allow you to cre