Paul Eggert wrote:
Matthew Woehlke writes:
Please do not quote my e-mail address unobfuscated in message bodies. :-)
Paul Eggert wrote:
+ if (total != UINTMAX_MAX)
Um... I've mentioned that this won't work, haven't I? AIX is (AFAICT)
giving 0xFFF...FFE, not 0xFFF...FFF.
The later pat
Matthew Woehlke writes:
> Paul Eggert wrote:
>> + if (total != UINTMAX_MAX)
>
> Um... I've mentioned that this won't work, haven't I? AIX is (AFAICT)
> giving 0xFFF...FFE, not 0xFFF...FFF.
The later patch (in that same message) adjusted that line to deal with
(uintmax_t) -2.
Maybe some oth
Paul Eggert wrote:
+ if (total != UINTMAX_MAX)
Um... I've mentioned that this won't work, haven't I? AIX is (AFAICT)
giving 0xFFF...FFE, not 0xFFF...FFF.
--
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
--
"We're all mad here. I'm mad. You're mad... You m
From: Paul Eggert
> Date: Wed, 25 Mar 2009 14:16:46 -0700
> Subject: [PATCH] df: Fix bug when totaling unknown values.
Thanks!
I've just pushed them:
$ g fp --stdout -2 | grep Subj
Subject: [PATCH 1/2] df: fix a bug when totaling unknown values
Subject: [PATCH 2/2] df: port the kn
;s a bit more specific. Here's that same patch, followed by a further
patch to add known_value, generated by git-format-patch.
===
>From abc8e21a0b5a55bed938b30adf217a26c1a17bac Mon Sep 17 00:00:00 2001
From: Paul Eggert
Date: Wed, 25 Mar 2009 14:16:46 -0700
Subject: [PATCH] df: Fix b
Jim Meyering wrote:
Good timing.
Matthew Woehlke recently reported failure of the df/total-verify test.
Looking into it, we found that one of those values was UINTMAX_MAX - 1.
Oops, I saw what the patch was and assumed you (Jim) sent it. Sorry for
the confusion, Paul! (...that would explain wh
Paul Eggert wrote:
This fixes a bug reported by "make check" on a Solaris 10 host with
some funky file systems.
It was AIX ;-).
* src/df.c (show_dev): Don't add UINTMAX_MAX to grand totals, as that
value indicates that the true value is unknown; adding it effectively
subtracts 1 from the tota
Paul Eggert wrote:
> This fixes a bug reported by "make check" on a Solaris 10 host with
> some funky file systems.
>
> * src/df.c (show_dev): Don't add UINTMAX_MAX to grand totals, as that
> value indicates that the true value is unknown; adding it effectively
> subtracts 1 from the total, whereas
This fixes a bug reported by "make check" on a Solaris 10 host with
some funky file systems.
* src/df.c (show_dev): Don't add UINTMAX_MAX to grand totals, as that
value indicates that the true value is unknown; adding it effectively
subtracts 1 from the total, whereas we want to leave the total al
