bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-05-04 Thread Rocky Bernstein
On Fri, May 4, 2012 at 10:07 AM, Jim Meyering wrote: > Rocky Bernstein wrote: > > On Fri, May 4, 2012 at 8:19 AM, Jim Meyering wrote: > ... > > Please don't interpret my review delays or my misreading your > > patch as anything deliberately unfriendly. >

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-05-04 Thread Rocky Bernstein
On Fri, May 4, 2012 at 4:49 AM, Jim Meyering wrote: > Rocky Bernstein wrote: > > Any word on this? > > Hi Rocky, > > Sorry about the extended delay. > Changing su.c like this has really low priority. > > I've looked at your patch and see that it changes the sem

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-05-03 Thread Rocky Bernstein
Any word on this? On Thu, Apr 12, 2012 at 10:43 PM, Rocky Bernstein wrote: > On Sat, Apr 7, 2012 at 2:15 AM, Jim Meyering wrote: > >> Rocky Bernstein wrote: >> > Any progress or thoughts on the revised patch? >> >> Hi Rocky, >> Sorry about the delay.

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-04-12 Thread Rocky Bernstein
On Sat, Apr 7, 2012 at 2:15 AM, Jim Meyering wrote: > Rocky Bernstein wrote: > > Any progress or thoughts on the revised patch? > > Hi Rocky, > Sorry about the delay. > I haven't forgotten. > > I noticed that your test requires typing a root password. > Um

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-03-31 Thread Rocky Bernstein
Any progress or thoughts on the revised patch? On Tue, Feb 14, 2012 at 10:53 PM, Rocky Bernstein wrote: > Attached should be a revised patch that addresses all of your suggestions. > > Cheers, >rocky > > > On Tue, Feb 14, 2012 at 5:49 AM, Jim Meyering wrote: >

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-02-14 Thread Rocky Bernstein
Attached should be a revised patch that addresses all of your suggestions. Cheers, rocky On Tue, Feb 14, 2012 at 5:49 AM, Jim Meyering wrote: > Rocky Bernstein wrote: > > > On Mon, Feb 13, 2012 at 4:19 AM, Jim Meyering wrote: > > > > Rocky Bernstein wrote: >

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-02-13 Thread Rocky Bernstein
On Mon, Feb 13, 2012 at 4:19 AM, Jim Meyering wrote: > Rocky Bernstein wrote: > > It's been a couple of months since I first sent this was sent without > nary > > an ack. Comments? > > Hi Rocky, > > su is barely on life support in coreutils. > Meaning that

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-02-12 Thread Rocky Bernstein
Hi - It's been a couple of months since I first sent this was sent without nary an ack. Comments?

bug#10317: patch to su: -l and -p should not be used together

2011-12-18 Thread Rocky Bernstein
Hi - I noticed that -m (-p, --preserve-environment) and -l (- --login) can't be used together. Attached is a patch to give a warning if they are and to indicate which option is used. In the code, I opted for the earlier option ignoring the later option. In the code --login has precedence over --p