bug#47324: Missing information in documentation

2021-03-25 Thread L A Walsh
On 2021/03/25 08:36, Glenn Golden wrote: Perl's perldoc(1) is more or less analogous in spirit to GNU's approach based on info(1). The man pages contain quite a bit of useful info, but do not purport to be exhaustive. = On 2021/03/25 08:05, Paul Eggert wrote: Most free-software proj

bug#47324: AW: bug#47324: Missing information in documentation

2021-03-25 Thread Bernhard Voelker
On 3/23/21 11:18 AM, Walter Harms via GNU coreutils Bug Reports wrote: > In my case there was no security context involved. > It was a loop device mounted (that i was not aware of, > the image was already gone). > and rm -r stoped here because of "in use". > > I expected some mentioning of mount s

bug#47383: [PATCH 2/2] ln: fix memory leaks in do_link()

2021-03-25 Thread Kamil Dudka
On Thursday, March 25, 2021 5:19:56 PM CET Paul Eggert wrote: > Thanks, I installed that. I then changed "free(" to "free (" as per GNU > style. Thank you for incorporating both the patches. Kamil

bug#47384: [PATCH 1/2] hostname: fix a memory leak with -Dlint

2021-03-25 Thread Paul Eggert
On 3/25/21 11:16 AM, Paul Eggert wrote: I'd prefer it to use IF_LINT (as in the earlier change), as that makes it cleaner since it's just one line of useless code, not three. Installed as attached, and closing the bug report. Thanks again. >From d3749c46056ddeb1314f35b1644f52179d7a3502 Mon Sep

bug#47384: [PATCH 1/2] hostname: fix a memory leak with -Dlint

2021-03-25 Thread Paul Eggert
On 3/25/21 9:33 AM, Kamil Dudka wrote: How does it differ from the following change, which you did not block? Thanks for reminding me of the earlier exchange. On second thought I guess it's OK, though I'd prefer it to use IF_LINT (as in the earlier change), as that makes it cleaner since it's

bug#47384: [PATCH 1/2] hostname: fix a memory leak with -Dlint

2021-03-25 Thread Kamil Dudka
On Thursday, March 25, 2021 5:09:44 PM CET Paul Eggert wrote: > On 3/25/21 9:08 AM, Kamil Dudka wrote: > > Wasn't that exactly what -Dlint was for when we discussed it the last > > time? > > Sorry, don't recall the last time. I meant this thread on bug-gnulib ML: https://lists.gnu.org/archiv

bug#47383: [PATCH 2/2] ln: fix memory leaks in do_link()

2021-03-25 Thread Paul Eggert
Thanks, I installed that. I then changed "free(" to "free (" as per GNU style.

bug#47384: [PATCH 1/2] hostname: fix a memory leak with -Dlint

2021-03-25 Thread Paul Eggert
On 3/25/21 9:08 AM, Kamil Dudka wrote: Wasn't that exactly what -Dlint was for when we discussed it the last time? Sorry, don't recall the last time. This is a borderline area, admittedly.

bug#47384: [PATCH 1/2] hostname: fix a memory leak with -Dlint

2021-03-25 Thread Kamil Dudka
On Thursday, March 25, 2021 4:56:15 PM CET Paul Eggert wrote: > On 3/25/21 3:57 AM, Kamil Dudka wrote: > > +#ifdef lint > > + free(hostname); > > +#endif > > Let's not do this one. The program is about to exit so there's no need > to free, and any static-checking tool that complains about a m

bug#47384: [PATCH 1/2] hostname: fix a memory leak with -Dlint

2021-03-25 Thread Paul Eggert
On 3/25/21 3:57 AM, Kamil Dudka wrote: +#ifdef lint + free(hostname); +#endif Let's not do this one. The program is about to exit so there's no need to free, and any static-checking tool that complains about a missing 'free' here is issuing a false alarm. On this particular issue it's

bug#47324: Missing information in documentation

2021-03-25 Thread Glenn Golden
On Thu, Mar 25, 2021, at 07:49, L A Walsh wrote: > On 2021/03/22 15:21, Bernhard Voelker wrote: > > > > According to the GNU guidelines and to avoid double work, the man page of > > the coreutils is essentially not much more than the output of --help. > > > --- > It sure would be nice if

bug#47324: Missing information in documentation

2021-03-25 Thread Paul Eggert
On 3/25/21 6:49 AM, L A Walsh wrote:    If languages such as python and perl can document their usage in manpages, certainly gnu could be as helpful. You must be joking. Python and Perl are not fully documented in manpages. Most free-software projects treat manpages the way the Gnu project d

bug#47324: Missing information in documentation

2021-03-25 Thread L A Walsh
On 2021/03/22 15:21, Bernhard Voelker wrote: According to the GNU guidelines and to avoid double work, the man page of the coreutils is essentially not much more than the output of --help. --- It sure would be nice if GNU would join the *nix family and put full documentation in the manpag

bug#47353: Numbered backups also need kept-new-versions else will grow out of control

2021-03-25 Thread L A Walsh
On 2021/03/23 16:43, Dan Jacobson wrote: Or (info "(coreutils) Backup options") should "admit" that "Numbered backups need to be trimmed occasionally by the user, lest the fill up the disk." --- Perhaps a scheme, similar, or duplicating that in logrotate would be useful where older versions c

bug#47383: [PATCH 2/2] ln: fix memory leaks in do_link()

2021-03-25 Thread Kamil Dudka
* src/ln.c (do_link): Free memory allocated by convert_abs_rel() on all code paths. --- src/ln.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/ln.c b/src/ln.c index e79ca5e7ade..368b109daf0 100644 --- a/src/ln.c +++ b/src/ln.c @@ -229,14 +229,14 @@ do

bug#47384: [PATCH 1/2] hostname: fix a memory leak with -Dlint

2021-03-25 Thread Kamil Dudka
* src/hostname.c (main): Free allocated memory when compiled with -Dlint. --- src/hostname.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/hostname.c b/src/hostname.c index 7d13575d4e9..8ec9aad4d34 100644 --- a/src/hostname.c +++ b/src/hostname.c @@ -104,6 +104,9 @@ main (int argc, ch

bug#47380: Atomic install of files

2021-03-25 Thread Дилян Палаузов
Hello, `make install` calls: /usr/bin/install -c imap/.libs/httpd /usr/local/libexec/ and the syscalls behind are: newfstatat(AT_FDCWD, "imap/.libs/httpd", {st_mode=S_IFREG|0755, st_size=3362912, ...}, 0) = 0 newfstatat(AT_FDCWD, "/usr/local/libexec/httpd", {st_mode=S_IFREG|0755, st_size=336291