bug#15926: RFE: unlink command already uses 'unlink' call; make 'rm' use 'remove' call

2013-11-27 Thread Bernhard Voelker
On 11/27/2013 04:14 AM, Pádraig Brady wrote: > On 11/26/2013 11:08 PM, Bernhard Voelker wrote: >> +#--- >> +# Exercise "rm -r /" without and with the --preserve-root option. >> +# Also exercise the synonyms '///' and ''

bug#15970: ignore_value vs (void) [was: [Bug-tar] bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X]

2013-11-27 Thread Eric Blake
On 11/27/2013 10:05 AM, Joerg Schilling wrote: > If you like to stay in an environment that is based on GCC only, you may use > ignore_value(). If you however like to write portable code, you cannot expect > something like ignore_value() to be available. False. Gnulib already takes care of that

bug#15970: ignore_value vs (void) [was: [Bug-tar] bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X]

2013-11-27 Thread Joerg Schilling
Eric Blake wrote: > On 11/27/2013 09:53 AM, Joerg Schilling wrote: > >> The C standard does not document that '(void) write(...)' is required to > >> avoid diagnostics, so I don't see the gcc behavior as a bug (yes, it's > >> annoying behavior, but that doesn't make it incorrect behavior). > > >

bug#15970: ignore_value vs (void) [was: [Bug-tar] bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X]

2013-11-27 Thread Eric Blake
On 11/27/2013 09:53 AM, Joerg Schilling wrote: >> The C standard does not document that '(void) write(...)' is required to >> avoid diagnostics, so I don't see the gcc behavior as a bug (yes, it's >> annoying behavior, but that doesn't make it incorrect behavior). > > Well, there is a more than 30

bug#15970: ignore_value vs (void) [was: [Bug-tar] bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X]

2013-11-27 Thread Joerg Schilling
Eric Blake wrote: > On 11/27/2013 09:30 AM, Joerg Schilling wrote: > >>> Are you using "ignore_value" because of the gcc bug that ignores the > >>> official > >>> method to tell that the return code is ignored intentionally: > >>> > >>> (void) write(fd, buf, len); > > The C standard does not d

bug#15970: ignore_value vs (void) [was: [Bug-tar] bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X]

2013-11-27 Thread Eric Blake
On 11/27/2013 09:30 AM, Joerg Schilling wrote: >>> Are you using "ignore_value" because of the gcc bug that ignores the >>> official >>> method to tell that the return code is ignored intentionally: >>> >>> (void) write(fd, buf, len); The C standard does not document that '(void) write(...)'

bug#15970: [Bug-tar] bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X

2013-11-27 Thread Joerg Schilling
Pádraig Brady wrote: > On 11/26/2013 10:53 AM, Joerg Schilling wrote: > > > > Are you using "ignore_value" because of the gcc bug that ignores the > > official > > method to tell that the return code is ignored intentionally: > > > > (void) write(fd, buf, len); > > Right: > http://git.sv.

bug#15970: [Bug-tar] Crash in gettext() after fork() on Mac OS X

2013-11-27 Thread Pádraig Brady
On 11/27/2013 02:38 PM, Jack Howarth wrote: > On Wed, Nov 27, 2013 at 01:25:52AM +, Pádraig Brady wrote: >> On 11/26/2013 10:09 PM, Jim Meyering wrote: >>> Hi Pádraig, >>> >>> Thanks for dealing with that. Your patch looks correct. >>> Did you consider using inttostr in place of that first part

bug#15970: [Bug-tar] Crash in gettext() after fork() on Mac OS X

2013-11-27 Thread Jack Howarth
On Wed, Nov 27, 2013 at 01:25:52AM +, Pádraig Brady wrote: > On 11/26/2013 10:09 PM, Jim Meyering wrote: > > Hi Pádraig, > > > > Thanks for dealing with that. Your patch looks correct. > > Did you consider using inttostr in place of that first part of > > async_safe_error? > > Paul suggested