Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-04-02 Thread Vladimir Merzliakov
The attached patch should solve all of these, I hope. Please could you test it. (I have also attached the regenerated configure files for you). I build and install binutils with patches without any problems! Thank you for fixing getopt problem at FreeBSD. Vladimir __

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-31 Thread Vladimir Merzliakov
OK - please try the attached patch for the GAS build problems. (It is basically the same as the one for binutils). If that works I can send you one for LD as well. Binutils with patches build pass gas part and terminated now at (i miss this warning in prev. e-mail, sorry): In file included from

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-31 Thread Nick Clifton
Hi Vladimir, addr2line.c compile with addition patch Great - in which case I have checked both patches in together with this ChangeLog entry: binutils/ChangeLog 2005-03-31 Nick Clifton <[EMAIL PROTECTED]> * configure.in: Add a check for providing a prototype for getopt() which

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-29 Thread Vladimir Merzliakov
And then configure part work fine at FreeBSD but binutils/config.h not #included in addr2line.c Hmm, but it does #include "bucomm.h" which then #include's "config.h". It turns out however that it incldues it too late (ie after "bfd.h"). So please try the attached patch (in addition to my previous p

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-29 Thread Nick Clifton
Hi Vladimir, Results of testting: And then configure part work fine at FreeBSD but binutils/config.h not #included in addr2line.c Hmm, but it does #include "bucomm.h" which then #include's "config.h". It turns out however that it incldues it too late (ie after "bfd.h"). So please try the attache

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-24 Thread Vladimir Merzliakov
Please could you try the patch below which *might* work. I have not tested it very much. You ought to regenerate the configure files after applying this patch but in case this is a problem for you I am attaching a compressed diff for them as well. Results of testting: checking for an known getop

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-24 Thread Nick Clifton
Hi Vladimir, ian> Sorry, this patch is not OK. It will just lead us down the path of ian> increasing the #ifdef over and over again. The question here is why ian> HAVE_DECL_GETOPT is not defined. ian> ian> Looking at gcc, I would say that the binutils configure.in file should ian> do the equivale

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-24 Thread Vladimir Merzliakov
Well that should be long enough. I think that the patch is OK, but there are two problems: 1. The patch should be submitted to the gcc project, since they control the getopt.h header file. 2. You need to include a ChangeLog entry with your patch. Patch rejected by libiberty maintainer (

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-24 Thread Vladimir Merzliakov
Well that should be long enough. I think that the patch is OK, but there are two problems: 1. The patch should be submitted to the gcc project, since they control the getopt.h header file. 2. You need to include a ChangeLog entry with your patch. I send proposed patch with ChangeLog entr

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-23 Thread Marcel Moolenaar
On Wednesday 23 March 2005 07:07 am, Nick Clifton wrote: > Also, I am not sure if the FreeBSD system uses the GNU C library. > I guess that it probably does, but if not then you ought to update > the comment describing when the full getopt() prototype is used. FYI: No, FreeBSD doesn't use the GNU

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-23 Thread Nick Clifton
Hi Vladimirm, Attached patch fix warning. Thanks. I don't known is proposed patch correct. But I check FreeBSD CVS and found that starting from 1994 FreeBSD have getopt prototype same as in binutils getopt.h. Well that should be long enough. I think that the patch is OK, but there are two proble

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-22 Thread Vladimir Merzliakov
In file included from /usr/home/wanderer/pkg/build/binutils/src/src/binutils/size.c:34: /usr/home/wanderer/pkg/build/binutils/src/src/binutils/../include/getopt.h:116: warning: function declaration isn't a prototype I see this warning long time (>2 years) already when i build binutils at FreeBS

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-22 Thread Nick Clifton
Hi Vladimir, After patch http://sourceware.org/ml/binutils-cvs/2005-03/msg00191.html binutils build broken at FreeBSD 5.3 Build terminate with message: In file included from /usr/home/wanderer/pkg/build/binutils/src/src/binutils/size.c:34: /usr/home/wanderer/pkg/build/binutils/src/src/binutils/.

Binutils build broken at FreeBSD 5.3 after -Werror enabling

2005-03-18 Thread Vladimir Merzliakov
After patch http://sourceware.org/ml/binutils-cvs/2005-03/msg00191.html binutils build broken at FreeBSD 5.3 Build terminate with message: In file included from /usr/home/wanderer/pkg/build/binutils/src/src/binutils/size.c:34: /usr/home/wanderer/pkg/build/binutils/src/src/binutils/../include/get