Re: [PATCH] don't crash on overflow on hppa64

2011-07-28 Thread Nick Clifton
Hi Mikulas, 1. offset is 64-bit, but 32-bit format "%lx" is used. This causes parameters mismatch 2. eh may be NULL. If it is NULL, I changed the code to print "unknown". Someone who understands the code better can change it to print something more descriptive 3. returning bfd_reloc_notsupported

Re: [PATCH] don't crash on overflow on hppa64

2011-07-27 Thread Joseph S. Myers
On Wed, 27 Jul 2011, Mikulas Patocka wrote: > @@ -3296,13 +3296,13 @@ elf_hppa_final_link_relocate (Elf_Intern > && value + addend + max_branch_offset >= 2*max_branch_offset) > { > (*_bfd_error_handler) > - (_("%B(%A+0x%lx): cannot reach %s"), > + (_

[PATCH] don't crash on overflow on hppa64

2011-07-27 Thread Mikulas Patocka
Hi This patch fixes crash that happens if we build too big linux kernel so that offsets overflow. There are several bugs in elf64-hppa.c: 1. offset is 64-bit, but 32-bit format "%lx" is used. This causes parameters mismatch 2. eh may be NULL. If it is NULL, I changed the code to print "unknown"