--- Additional Comments From nickc at redhat dot com 2008-05-21 12:04
---
Hi Andre,
Thanks for the additional patch. I have now applied it to the sources.
Cheers
Nick
--
What|Removed |Added
-
--- Additional Comments From andrejoh at gmail dot com 2008-04-15 20:12
---
Created an attachment (id=2697)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=2697&action=view)
Leak fixing for bfd_find_nearest_line in DWARF2
--
http://sourceware.org/bugzilla/show_bug.cgi?id=868
--- Additional Comments From nickc at redhat dot com 2008-04-15 14:05
---
Subject: Re: bfd leaks memory in several places
Hi Andre,
> Nick, I'm not sure reverting the cleanup is correct. At least in binutils
> 2.18, the function concat_filename uses bfd_malloc, which again uses mall
Hi Andre,
Nick, I'm not sure reverting the cleanup is correct. At least in binutils
2.18, the function concat_filename uses bfd_malloc, which again uses malloc.
Hmm, that is a fair point.
Running with a change similar to the one in comment #14 plus freeing
caller_file removes the leaks I
--- Additional Comments From andrejoh at gmail dot com 2008-04-10 10:15
---
That should of course be comment #4.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=868
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who
--- Additional Comments From andrejoh at gmail dot com 2008-04-10 09:08
---
Nick, I'm not sure reverting the cleanup is correct. At least in binutils
2.18, the function concat_filename uses bfd_malloc, which again uses malloc.
As far as I can see, it does the same in current CVS.
I
--- Additional Comments From nickc at redhat dot com 2008-02-25 10:23
---
Hi Alan,
> What is the point of the patch in comment #1? If we fail a realloc we are
> shortly going to exit with an error.
Not necessarily. It is possible whatever was being attempted at the time will
be abort
--- Additional Comments From amodra at bigpond dot net dot au 2008-02-23
01:47 ---
What is the point of the patch in comment #1? If we fail a realloc we are
shortly going to exit with an error. Who cares if we haven't freed all memory?
--
http://sourceware.org/bugzilla/show_bug.cgi
--- Additional Comments From nickc at redhat dot com 2008-02-22 15:26
---
Hi Diogo,
I have just realised that my dwarf2.c patch was completely bogus. There is no
memory leak because the routines are using bfd_alloc and bfd_zalloc, which uses
an objstack. The memory is freed later on
--- Additional Comments From nickc at redhat dot com 2008-02-20 17:44
---
Hi John,
I have checked in the patch to implement and use bfd_realloc_or_free.
I am going to close this issue for, since the specific problem of using
bfd_realloc has now been addressed, but it can be reopene
--- Additional Comments From nickc at redhat dot com 2008-02-20 17:42
---
Created an attachment (id=2278)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=2278&action=view)
Implement and use bfd_realloc_or_free
--
http://sourceware.org/bugzilla/show_bug.cgi?id=868
--- You
--- Additional Comments From nickc at redhat dot com 2008-02-20 15:56
---
Hi Diogo,
You are correct, the dwarf2.c code does not clean up its memory usage very
well. The patch you suggested is a start, but it does not go far enough. For
example it does not free the varinfo and funcin
--- Additional Comments From nickc at redhat dot com 2008-02-20 15:53
---
Created an attachment (id=2276)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=2276&action=view)
Improve memory release function in dwarf2.c
--
http://sourceware.org/bugzilla/show_bug.cgi?id=868
-
--- Additional Comments From diogo at kraemer dot eng dot br 2008-02-14
18:13 ---
I'm using the utiliy from http://www.plunk.org/~hatch/goodies/backtracefilt.C
to translate de stack back trace into a readable trace.
It says in its comment on line 1044 that bfd_find_nearest_line (in
bin
--- Additional Comments From levon at movementarian dot org 2006-03-28
13:36 ---
A memory leak is not an "enhancement", it's a bug.
--
What|Removed |Added
Severity
--
What|Removed |Added
Severity|normal |enhancement
http://sourceware.org/bugzilla/show_bug.cgi?id=868
--- You are receiving this mail because: -
--
What|Removed |Added
CC||basic at mozdev dot org
http://sourceware.org/bugzilla/show_bug.cgi?id=868
--- You are receiving this mai
--- Additional Comments From levon at movementarian dot org 2005-05-05
14:44 ---
Subject: Re: bfd leaks memory in several places
On Thu, May 05, 2005 at 02:36:01PM -, nickc at redhat dot com wrote:
> The least intrusive way to resolve most of these would be to provide a
> new fun
--- Additional Comments From nickc at redhat dot com 2005-05-05 14:35
---
Subject: Re: New: bfd leaks memory in several places
Hi John,
> bfd has several memory leaks. I'm fixing the ones in dwarf2.c, but a simple
> grep
> for 'bfd_realloc' shows several obvious leaks on failure:
>
19 matches
Mail list logo
