[Bug binutils/5713] strings: use '-0' as option will meet infinite loop

--- Additional Comments From chul at cn dot fujitsu dot com 2008-02-18 01:14 --- Hi, I think it's OK now. -- http://sourceware.org/bugzilla/show_bug.cgi?id=5713 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who i

[Bug binutils/5713] strings: use '-0' as option will meet infinite loop

--- Additional Comments From nickc at redhat dot com 2008-02-15 10:25 --- Hi Chu, Thanks for pointing that out. In fact the integer_arg() function is completely redundant as the C library function strtoul() does everything that is needed. So I have applied a revised version of the p

[Bug binutils/5713] strings: use '-0' as option will meet infinite loop

--- Additional Comments From nickc at redhat dot com 2008-02-15 10:23 --- Created an attachment (id=2269) --> (http://sourceware.org/bugzilla/attachment.cgi?id=2269&action=view) Revised patch which removes integer_arg() -- What|Removed |Added --

[Bug binutils/5713] strings: use '-0' as option will meet infinite loop

--- Additional Comments From chul at cn dot fujitsu dot com 2008-02-15 09:44 --- Created an attachment (id=2268) --> (http://sourceware.org/bugzilla/attachment.cgi?id=2268&action=view) Used for "-n num" when num is hexadecimal or octal -- http://sourceware.org/bugzilla/show_bug.cgi

[Bug binutils/5713] strings: use '-0' as option will meet infinite loop

--- Additional Comments From chul at cn dot fujitsu dot com 2008-02-15 09:41 --- Hi, I have tried it out. It' Ok now. And I found if the "num" is the hex number in "-n num" option , the result is a little strange and 0xA can't be recognized. So I made a patch for it. Hope it is us

[Bug binutils/5713] strings: use '-0' as option will meet infinite loop

--- Additional Comments From nickc at redhat dot com 2008-02-14 12:22 --- Hi Chu, I agree, strings should be consistent with the error messages that it generates. There is also another problem, in that currently: strings -1 -2 will print all the strings of 12 bytes of more in r

[Bug binutils/5713] strings: use '-0' as option will meet infinite loop

--- Additional Comments From nickc at redhat dot com 2008-02-14 12:20 --- Created an attachment (id=2262) --> (http://sourceware.org/bugzilla/attachment.cgi?id=2262&action=view) Improve handlign of - command line option -- http://sourceware.org/bugzilla/show_bug.cgi?id=5713 --

[Bug binutils/5713] strings: use '-0' as option will meet infinite loop

--- Additional Comments From chul at cn dot fujitsu dot com 2008-02-13 00:52 --- (In reply to comment #2) > Fixed by > http://sourceware.org/ml/binutils/2008-02/msg00067.html I found using "strings -n 0 file" or "strings --bytes=0 file", "invalid number 0" will be reported. So "string

[Bug binutils/5713] strings: use '-0' as option will meet infinite loop

--- Additional Comments From hjl dot tools at gmail dot com 2008-02-08 20:59 --- Fixed by http://sourceware.org/ml/binutils/2008-02/msg00067.html -- What|Removed |Added

[Bug binutils/5713] strings: use '-0' as option will meet infinite loop

--- Additional Comments From chul at cn dot fujitsu dot com 2008-02-02 02:46 --- Created an attachment (id=2227) --> (http://sourceware.org/bugzilla/attachment.cgi?id=2227&action=view) After applying this patch, when use "strings -0 file", "invalid number 0" will be reported. -- ht