https://sourceware.org/bugzilla/show_bug.cgi?id=29075
Martin Liska changed:
What|Removed |Added
See Also||https://sourceware.org/bugz
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
Aaron Merey changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #33 from Martin Liska ---
Thanks Aaron, I can confirm the patch works for me!
--
You are receiving this mail because:
You are on the CC list for the bug.
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #32 from Nick Clifton ---
(In reply to Aaron Merey from comment #31)
> Created attachment 14331 [details]
> 0001-objdump-S-should-trigger-search-for-separate-debugin.patch
Patch approved - please apply.
Cheers
Nick
--
You are
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
Aaron Merey changed:
What|Removed |Added
Attachment #14311|0 |1
is obsolete|
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #30 from Aaron Merey ---
(In reply to Martin Liska from comment #29)
> Thanks for the implementation. However, I think one piece is missing and it's
> find_separate_debug and find_separate_debug rely on fact the debugginfo is
> pre
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
Martin Liska changed:
What|Removed |Added
Resolution|FIXED |---
Status|RESOLVED
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
Aaron Merey changed:
What|Removed |Added
Resolution|--- |FIXED
Status|ASSIGNED
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #27 from Nick Clifton ---
(In reply to Aaron Merey from comment #26)
Hi Aaron,
> Created attachment 14311 [details]
> 0001-bfd-Add-bfd_find_nearest_line_with_alt.patch
> Created attachment 14312 [details]
> 0002-Add-debuginfod-su
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #26 from Aaron Merey ---
Created attachment 14312
--> https://sourceware.org/bugzilla/attachment.cgi?id=14312&action=edit
0002-Add-debuginfod-support-for-objdump-S.patch
Adding a second attachment since I split up the patch into
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
Aaron Merey changed:
What|Removed |Added
Attachment #14097|0 |1
is obsolete|
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #24 from Nick Clifton ---
(In reply to Aaron Merey from comment #22)
Hi Aaron,
> Created attachment 14299 [details]
Further testing has revealed another problem: The patched objdump.c calls
bfd_elf_find_nearest_line_with_alt() e
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #23 from Nick Clifton ---
(In reply to Aaron Merey from comment #22)
Hi Aaron,
> I've attached an updated patch. I took Nick's original patch and added a
> function _bfd_elf_find_nearest_line_with_alt to bfd/elf.c.
The patch look
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #22 from Aaron Merey ---
Created attachment 14299
--> https://sourceware.org/bugzilla/attachment.cgi?id=14299&action=edit
Revised Patch
I've attached an updated patch. I took Nick's original patch and added a
function _bfd_elf_f
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #21 from Aaron Merey ---
(In reply to Nick Clifton from comment #20)
> (In reply to Aaron Merey from comment #19)
> > Passing
> > the bfd object of the separate debuginfo instead of the bfd of the parent
> > file seems to work unle
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #20 from Nick Clifton ---
(In reply to Aaron Merey from comment #19)
Hi Aaron,
> Passing
> the bfd object of the separate debuginfo instead of the bfd of the parent
> file seems to work unless a .gnu_debugaltlink file exists.
Wha
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #19 from Aaron Merey ---
(In reply to Nick Clifton from comment #18)
> > and try to keep any additional debuginfod support
> > contained in objdump.
>
> That would be my preference too. If possible it might be best to put most of
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #18 from Nick Clifton ---
Hi Aaron,
>> The other issue is finding the time to actually write this code. If someone
>> is volunteering then I would be very happy to leave it to them ... :-)
>
> I'll take a look at this
Thanks!
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
Aaron Merey changed:
What|Removed |Added
Assignee|nickc at redhat dot com|amerey at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #16 from Frank Ch. Eigler ---
Sorry about the confusion, it was mine.
Yeah, libbfd.so's dependencies are small, adding debuginfod (=> libcurl) would
make it rather larger. OTOH elfutils-libs are on systems already, so the
depende
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #15 from Nick Clifton ---
I may be confused (again) but I think that there are two problems here.
1. The debug information necessary to convert an address into a source code
location is held by the debuginfod system (either locall
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #14 from Frank Ch. Eigler ---
Could objdump preemptively call some debuginfod-calling function - any one - in
order to prefetch debuginfo for options like -S?
--
You are receiving this mail because:
You are on the CC list for the
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #13 from Mark Wielaard ---
(In reply to Martin Liska from comment #12)
> > So in order for -S to work, we either have to add debuginfod support to the
> > BFD library or else add a new find_nearest_line() type function to
> > binut
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #12 from Martin Liska ---
> So in order for -S to work, we either have to add debuginfod support to the
> BFD library or else add a new find_nearest_line() type function to
> binutils/dwarf.c. I wonder which would be the best appr
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
Nick Clifton changed:
What|Removed |Added
Status|UNCONFIRMED |ASSIGNED
Assignee|unassigned
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #10 from Martin Liska ---
>
> Please could you try out this proposed patch ?
>
Thank you for the patch! But it does not work, when I debug it I can confirm
show_line is called but there's early exit in:
if (! bfd_find_nearest
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #9 from Nick Clifton ---
Created attachment 14097
--> https://sourceware.org/bugzilla/attachment.cgi?id=14097&action=edit
Proposed Patch
Hi Martin (or anyone ...)
Please could you try out this proposed patch ?
I think that
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #8 from Frank Ch. Eigler ---
(maybe nickc's confusion was in thinking that the debuginfo download would
include sources, as if they were colocated in an rpm, but it doesn't!)
--
You are receiving this mail because:
You are on the
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #7 from Mark Wielaard ---
So more specifically whenever objdump -S cannot find the sources it can try to
call debuginfod_find_source () just like it tries to find the original
debuginfo through debuginfod_find_debuginfo. See the do
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #6 from Martin Liska ---
Sure, let's assume you have a system that has set DEBUGINFOD_URLS variable (in
my case DEBUGINFOD_URLS=https://debuginfod.opensuse.org/).
Let's clear debuginfod cache:
$ rm -rf ~/.cache/debuginfod_client/
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #5 from Nick Clifton ---
(In reply to Martin Liska from comment #4)
> > or that "running objdump -S does not trigger a debuginfod lookup" ?
OK - that makes sense. Please can you upload a test case that I can use to
investigate t
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #4 from Martin Liska ---
Sorry for not being clear enough.
> or that "running objdump -S does not trigger a debuginfod lookup" ?
This one is the case. Note debuginfod provides source files via the following
HTTP API:
$ man debug
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #3 from Nick Clifton ---
(In reply to Frank Ch. Eigler from comment #2)
> It does load the debuginfo files, but not the sources (objdump -S).
So is the bug: "debuginfod does not provide sources"
or is it that: "the debug informa
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
Nick Clifton changed:
What|Removed |Added
CC||nickc at redhat dot com
--- Comment #1
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
--- Comment #2 from Frank Ch. Eigler ---
It does load the debuginfo files, but not the sources (objdump -S).
--
You are receiving this mail because:
You are on the CC list for the bug.
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
Mark Wielaard changed:
What|Removed |Added
CC|mjw at fedoraproject dot org |mark at klomp dot org
--
You
https://sourceware.org/bugzilla/show_bug.cgi?id=29075
Martin Liska changed:
What|Removed |Added
CC||fche at redhat dot com,
37 matches
Mail list logo
