Re: [RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error?

2011-03-10 Thread Michael Snyder
Michael Snyder wrote: If rel-r_type is equal to ARRA_SIZE, it will overflow the array. What say you? Ping? ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils

Re: [RFA] elf64-x86-64.c, elf_x86_64_relocate_section, remove dead code.

2011-03-03 Thread Michael Snyder
Alan Modra wrote: On Thu, Mar 03, 2011 at 12:27:02PM -0800, Michael Snyder wrote: * elf64-x86-64.c (elf_x86_64_relocate_section): Remove dead code. OK. Committed, thanks. ___ bug-binutils mailing list bug-binutils@gnu.org http

Re: [RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error?

2011-03-03 Thread Michael Snyder
Alan Modra wrote: On Thu, Mar 03, 2011 at 11:12:34AM -0800, Michael Snyder wrote: * coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error. OK. committed, thanks. ___ bug-binutils mailing list bug-binutils@gnu.org http

Re: [RFA] aoutx.h, aout_link_write_other_symbol, missing break statement (?)

2011-03-03 Thread Michael Snyder
Alan Modra wrote: On Thu, Mar 03, 2011 at 10:32:18AM -0800, Michael Snyder wrote: * aoutx.h (aout_link_write_other_symbol): Missing break statement. OK. Committed, thanks. ___ bug-binutils mailing list bug-binutils@gnu.org http

Re: [RFA] aoutx.h, aout_final_link, use sizeof int

2011-03-03 Thread Michael Snyder
Alan Modra wrote: On Thu, Mar 03, 2011 at 10:25:31AM -0800, Michael Snyder wrote: 2011-03-03 Michael Snyder * aoutx.txt (aout_final_link): Use sizeof int not sizeof int*. aoutx.h. OK. Committed, thanks. ___ bug-binutils mailing list

Re: [RFA] archive.c, _bfd_slurp_extended_name_table, Fail if bfd_seek fails.

2011-03-03 Thread Michael Snyder
Alan Modra wrote: On Thu, Mar 03, 2011 at 11:01:11AM -0800, Michael Snyder wrote: 2011-03-03 Michael Snyder * archive.c (_bfd_slurp_extended_name_table): Fail if bfd_seek fails. OK. Thanks, committed. ___ bug-binutils mailing list

Re: [RFA] bfd/dwarf2.c/scan_unit_for_symbols, fix a memory leak.

2011-03-03 Thread Michael Snyder
Alan Modra wrote: On Thu, Mar 03, 2011 at 12:12:52PM -0800, Michael Snyder wrote: 2011-03-03 Michael Snyder * dwarf2.c (scan_unit_for_symbols): Stop memory leak. OK. Thanks for the review. Committed. ___ bug-binutils mailing list

Re: [RFA] archive.c, bsd_write_armap, fail if stat fails

2011-03-03 Thread Michael Snyder
Alan Modra wrote: On Thu, Mar 03, 2011 at 10:46:09AM -0800, Michael Snyder wrote: * archive.c (bsd_write_armap): Fail if stat fails. I think it would be better to just set the timestamp to zero if stat fails. There is precedent for this, eg. opncls.c:_maybe_make_executable. Err

[RFA] elf64-x86-64.c, elf_x86_64_relocate_section, remove dead code.

2011-03-03 Thread Michael Snyder
Within this case statement, the conditional cannot be true. OK? 2011-03-03 Michael Snyder * elf64-x86-64.c (elf_x86_64_relocate_section): Remove dead code. Index: elf64-x86-64.c === RCS file: /cvs/src/src/bfd/elf64-x86

[RFA] bfd/dwarf2.c/scan_unit_for_symbols, fix a memory leak.

2011-03-03 Thread Michael Snyder
ok? 2011-03-03 Michael Snyder * dwarf2.c (scan_unit_for_symbols): Stop memory leak. Index: dwarf2.c === RCS file: /cvs/src/src/bfd/dwarf2.c,v retrieving revision 1.138 diff -u -p -u -p -r1.138 dwarf2.c --- dwarf2.c

Re: [RFA] peXXigen.c, _bfd_XXi_swap_aux_in, wrong size used in memcpy.

2011-03-03 Thread Michael Snyder
Pedro Alves wrote: On Thursday 03 March 2011 18:09:04, Michael Snyder wrote: 2011-03-03 Michael Snyder * peXXigen.c (_bfd_XXi_swap_aux_in): Use E_FILNMNEN instead of FILENMLEN, otherwise will overwrite array. Doesn't pe.h define them both the same? Hmm, yes... Cov

[RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error?

2011-03-03 Thread Michael Snyder
If rel-r_type is equal to ARRA_SIZE, it will overflow the array. What say you? 2011-03-03 Michael Snyder * coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error. Index: coff-x86_64.c === RCS file: /cvs/src/src/bfd

[RFA] archive.c, _bfd_slurp_extended_name_table, Fail if bfd_seek fails.

2011-03-03 Thread Michael Snyder
OK? 2011-03-03 Michael Snyder * archive.c (_bfd_slurp_extended_name_table): Fail if bfd_seek fails. Index: archive.c === RCS file: /cvs/src/src/bfd/archive.c,v retrieving revision 1.72 diff -u -p -u -p -r1.72 archive.c

[RFA] archive.c, bsd_write_armap, fail if stat fails

2011-03-03 Thread Michael Snyder
Perhaps nit-picky -- what do you think? 2011-03-03 Michael Snyder * archive.c (bsd_write_armap): Fail if stat fails. Index: archive.c === RCS file: /cvs/src/src/bfd/archive.c,v retrieving revision 1.72 diff -u -p -u -p

[RFA] aoutx.h, aout_link_write_other_symbol, missing break statement (?)

2011-03-03 Thread Michael Snyder
Hey Nick, Should there be a break here? Or a "FALLTHROUGH" comment? Looks like a break to me... Cheers, Michael 2011-03-03 Michael Snyder * aoutx.h (aout_link_write_other_symbol): Missing break statement. Inde

[RFA] aoutx.h, aout_final_link, use sizeof int

2011-03-03 Thread Michael Snyder
Nick, Seems to me it should be sizeof int, not int*. What do you think? Michael 2011-03-03 Michael Snyder * aoutx.txt (aout_final_link): Use sizeof int not sizeof int*. Index: aoutx.h === RCS file: /cvs/src/src/bfd

[RFA] peXXigen.c, _bfd_XXi_swap_aux_in, wrong size used in memcpy.

2011-03-03 Thread Michael Snyder
OK Nick? 2011-03-03 Michael Snyder * peXXigen.c (_bfd_XXi_swap_aux_in): Use E_FILNMNEN instead of FILENMLEN, otherwise will overwrite array. Index: peXXigen.c === RCS file: /cvs/src/src/bfd/peXXigen.c,v

objdump on very large files

2011-01-28 Thread Michael Snyder
lx 2**%u", (unsigned long) section->filepos, bfd_get_section_alignment (abfd, section)); Is there a way to get the total file size here, and if it is greater than 4gig, to make this field wider? I realize that it will then be greater than 80 chars... Cheers, M