--- Additional Comments From cvs-commit at gcc dot gnu dot org 2010-04-21
18:10 ---
Subject: Bug 11509
CVSROOT:/cvs/src
Module name:src
Changes by: h...@sourceware.org 2010-04-21 18:09:53
Modified files:
gas: ChangeLog read.c
gas/config
--- Additional Comments From dzidzitop at lavabit dot com 2010-04-21 12:46
---
By the way
! && offset + sec_vma >= file_addr
! && offset + sec_vma - file_addr <= maxdiff)
This code from your patch. It could be re-written to store offset + sec_vma -
file_addr into
--- Additional Comments From dzidzitop at lavabit dot com 2010-04-21 12:36
---
Good job Nick. This works for me, at least under Ubuntu. Thanks.
--
What|Removed |Added
--- Additional Comments From nickc at redhat dot com 2010-04-21 07:01
---
Created an attachment (id=4744)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=4744&action=view)
Correct patch: Adds section address to filename symbols' values
--
What|Removed
the bug is in the file: binutils-2.20/gprof/corefile.c
in the function: static int num_of_syms_in (FILE * f)
line 520: while (!feof (f) && fgets (buf, sizeof (buf), f))
this is wrong! because the type of buf is char *, so sizeof(buf)=4
this would cause segmentation fault when use --externa
--- Additional Comments From nickc at redhat dot com 2010-04-21 07:02
---
Hi dzidzitop,
Oops - sorry about that. I uploaded the wrong patch file by mistake. Please
try out the new one instead. With this patch applied, using your test case I
get:
% addr2line -e bbb.exe 0x4013c0
