Re: Remaining memory corruption bugs in readline

2017-06-09 Thread Eduardo Bustamante
On Fri, Jun 9, 2017 at 4:59 PM, Chet Ramey wrote: [...] > It's an off-by-one error. Thank you! Do you have a patch? I want to run the patched version against the corpus of crashing inputs that I have to see if there are any remaining.

Re: Remaining memory corruption bugs in readline

2017-06-09 Thread Chet Ramey
On 6/8/17 11:34 AM, Chet Ramey wrote: > On 6/8/17 11:09 AM, dualbus wrote: >> On Fri, Jun 02, 2017 at 12:07:34AM -0500, dualbus wrote: >> [...] >>> #1 _rl_get_char_len / update_line >> [...] >>> ==5781==ERROR: AddressSanitizer: heap-buffer-overflow on address >>> 0x6190cc80 at pc 0x7f400d00b

Re: Remaining memory corruption bugs in readline

2017-06-08 Thread Chet Ramey
On 6/8/17 11:09 AM, dualbus wrote: > On Fri, Jun 02, 2017 at 12:07:34AM -0500, dualbus wrote: > [...] >> #1 _rl_get_char_len / update_line > [...] >> ==5781==ERROR: AddressSanitizer: heap-buffer-overflow on address >> 0x6190cc80 at pc 0x7f400d00b063 bp 0x7ffcbce72250 sp 0x7ffcbce71a00 >> R

Re: Remaining memory corruption bugs in readline

2017-06-08 Thread dualbus
On Fri, Jun 02, 2017 at 12:07:34AM -0500, dualbus wrote: [...] > #1 _rl_get_char_len / update_line [...] > ==5781==ERROR: AddressSanitizer: heap-buffer-overflow on address > 0x6190cc80 at pc 0x7f400d00b063 bp 0x7ffcbce72250 sp 0x7ffcbce71a00 > READ of size 851 at 0x6190cc80 thread T0 >

Remaining memory corruption bugs in readline

2017-06-01 Thread dualbus
I'm using the latest `devel' commit as a reference: dualbus@debian:~/src/gnu/bash$ git show -q HEAD commit 1110e30870a8782425067a060d89cc411b014418 Author: Chet Ramey Date: Wed May 31 15:53:02 2017 -0400 commit bash-snap-20170531 snapshot Since there are still many memory corruption issue