Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-11-01 Thread Eric Blake
On 11/01/2016 10:41 AM, Tim Ruehsen wrote: >> >> Ouch. This version has O(n^2) complexity when dealing with deep >> hierarchies. GNU Coreutils intentionally prefers using >> openat()/fdopendir() and so on in order to recurse through the tree with >> O(n) complexity instead of O(n^2). > > As Che

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-11-01 Thread Chet Ramey
On 11/1/16 11:41 AM, Tim Ruehsen wrote: >>> if ((dir = opendir(dirname))) >>> >>> { >>> >>> while ((dp = readdir(dir))) >> >> Ouch. This version has O(n^2) complexity when dealing with deep >> hierarchies. GNU Coreutils intentionally prefers using >> openat()/fdopendir() and

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-11-01 Thread Tim Ruehsen
On Monday, October 31, 2016 4:44:21 PM CET Eric Blake wrote: > On 10/31/2016 04:14 PM, Chet Ramey wrote: > >> > Nice, thanks for the modifications. > > > > Here's the modified version. > > > > Chet > > -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars > > longa, vita brevis'' -

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-10-31 Thread Chet Ramey
On 10/31/16 5:44 PM, Eric Blake wrote: > On 10/31/2016 04:14 PM, Chet Ramey wrote: > Nice, thanks for the modifications. >> Here's the modified version. >> >> Chet >> -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars >> longa, vita brevis'' - Hippocrates Chet Ramey, UTech,

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-10-31 Thread Eric Blake
On 10/31/2016 04:14 PM, Chet Ramey wrote: >> > Nice, thanks for the modifications. > Here's the modified version. > > Chet > -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars > longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRU c...@case.edu > http://cnswww.cns.cwru.edu

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-10-31 Thread Chet Ramey
On 10/31/16 4:40 PM, Tim Rühsen wrote: > On Montag, 31. Oktober 2016 13:09:15 CET Chet Ramey wrote: >> On 10/31/16 7:59 AM, Tim Ruehsen wrote: >>> Added the 'rm' command to examples/loadables. >>> >>> It accepts -r and -f. >> >> Thanks for the submission. I modified it pretty heavily, and it will

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-10-31 Thread Tim Rühsen
On Montag, 31. Oktober 2016 13:09:15 CET Chet Ramey wrote: > On 10/31/16 7:59 AM, Tim Ruehsen wrote: > > Added the 'rm' command to examples/loadables. > > > > It accepts -r and -f. > > Thanks for the submission. I modified it pretty heavily, and it will be > in the next release of bash and the n

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-10-31 Thread Chet Ramey
On 10/31/16 7:59 AM, Tim Ruehsen wrote: > Added the 'rm' command to examples/loadables. > > It accepts -r and -f. Thanks for the submission. I modified it pretty heavily, and it will be in the next release of bash and the next devel snapshot. Chet -- ``The lyf so short, the craft so long to l

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-10-31 Thread Cedric Blancher
Some comments, since ksh93 already has the same (POSIX utilities as builtins): 1. All builtin code should be reentrant (you'll get to that point at *least* with find(1) -exec, and at that point it will bite you into your *ARSE*) 2. All builtin code must not use global variables or any global resour

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-10-31 Thread Tim Ruehsen
On Monday, October 31, 2016 7:08:51 AM CET John McKown wrote: > On Mon, Oct 31, 2016 at 6:59 AM, Tim Ruehsen wrote: > > Added the 'rm' command to examples/loadables. > > > > It accepts -r and -f. > > Enable it with 'enable -f /examples/loadables/rm rm'. > > > > Tested on wget configure script wh

Re: [PATCH] Add-rm-rf-as-examples-loadables-rm.c

2016-10-31 Thread John McKown
On Mon, Oct 31, 2016 at 6:59 AM, Tim Ruehsen wrote: > Added the 'rm' command to examples/loadables. > > It accepts -r and -f. > Enable it with 'enable -f /examples/loadables/rm rm'. > > Tested on wget configure script where it increases overall execution time > by > 6-7%. > ​Am I understand you