Re: [PATCH] sleep builtin signal handling

2023-07-03 Thread Chet Ramey
On 6/30/23 2:06 AM, Grisha Levit wrote: The sleep builtin currently doesn't do much in the way of signal management, so for example it will return on SIGWINCH, which I think most users will be particularly surprised by the first time they notice a sleep ending early due to a window resize. I loo

Re: [PATCH] sleep builtin signal handling

2023-06-30 Thread Emanuele Torre
On Fri, Jun 30, 2023 at 08:53:16AM +0200, Phi Debian wrote: > Well > > ┌─none:/home/phi > └─PW$ type sleep > sleep is hashed (/usr/bin/sleep) > > So sleep is not a builtin here. This patch is for the sleep loadable builtin example distributed with bash. You can activate it using enable -f "$(

Re: [PATCH] sleep builtin signal handling

2023-06-29 Thread Phi Debian
Well ┌─none:/home/phi └─PW$ type sleep sleep is hashed (/usr/bin/sleep) So sleep is not a builtin here.

Re: [PATCH] sleep builtin signal handling

2023-06-29 Thread Phi Debian
Strange, on BASH_VERSION='5.1.16(1)-release' sleep don't get interupted by SIGWINCH ┌─none:/home/phi └─PW$ trap 'echo $LINES.$COLUMNS' SIGWINCH ┌─none:/home/phi # Resizing window here └─PW$ 79.80 └─PW$ 78.80 └─PW$ 77.80 └─PW$ 76.80 └─PW$ 75.80 ^C ┌─none:/home/phi └─PW$ sleep # Resizing w

[PATCH] sleep builtin signal handling

2023-06-29 Thread Grisha Levit
The sleep builtin currently doesn't do much in the way of signal management, so for example it will return on SIGWINCH, which I think most users will be particularly surprised by the first time they notice a sleep ending early due to a window resize. I looked at adding more signal handling to the