Re: [PATCH] histfile: fix mmap page alignment

2024-10-18 Thread Grisha Levit
On Fri, Oct 18, 2024 at 12:15 PM Chet Ramey wrote: > > On 10/18/24 11:51 AM, Chet Ramey wrote: > > On 10/17/24 8:27 PM, Grisha Levit wrote: > >> The mmap in history_do_write would usually fail when appending because > >> the offset must be a multiple of the page size. > > > > Thanks for the report

Re: [PATCH] histfile: fix mmap page alignment

2024-10-18 Thread Chet Ramey
On 10/18/24 12:19 PM, Grisha Levit wrote: On Fri, Oct 18, 2024 at 12:15 PM Chet Ramey wrote: On 10/18/24 11:51 AM, Chet Ramey wrote: On 10/17/24 8:27 PM, Grisha Levit wrote: The mmap in history_do_write would usually fail when appending because the offset must be a multiple of the page size.

Re: [PATCH] histfile: fix mmap page alignment

2024-10-18 Thread Chet Ramey
On 10/18/24 11:51 AM, Chet Ramey wrote: On 10/17/24 8:27 PM, Grisha Levit wrote: The mmap in history_do_write would usually fail when appending because the offset must be a multiple of the page size. Thanks for the report. Not everyone requires this, but since some systems do, it's better to d

Re: [PATCH] histfile: fix mmap page alignment

2024-10-18 Thread Chet Ramey
On 10/17/24 8:27 PM, Grisha Levit wrote: The mmap in history_do_write would usually fail when appending because the offset must be a multiple of the page size. Thanks for the report. Not everyone requires this, but since some systems do, it's better to do this for portability. -- ``The lyf so

[PATCH] histfile: fix mmap page alignment

2024-10-17 Thread Grisha Levit
The mmap in history_do_write would usually fail when appending because the offset must be a multiple of the page size. --- lib/readline/histfile.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/readline/histfile.c b/lib/readline/histfile.c index a5fb11d2..