Re: Builtin read with -n0 or -N0 (nchars == 0) behaves as a read with no -n/-N argument

2017-06-03 Thread Pranav Deshpande
Is that more advantageous? On Sun, Jun 4, 2017 at 10:46 AM, dualbus wrote: > On Sun, Jun 04, 2017 at 01:45:42AM +0530, Pranav Deshpande wrote: > [...] > > My solution is to change *line 294* of builtins/read.def. > > > > Change > > if (code == 0 || *intval

Re: Builtin read with -n0 or -N0 (nchars == 0) behaves as a read with no -n/-N argument

2017-06-03 Thread Pranav Deshpande
Hello, Sorry for the late reply. My solution is to change *line 294* of builtins/read.def. Change if (code == 0 || *intval < 0* || intval != (int)intval) to if (code == 0 || i*ntval <= 0* || intval != (int)intval) Command: ./bash -c 'read -n0 <<< "abc";declare -p REPLY' Output: ./bash: line

Re: Builtin read with -n0 or -N0 (nchars == 0) behaves as a read with no -n/-N argument

2017-05-31 Thread Pranav Deshpande
Thank you. I am travelling now and will look at it in 2 days. Regards, Pranav On May 31, 2017 7:48 PM, "Chet Ramey" wrote: > On 5/23/17 11:33 AM, Eduardo Bustamante wrote: > > (I think this is a good problem for Pranav to tackle if you consider > > this to be a bug, Chet). > > Thanks. Another o

Re: Builtin history -r does not work with named pipes (i.e. GNU readline's histfile.c read_history_range)

2017-05-29 Thread Pranav Deshpande
So I can't take up this one? Regards, Pranav On May 30, 2017 2:35 AM, "Chet Ramey" wrote: > On 5/29/17 4:40 PM, dualbus wrote: > > On Mon, May 29, 2017 at 04:17:16PM -0400, Chet Ramey wrote: > > [...] > >> So the bug is that readline doesn't print an error message if the > history > >> file isn

Re: Interested in contributing to Bash

2017-05-23 Thread Pranav Deshpande
Thank you! I will be reading it now. What do you think of the 'bugs' Eduardo mentioned? Regards, Pranav. On Wed, May 24, 2017 at 12:09 AM, Chet Ramey wrote: > On 5/21/17 11:53 AM, Eduardo Bustamante wrote: > > On Sun, May 21, 2017 at 5:44 AM, Pranav Deshpande > >

Re: History Feature issue

2017-05-22 Thread Pranav Deshpande
cool builtins could be a way to contribute to bash. > > At least that's what I do ( https://github.com/pgas ), even though I have > no real ambition doing this :D > > Pierre > > On Mon, May 22, 2017 at 1:27 PM, Pranav Deshpande < > deshpande.v.pra...@gmail.com> wrote:

Re: History Feature issue

2017-05-22 Thread Pranav Deshpande
Thank you. It seems that there is no read to implement this feature. Could you suggest me some bug so that I can get started? Something which is simple for a beginner? Regards, Pranav. On Mon, May 22, 2017 at 3:06 AM, Eduardo Bustamante wrote: > On Sun, May 21, 2017 at 11:29 AM, Pra

History Feature issue

2017-05-21 Thread Pranav Deshpande
The lssue here: https://savannah.gnu.org/support/?109000 interests me. It's something that I have experienced while using the shell. I am interested in solving it Any ideas so as how can I get started with the code base? Regards, Pranav

Interested in contributing to Bash

2017-05-21 Thread Pranav Deshpande
Hello everyone, I am a beginner when it comes to open source and am interested in contributing to GNU Bash. Any guidance on so as how to get started? Are there any tasks that I can take up so that I get introduced to the code base. Regards, Pranav.