[PATCH] bash.pc.in: use DEFS

2024-11-12 Thread Grisha Levit
If you try using Cflags from the generated pc file, presumably with something like: cc $(pkg-config --cflags bash) -c o myload myload.c the compilation is likely to fail because HAVE_CONFIG_H is not defined. --- support/bash.pc.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH] Makefile.in: add LIBINTL_H to install-headers

2024-11-12 Thread Grisha Levit
I'm not sure if this is the most idiomatic way to write the rule, but if a libintl.h is generated, it needs to make it into the installed headers directory to allow loadables to build. --- Makefile.in | 4 1 file changed, 4 insertions(+) diff --git a/Makefile.in b/Makefile.in index 00db8cbb.

Re: [PATCH] lib/readline/doc makefiles clean targets

2024-11-12 Thread Grisha Levit
On Thu, Nov 7, 2024 at 6:06 PM Chet Ramey wrote: > > On 11/4/24 9:44 AM, Mike Jonkmans wrote: > > > There are some issues though. Some less important. > > 1) After 'make distclean', it doesn't build: some .o files need y.tab.h. > > y.tab.h isn't part of the devel branch, you need bison to build it

Re: fg via keybind modifies tty settings

2024-11-12 Thread Chet Ramey
On 11/10/24 7:14 PM, Martin D Kealey wrote: Perhaps what's really needed is to make sure that "ordinary" commands bound using bash -x are completely broken (so people won't try to use them), rather than almost working. `Ordinary' commands aren't broken. Programs like vim that modify the termi

Re: "complete -o filenames" sometimes not working

2024-11-12 Thread Clark Wang
On Mon, Nov 11, 2024 at 10:51 PM Grisha Levit wrote: > > If your goal is to have readline do the quoting for you > Yes this is what I want to do. > , without treating the completions as filenames, the next version of bash > (5.3, see the 'devel' branch in the git repo) will have the '-o fullqu

Re: [PATCH] lib/readline/doc makefiles clean targets

2024-11-12 Thread Zachary Santer
On Thu, Nov 7, 2024 at 6:06 PM Chet Ramey wrote: > > If you find yourself in this sitution, it's easy enough to remove > parser-built and y.tab.c and run make again before I fix it. $ git clean -xfdq In MSYS2 on Windows, all the generated executables end in ".exe", which of course the .gitignore