Re: readline: How to unbind _all_ keys

2019-05-24 Thread Chet Ramey
On 5/24/19 10:51 AM, Henning wrote: > On 22/05/2019 15:30, Chet Ramey wrote: >> >> What error message did you get when trying to compile bash-5.0? I don't >> have or use cygwin, so you'll probably have to go to the cygwin bash >> maintainer, but we can at least try to point him in the right directi

Re: readline: How to unbind _all_ keys

2019-05-24 Thread Henning
On 22/05/2019 15:30, Chet Ramey wrote: What error message did you get when trying to compile bash-5.0? I don't have or use cygwin, so you'll probably have to go to the cygwin bash maintainer, but we can at least try to point him in the right direction. I tried to compile several times, but al

Re: [Patch] potentially uninitialized variable in rl_generic_bind

2019-05-24 Thread Chet Ramey
On 5/24/19 4:14 AM, Adam Richter wrote: > cppcheck noticed that, in the file lib/readline/bind.c, the function > rl_generic_bind contains a loop that declares a variable named ic in > the loop body, and relies on that variable being initialized with its > value from the previous iteration (in the l

[Patch] Remove unnecessary check in mkdir_builtin

2019-05-24 Thread Adam Richter
This second trivial patch fixes another cppcheck complaint. Don't worry. I'm not am not submitting a flood of rivial patches right now. I am only submitting these two right now, and I split them in two only because they are so unrelated to each other. In the pristine ftp.gnu.org version of bash-

[Patch] potentially uninitialized variable in rl_generic_bind

2019-05-24 Thread Adam Richter
cppcheck noticed that, in the file lib/readline/bind.c, the function rl_generic_bind contains a loop that declares a variable named ic in the loop body, and relies on that variable being initialized with its value from the previous iteration (in the line "prevkey = ic;"), which is not something tha