Re: indirect variable behavior breakage

2018-03-07 Thread christopher barry
On Wed, 7 Mar 2018 11:45:13 -0500 christopher barry wrote: ===8<---snip > > I am in fact using this method with associative arrays. > > I have a default hash that is full of default values for a particular > generic type of thing. Variations of this thing use many of the > defaults, but also s

Re: misleading error message from variable modifier

2018-03-07 Thread don fong
Chet Ramey wrote: > What are the most important features that you consider to lack unit tests? are there any tests that cover the variable modifiers, either unit tests or functional tests? is any of subst.c covered by unit tests? how do unit tests get run on this project? i don't see a unit tes

Re: indirect variable behavior breakage

2018-03-07 Thread christopher barry
On Wed, 7 Mar 2018 11:09:10 -0500 Greg Wooledge wrote: > On Wed, Mar 07, 2018 at 10:54:22AM -0500, christopher barry wrote: > > So yes 'ivar -3' is very, very bad indeed, and was a nasty bug, and > > I absolutely agree that making sure the string is a validly > > formatted var name before attempt

Re: indirect variable behavior breakage

2018-03-07 Thread Greg Wooledge
On Wed, Mar 07, 2018 at 10:54:22AM -0500, christopher barry wrote: > So yes 'ivar -3' is very, very bad indeed, and was a nasty bug, and I > absolutely agree that making sure the string is a validly formatted var > name before attempting to evaluate it is the right approach. > > My only request is

Re: indirect variable behavior breakage

2018-03-07 Thread christopher barry
On Wed, 7 Mar 2018 09:51:59 -0500 Chet Ramey wrote: > On 3/6/18 11:38 PM, christopher barry wrote: > > > Bash Version: 4.4 (does not work) > > Patch Level: 12 > > Release Status: release > > > > > > Description: > > > > a simple function that is used to test if a var is indirect or not > > an

Re: indirect variable behavior breakage

2018-03-07 Thread Chet Ramey
On 3/6/18 11:38 PM, christopher barry wrote: > Bash Version: 4.4 (does not work) > Patch Level: 12 > Release Status: release > > > Description: > > a simple function that is used to test if a var is indirect or not and > return the value whether indirect or simply a string is no longer > workin

indirect variable behavior breakage

2018-03-07 Thread christopher barry
From: cba...@rajant.com To: bug-bash@gnu.org Subject: indirect variable behavior breakage Configuration Information [Automatically generated, do not change]: Machine: x86_64 OS: linux-gnu Compiler: gcc Compilation CFLAGS: -DPROGRAM='bash' -DCONF_HOSTTYPE='x86_64' -DCONF_OSTYPE='linux-gnu' -DCONF_