Re: address XXX comment at lines 987-990 in bashfile.c

On Thu, Jul 09, 2015 at 01:53:52PM -0700, Bill Parker wrote: > Hello All, > >In reviewing the code at line 990 in bashfile.c, while the > issue of rl_line_buffer[0] = '\0', would it not be better to > use memset(rl_line_buffer, '\0', sizeof(rl_line_buffer)) to > clobber the entire line more ef

Re: missing sanity checks for malloc() in bash-4.3.3x in directory 'support', file 'man2html.c'

On 7/8/15 4:57 PM, Bill Parker wrote: > Hello All, > In reviewing code in directory 'support, file 'man2html.c', I found > numerous instances of calls to malloc() being made, without a check for > a return value of NULL, indicating failure. The patch file below adds > the checks after calls to

Re: Another out of bounds heap read in bash completion

On Fri, 10 Jul 2015 16:33:34 -0400 Chet Ramey wrote: > Perfect, thanks. Try the attached patch. Yep, fixes the bug. Thanks! -- Hanno Böck http://hboeck.de/ mail/jabber: ha...@hboeck.de GPG: BBB51E42 pgp7AW88NhmiX.pgp Description: OpenPGP digital signature

Re: Another out of bounds heap read in bash completion

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 7/10/15 4:15 PM, Hanno Böck wrote: > On Fri, 10 Jul 2015 16:00:25 -0400 > Chet Ramey wrote: > >> That helps, but they are strings, so can you print the string >> values? I'm interested in reproducing this instead of just guessing >> and not being

Re: segfault after disabling a loadable builtin

On 7/7/15 5:49 PM, Piotr Grzybowski wrote: > hi, > > maybe I am mistaken, but I think that keeping track of the > variables/functions bound/unbound by the loadable bultins leads to a > complete hell of unmanageable code. > It should be noted, that the builtins should clean by themselves, > e.g.,

Re: Another out of bounds heap read in bash completion

On Fri, 10 Jul 2015 16:00:25 -0400 Chet Ramey wrote: > That helps, but they are strings, so can you print the string > values? I'm interested in reproducing this instead of just guessing > and not being able to fix it at an appropriately high level. Thanks. pathname / x */ temp / -- Hanno Bö

Re: Another out of bounds heap read in bash completion

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 7/10/15 3:42 PM, Hanno Böck wrote: > On Fri, 10 Jul 2015 15:34:02 -0400 > Chet Ramey wrote: > >>> Here's the asan message on 4.4 alpha: >>> ==5999==ERROR: AddressSanitizer: heap-buffer-overflow on address >>> 0x602000 >> 002d6f at pc 0x5ca2b8 bp 0

Re: Another out of bounds heap read in bash completion

On Fri, 10 Jul 2015 15:34:02 -0400 Chet Ramey wrote: > > Here's the asan message on 4.4 alpha: > > ==5999==ERROR: AddressSanitizer: heap-buffer-overflow on address > > 0x602000 > 002d6f at pc 0x5ca2b8 bp 0x7fffc9d75240 sp 0x7fffc9d75230 > > READ of size 1 at 0x60202d6f thread T0 > > #0 0x

Re: Another out of bounds heap read in bash completion

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 7/10/15 2:38 PM, Hanno Böck wrote: > Hi Chet, > > On Fri, 10 Jul 2015 14:23:25 -0400 > Chet Ramey wrote: > >>> To reproduce: >>> a) compile bash with CFLAGS="-fsanitize=address -g" >>> b) type in a=/ a >>> c) go back with the cursor behind the ba

Re: Another out of bounds heap read in bash completion

On Fri, 10 Jul 2015 14:41:04 -0400 Chet Ramey wrote: > On 7/10/15 2:38 PM, Hanno Böck wrote: > > On Fri, 10 Jul 2015 14:23:25 -0400 > > Chet Ramey wrote: > > > >>> To reproduce: > >>> a) compile bash with CFLAGS="-fsanitize=address -g" > >>> b) type in a=/ a > >>> c) go back with the cursor beh

Re: Another out of bounds heap read in bash completion

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 7/10/15 2:38 PM, Hanno Böck wrote: > Hi Chet, > > On Fri, 10 Jul 2015 14:23:25 -0400 > Chet Ramey wrote: > >>> To reproduce: >>> a) compile bash with CFLAGS="-fsanitize=address -g" >>> b) type in a=/ a >>> c) go back with the cursor behind the ba

Re: Another out of bounds heap read in bash completion

Hi Chet, On Fri, 10 Jul 2015 14:23:25 -0400 Chet Ramey wrote: > > To reproduce: > > a) compile bash with CFLAGS="-fsanitize=address -g" > > b) type in a=/ a > > c) go back with the cursor behind the backslash and press tab > > Thanks for the report. I've attached a patch that should address th

Re: Another out of bounds heap read in bash completion

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 7/6/15 6:46 PM, Hanno Böck wrote: > Hi, > > With Address Sanitizer I discovered another out of bounds read issue in > bash. This is different from the issue I recently reported here and > for which Chet already provided a patch: > https://lists.gnu

problem with local -

Using local - calls set_ignoreeof() when unwinding "function_calling". As a result, you have to press ^D 10 times to exit the shell. Anyway, $IGNOREEOF is not changed and shopt -o ignoreeof reports off. I'm attaching the relevant part of a backtrace from gdb. --- xoxo iza gdb-trace Description

Bash-4.4-alpha available for FTP

The first alpha release of bash-4.4 is now available with the URL ftp://ftp.cwru.edu/pub/bash/bash-4.4-alpha.tar.gz This tar file includes the formatted documentation (you should be able to generate updated versions yourself). This release fixes many outstanding bugs in bash-4.3 and introduces s

Troubles with autocompletion of filenames with square brackets

Configuration Information [Automatically generated, do not change]: Machine: x86_64 OS: linux-gnu Compiler: x86_64-pc-linux-gnu-gcc Compilation CFLAGS: -DPROGRAM='bash' -DCONF_HOSTTYPE='x86_64' -DCONF_OSTYPE='linux-gnu' -DCONF_MACHTYPE='x86_64-pc-linux-gnu' -DCONF_VENDOR='pc' -DLOCALEDIR='/usr/s