Re: AC_C_INLINE with -Werror llvm 3.4

2014-06-09 Thread Eric Blake
On 06/09/2014 09:59 AM, Kurt Schwehr wrote: > Eric, > > Thanks for the feedback. I definitely had the feeling that it would be > impossible to get rid of all warnings for all compilers. > > Two questions back at you: > > 1) Do you have a example of a source package that handles -Werror in a > c

Re: AC_C_INLINE with -Werror llvm 3.4

2014-06-09 Thread Kurt Schwehr
Eric, Thanks for the feedback. I definitely had the feeling that it would be impossible to get rid of all warnings for all compilers. Two questions back at you: 1) Do you have a example of a source package that handles -Werror in a clean way so that I can use it a s model try to add the same to

Re: AC_C_INLINE with -Werror llvm 3.4

2014-06-09 Thread Eric Blake
On 06/08/2014 10:25 AM, Kurt Schwehr wrote: > I'm trying to clean hdf5 1.9.182 a bit and I'm using -Werror as my first > pass tool. Just cleaning the messages that come up. However, passing > -Werror as CPPFLAGS causes configure to die on a number of places. Don't do that. It is not possible to

Re: AC_C_INLINE with -Werror llvm 3.4

2014-06-08 Thread Kurt Schwehr
Yes. My patch is indeed missing a (). > Are't you missing () there to actually call the function? > > -- > VZ git diff diff --git a/lib/autoconf/c.m4 b/lib/autoconf/c.m4 index b58e42d..74c6aa8 100644 --- a/lib/autoconf/c.m4 +++ b/lib/autoconf/c.m4 @@ -1742,7 +1742,7 @@ for ac_kw in inline __inli

Re: AC_C_INLINE with -Werror llvm 3.4

2014-06-08 Thread Václav Zeman
On 8.6.2014 18:25, Kurt Schwehr wrote: > I'm trying to clean hdf5 1.9.182 a bit and I'm using -Werror as my first > pass tool. Just cleaning the messages that come up. However, passing > -Werror as CPPFLAGS causes configure to die on a number of places. Here is > a first one with a proposed fix.