bug#70331: [PATCH] Call custom folding functions with consistent point

2024-04-15 Thread Arash Esbati
Paul Nelson writes: > Just to be clear: bug or devel? If you want to send a patch, then bug, if you want to discuss the point, devel, I'd say. > There's some discussion on the magit repo at > https://github.com/magit/magit/issues/2848 (but no solution there, > from what I can tell). I can hard

bug#70331: [PATCH] Call custom folding functions with consistent point

2024-04-15 Thread Paul Nelson
> I can't tell why Emacs sets `fill-column' to 64 in `log-edit-mode', but > I'd like to follow this convention until Emacs changes it. So I'd be > grateful if you could stick to 64 in your config as well. Will do - I guess my point is then that if you want your own edits in ChangeLog to behave in

bug#70331: [PATCH] Call custom folding functions with consistent point

2024-04-14 Thread Arash Esbati
Paul Nelson writes: > OK, I see. The commit that you shared improves the situation for > vc.el, except that I think 64 should be 66 (= 74 - 8). I attach what > I'm using, which also tells magit how long the summary should be. Hi Paul, I can't tell why Emacs sets `fill-column' to 64 in `log-ed

bug#70331: [PATCH] Call custom folding functions with consistent point

2024-04-14 Thread Paul Nelson
Hi Arash, OK, I see. The commit that you shared improves the situation for vc.el, except that I think 64 should be 66 (= 74 - 8). I attach what I'm using, which also tells magit how long the summary should be. Unfortunately, I don't see a way to set the fill-column in magit via directory local v

bug#70331: [PATCH] Call custom folding functions with consistent point

2024-04-14 Thread Arash Esbati
Paul Nelson writes: > OK, I think I understand. Just to be sure: your workflow is to edit a > "dummy" ChangeLog file while preparing a commit (in the auctex folder, > so that the .dir-locals.el are in effect), then copy this into the > actual commit message (in vc.el or magit) and delete the lea

bug#70331: [PATCH] Call custom folding functions with consistent point

2024-04-14 Thread Paul Nelson
Hi Arash, OK, I think I understand. Just to be sure: your workflow is to edit a "dummy" ChangeLog file while preparing a commit (in the auctex folder, so that the .dir-locals.el are in effect), then copy this into the actual commit message (in vc.el or magit) and delete the leading tabs? Thanks,

bug#70331: [PATCH] Call custom folding functions with consistent point

2024-04-14 Thread Arash Esbati
Hi Paul, Paul Nelson writes: > I've generally been trying to remember to set fill-column to 63 > (following my interpretation of > https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE#n243), but > guess I forgot here -- I suspect I used 70, which seems to be the > default for me via magit

bug#70331: [PATCH] Call custom folding functions with consistent point

2024-04-13 Thread Paul Nelson
Hi Arash, > How do you generate the changelog above? When I paste the entry in my > ChangeLog inside my local repo and re-fill, it looks like this: > > * tex-fold.el (TeX-fold-hide-item): Call folding spec with point > at beginning of item. > * doc/auctex.texi (Folding): Mention the new con

bug#70331: [PATCH] Call custom folding functions with consistent point

2024-04-13 Thread Arash Esbati
Hi Paul, Paul Nelson writes: > From 594ff7ad7454d42dbab37e213714f9827e1061b1 Mon Sep 17 00:00:00 2001 > From: Paul Nelson > Date: Thu, 11 Apr 2024 07:33:21 +0200 > Subject: [PATCH] Call custom folding functions with consistent point Thanks for patch, I installed it (5f40b686b4). I have one qu

bug#70331: [PATCH] Call custom folding functions with consistent point

2024-04-10 Thread Paul Nelson
Hello, As you know, one way to customize TeX-fold-mode is to supply functions to the variables TeX-fold-*-spec-list, which are then called by TeX-fold-hide-item. This patch introduces the convention that such functions are called with point positioned at the beginning of the item to be folded. T